Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 23 Jun 2023 13:38:43 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     =?utf-8?Q?C=C3=A9dric?= Le Goater <clegoate@redhat.com>
Cc:     ankita@nvidia.com, alex.williamson@redhat.com, aniketa@nvidia.com,
        cjia@nvidia.com, kwankhede@nvidia.com, targupta@nvidia.com,
        vsethi@nvidia.com, acurrid@nvidia.com, apopple@nvidia.com,
        jhubbard@nvidia.com, danw@nvidia.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/1] vfio/nvgpu: Add vfio pci variant module for grace
 hopper
Message-ID: <ZJXKk1csyLTfIRmm@nvidia.com>
References: <20230622030720.19652-1-ankita@nvidia.com>
 <46a79333-12f6-229f-86f9-1e79bdba7d11@redhat.com>
 <ZJWGbsaMzHvqqewi@nvidia.com>
 <62dcff6b-852d-4a85-dfd4-0ce1f324602e@redhat.com>
 <ZJWZA8ogUlGegx2C@nvidia.com>
 <4b0f4def-e2bd-b7b2-7c70-1df741780e1c@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <4b0f4def-e2bd-b7b2-7c70-1df741780e1c@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?em53V0hyTitNUG1Ta2xPL1RTbkJRVXR2UU05azVPSmVRVC9VY3FOZmVpaXpz?=
 =?utf-8?B?OWZOUEVPZTRTYkpUQjhKcGxhYzd1N0JkSFBhTWd3NmZLaHNXRUdxQ1AyUHpT?=
 =?utf-8?B?dUhmTEZrcDUyQXlhRWtiUGxTenpHaFAyNUFSUjRMRTNZT1hCNk9BaEVwNDd1?=
 =?utf-8?B?WGFFTWJ6bWhXSDViY3hoWGlkN0g5aXNaMS9uZ0RxMm1iVjk4YXliZTc5eU91?=
 =?utf-8?B?a0VGZXQ2RjRzY1ovNUZ6L01NM0JqWllSaWJSVWtQOUsxRWhZbFpxb1N4Skp4?=
 =?utf-8?B?OEwyWGlpMzJmMkZBdHhrZXduZUNXalMwN0MvY2hGbEMrVWs2TzRESlhPampW?=
 =?utf-8?B?blR0TkwxZzRxZ3NIczdWQ01SRHYvMkVVTU01YTZLTi9xT09zZ1dvV2RubVlU?=
 =?utf-8?B?SllVSXUxVTNBZUVZdm9iZVJmaDNFbVgrcWxxWVNzejRvSlk5Q1A1TkxKbU5G?=
 =?utf-8?B?UUJnS2hRTVBMZjRUV3lNZ0x2cmw2MDV6N1U2YllmU3loUEdjQzduTktRcGxN?=
 =?utf-8?B?NEtVY1gwZ0ViSFpXZ0VQMU5ycmZzN0VJenFZdDV3WUN2SmpWVTRHd1hmOEo0?=
 =?utf-8?B?ZzgvTi85U3puZUs4dFFwREtWaWxMSExUZWkrcGhOZ01oM3AxbmVkMkpDU2pJ?=
 =?utf-8?B?a1A4OFFiU09oM3o3bHBXWnkyMExmWWhPOER0ZGNqSVlwbzhHSGRkbVBlV212?=
 =?utf-8?B?Sml3SmlDWVlScFYzODk0VEE2ZU01T0NYTjUySnIwWWhzaFo2dmFpUXVTb2w5?=
 =?utf-8?B?WFd4VTlSQ2s2alltSk9PYXZmQlNTZXl3YjUxdCtnNjBrNWV3d1RNWFFOL3g0?=
 =?utf-8?B?L2t1T2dITmMrWEttQnNiaS9XbnNmbENLTjJSZk14VHEwZml1L0RaY0g2Qkxy?=
 =?utf-8?B?NUJFL1hRQ2pNLzZHS0N5T0hMbVNCWEJyS3dPN0JlWDJFU2Z6Wm1HNWJzQnNp?=
 =?utf-8?B?THk5NGpDcHVqTzc4d3o5ZUR2b0lXZUdMdDkyR3dHOTh3aWtkTHJwSTIzNlF2?=
 =?utf-8?B?LzBYSmdzOGp3MTE3M2RHWEhPRHdTRWlOVjAxL3NqOFN1VzdJb1ZySnVxbUd0?=
 =?utf-8?B?L0kzemUyb2l2cnpLeXp6SFY5TXJ2Nkg0SzR1c3dnYW1IUlUxRHI4VHE4WlBa?=
 =?utf-8?B?Z1hFUTZWUlFqOUdjK3hORm1Pd0NBY1hSbTVibzZuYWtiL3VlUU5VQzk5Mjkz?=
 =?utf-8?B?K3FqUlVNSEJtOWQ5RCtYdjBJOTJzYlY3WmJXdjFITVVuajNDT3VVTmUreG80?=
 =?utf-8?B?aU56ZzhHcnppelRhM0NjUnhNK3VFM2pFR0NPeFVuWkZEeXBkZkRsVHJMVlhi?=
 =?utf-8?B?aFV4MUtONm5hRGlBQnowSmhGY2JnMjJQSmZJR3lYNnA4dEQrRVpNRTR1akty?=
 =?utf-8?B?WndySzRMQVkwNC9yeFlNcHlKMHVUU0FFN0FjaE5YcmV3bDBVUnd0NlpMQW5r?=
 =?utf-8?B?dVA5cXFTOEFyd0JCbGIxMmhpbXkwTFg3ZWVpQmE3aURiWU1MYnVkeGtYTlky?=
 =?utf-8?B?VXdpbE9PY1RCSGhDVFI4RklmbmY2OEcyQXJTa2pQVUVjaUJQbzFPTVI3b2o3?=
 =?utf-8?B?Mk5WVWw2Vk0zSXFpbFFCaTlWc2J2QUhUVC80cHVzY2k3a0ppSUprVm41dUZJ?=
 =?utf-8?B?eklnMTJ2WncydzJMeUJkNUg0USsxaWZJTnZob1h0QkVjV2k1ZmFVSXlyZ0ha?=
 =?utf-8?B?RWhUT3Q2ajVBNjJ2Z1RaNlN1QjBsRnI2ZUErTDE0QWVuSlZxNzVEczFvUzl2?=
 =?utf-8?B?UkxidU91NDFmMkZJSGkyblYvQXRwUGIvRWVTMC9JdjNHTHgxK2htSHhTbCtM?=
 =?utf-8?B?cmVaZzQwSjZ1NVZNRGVFWGdDemVXNnFDVUJNd3pOdUhabXhsZWdaZWRkSUFN?=
 =?utf-8?B?YzhDLzFrY0FFdnQ5d3dMUkduL3hZMllSLyt3TndQZWNaM1lPUk1seFhubGov?=
 =?utf-8?B?Ym8zSHp0QVlWdW40NCtUVU9oS0g3QjN6QlRFcXo5ZDB0VFN2QUJIT1NQcEdn?=
 =?utf-8?B?MGIydENHVFdueTEveENuU1FSMm9MaytVOTN2aUdpZTExQ0V4c1hwbGlGa2No?=
 =?utf-8?B?b1JYbDFoWDhzZkVBOXJxeEFLOVRjRGhtRTFJQjF6dXRNTWNlZjY5MUROVUJo?=
 =?utf-8?Q?CRzGeNyRGDv1/b1AkrQT4Nb7K?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c3b5a676-aecf-45e4-7e53-08db7408502d
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2023 16:38:45.8014
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kwxavs5ew2e901TGyxCBWRP9EwTh+SGV4FITEZKrdzGdhMIEmhL/HZp/b1iXwqAk
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8333
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 23, 2023 at 05:07:37PM +0200, Cédric Le Goater wrote:
> On 6/23/23 15:07, Jason Gunthorpe wrote:
> > On Fri, Jun 23, 2023 at 03:04:17PM +0200, Cédric Le Goater wrote:
> > > On 6/23/23 13:47, Jason Gunthorpe wrote:
> > > > On Fri, Jun 23, 2023 at 08:27:17AM +0200, Cédric Le Goater wrote:
> > > > > > +	req_len = vma->vm_end - vma->vm_start;
> > > > > > +	pgoff = vma->vm_pgoff &
> > > > > > +		((1U << (VFIO_PCI_OFFSET_SHIFT - PAGE_SHIFT)) - 1);
> > > > > > +	if (pgoff >= (nvdev->mem_prop.mem_length >> PAGE_SHIFT))
> > > > > > +		return -EINVAL;
> > > > > 
> > > > > you cound introduce accessor macros for nvdev->mem_prop.mem_length and
> > > > > nvdev->mem_prop.hpa
> > > > 
> > > > Accessors are not the usual style..
> > > 
> > > I meant something like
> > > 
> > >    #define nvgpu_mem_size(nvdev) (nvdev)->mem_prop.mem_length
> > >    #define nvgpu_mem_pa_base(nvdev) (nvdev)->mem_prop.hpa
> > > 
> > > This is minor.
> > 
> > Yeah, this is what I thought you ment, I'm against this kind of
> > obfuscation in the kernel without a very strong purpose, and if you do
> > something like this it should be a static inline function.
> 
> OK. We could drop the intermediate struct attribute instead then.

Yah, if the struct isn't needed for some other reason

Jason