Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: iac594737:Fastmail
Date:   Fri, 23 Jun 2023 12:47:08 -0400
From:   Demi Marie Obenour <demi@invisiblethingslab.com>
To:     Stephen Rothwell <sfr@canb.auug.org.au>,
        Alasdair G Kergon <agk@redhat.com>,
        Mike Snitzer <snitzer@kernel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the device-mapper tree
Message-ID: <ZJXMkd0eOEBnpUw2@itl-email>
References: <20230623143011.7deba53c@canb.auug.org.au>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="PNJM2LfTtJi3ok2p"
Content-Disposition: inline
In-Reply-To: <20230623143011.7deba53c@canb.auug.org.au>
Precedence: bulk


--PNJM2LfTtJi3ok2p
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Fri, 23 Jun 2023 12:47:08 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
	Alasdair G Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the device-mapper tree

On Fri, Jun 23, 2023 at 02:30:11PM +1000, Stephen Rothwell wrote:
> Hi all,
>=20
> After merging the device-mapper tree, today's linux-next build (i386
> defconfig) failed like this:
>=20
> In file included from include/linux/kernel.h:30,
>                  from arch/x86/include/asm/percpu.h:27,
>                  from arch/x86/include/asm/current.h:10,
>                  from include/linux/sched.h:12,
>                  from include/linux/kthread.h:6,
>                  from drivers/md/dm-core.h:13,
>                  from drivers/md/dm-ioctl.c:9:
> drivers/md/dm-ioctl.c: In function 'next_target':
> include/linux/kern_levels.h:5:25: error: format '%lu' expects argument of=
 type 'long unsigned int', but argument 3 has type 'unsigned int' [-Werror=
=3Dformat=3D]
>     5 | #define KERN_SOH        "\001"          /* ASCII Start Of Header =
*/
>       |                         ^~~~~~
> include/linux/printk.h:427:25: note: in definition of macro 'printk_index=
_wrap'
>   427 |                 _p_func(_fmt, ##__VA_ARGS__);                    =
       \
>       |                         ^~~~
> include/linux/printk.h:498:9: note: in expansion of macro 'printk'
>   498 |         printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
>       |         ^~~~~~
> include/linux/kern_levels.h:11:25: note: in expansion of macro 'KERN_SOH'
>    11 | #define KERN_ERR        KERN_SOH "3"    /* error conditions */
>       |                         ^~~~~~~~
> include/linux/printk.h:498:16: note: in expansion of macro 'KERN_ERR'
>   498 |         printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
>       |                ^~~~~~~~
> include/linux/device-mapper.h:626:25: note: in expansion of macro 'pr_err'
>   626 | #define DMERR(fmt, ...) pr_err(DM_FMT(fmt), ##__VA_ARGS__)
>       |                         ^~~~~~
> drivers/md/dm-ioctl.c:1421:17: note: in expansion of macro 'DMERR'
>  1421 |                 DMERR("Next dm_target_spec (offset %u) is not %lu=
-byte aligned",
>       |                 ^~~~~
> cc1: all warnings being treated as errors
>=20
> Caused by commit
>=20
>   5df1daff2cc6 ("dm ioctl: Check dm_target_spec is sufficiently aligned")

Ugh, sorry about that.  I=E2=80=99m pretty sure the code would actually work
okay at runtime since unsigned long and unsigned int are passed the same
way, but this is still a bug.

> I have applied the following patch for today:
>=20
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Fri, 23 Jun 2023 14:24:29 +1000
> Subject: [PATCH] fix up for "dm ioctl: Check dm_target_spec is sufficient=
ly aligned"
>=20
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/md/dm-ioctl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c
> index 5f0b641538d8..8b480d7825fe 100644
> --- a/drivers/md/dm-ioctl.c
> +++ b/drivers/md/dm-ioctl.c
> @@ -1418,7 +1418,7 @@ static int next_target(struct dm_target_spec *last,=
 uint32_t next, const char *e
>  	}
> =20
>  	if (next % __alignof__(struct dm_target_spec)) {
> -		DMERR("Next dm_target_spec (offset %u) is not %lu-byte aligned",
> +		DMERR("Next dm_target_spec (offset %u) is not %zu-byte aligned",
>  		      next, __alignof__(struct dm_target_spec));
>  		return -EINVAL;
>  	}
> --=20
> 2.39.2

That fix is correct, thanks!
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--PNJM2LfTtJi3ok2p
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmSVzJAACgkQsoi1X/+c
IsH60g/+NCH4eD7P5GyFdcqFNWM/aI3nn9Uu7FNb6Xr4y2T3cmIKrGvGHOYAunm4
AF00Y0OuDq53do4Ruf6fc2Jufb4IDJR19rHU4dFX5r1L462SOno0e1eFmsgzvTat
P9GnKuPTsHTgLf9oWV6ACNqdM7G4v57sRsGCm4cvpFSz8CreOM7P8lwer0gyJy0+
Lfk+CIWJat+ICEhj2+qmXert16D3eQVNpnFHCMs09414J/GnL1E717bdJycZ3dug
FSidDTf4t66rGcuU95AEzEFCrHEBnn5hJmKdQuW/Bg+QXFcPMWqPhOZ0DG/Yqw+S
VKbaDfYcmCA03bwgVP9kNX8nU3sipJifXmqyGrFo6pOHbMcr3SBcW7SLeGSiPd3J
TDja4Ja+bOIQjIPCrxzqwnNxS/FrGgiOwvHwNPJjxfpIsSGTonPDsq4D4A7S9D9k
JtRx6U+mscjIwvz2O8qcsl9z0mwHBCIhQe28TZ1u3Yo1e9OLazrAkO28fHb3/U80
l6arsce9dpWpKB4Dtc/sw6u/2XhnlCIUa2hoF8wzPVdOGcvlsX5utQG+vbiu04yW
y+5bB/i2z09q2gZzCA+19qE0q8gvRSgSuKIDTVWgeTAndUb1YzUaOKAgk0izt/KQ
pcgcv15XK19taV1Jo/LGey7jt6I3j2SQfwIMM4u8AX5+WAHxeqc=
=qJJP
-----END PGP SIGNATURE-----

--PNJM2LfTtJi3ok2p--