Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp12752080rwd; Fri, 23 Jun 2023 10:08:45 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4+ET9un7nchYXV9X9tm/LzWHdeB92mpsjDMyVB2tRCAStB0MpT6uVALkxCGf1uz3R5gyU9 X-Received: by 2002:a17:902:efcd:b0:1af:b97c:2353 with SMTP id ja13-20020a170902efcd00b001afb97c2353mr16942165plb.15.1687540125362; Fri, 23 Jun 2023 10:08:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687540125; cv=none; d=google.com; s=arc-20160816; b=vVq53DDdnyegd0PyKU/JYJdWvURTFJdT47M0+jzjMmzLBjKX17QE51MqkcdI2frX4Z 153WCjItkBpKKhn7MEPOMHBMlKwb/U31/IUO3CCDjpDoRgSkrT9Yn0q4ou/p5mr7j5aL 3O0SRxICNfVAbIKQ3Q2SzFBcX6gNjUQ6hwGIWnamsqWC8jGnmEwxzhfPfwsS7Hne78XN ADlDZmrSAdtdSdJ8aeL/8NqrFWwMti4n95qz2YYw9tQyrf0nDi3VgYQZPROOeBCLuAJL ujfa4z+b1/B6a/Q65VyRUUIc2Iuat7KIOKCrV9Gk8kD6tEtXqeS9PyViM5a9Ae7e8dfT RWAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=yjZj3NJ6tNL43fD8olUI2ckbffSX6NxYGeL5Kbsd15w=; b=qFFb6NNiJuTnsZe1mqTQQ3QUPHcp1NOrragaFOlE18GXesdMnXh8P8K5mCBbXev+cU 7L5IgBqUUXz/1bSWjhqrFPqYvLYL0UwBWcNDISULaUaDbffYPZsHgK8uR1oCRG6Z2Cvf +zWQmm4lZW7yctPk39lnvy60DI4YL6kSDMuK4PEd0AqNI3eGQyVX/S1dLMplMxrfX8WL 44vHNatbSNuEDCPDGCvS9WaruxVu1OS1X4sxCRf/h8wPtmdINb7+ASpl1g3sG0zmVSDN AtJTQ5X1XeAqPuWOYpDLMsOTr1Ln4CDM4ddYuL741RYo+h5LAuwMOKHatnCPk4XUb+qO JzwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=R1isnHBB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a7-20020a170902ecc700b001b3af7e375fsi9669228plh.559.2023.06.23.10.08.26; Fri, 23 Jun 2023 10:08:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=R1isnHBB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232181AbjFWQcF (ORCPT + 99 others); Fri, 23 Jun 2023 12:32:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231925AbjFWQcC (ORCPT ); Fri, 23 Jun 2023 12:32:02 -0400 Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD8F6271F for ; Fri, 23 Jun 2023 09:32:00 -0700 (PDT) Received: by mail-qv1-xf36.google.com with SMTP id 6a1803df08f44-630066deb1dso7340036d6.3 for ; Fri, 23 Jun 2023 09:32:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1687537920; x=1690129920; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yjZj3NJ6tNL43fD8olUI2ckbffSX6NxYGeL5Kbsd15w=; b=R1isnHBBwVrgX9qa7AlsKhyGqLKNWhaxQDytnzIrvagW7RrRJJd/7E4Jv7J5xW37fN ZJiwLTMzva5iBTSQRN1jHnvm4kJDixA4gECanSgwBdUDVFzAZjwVMSUrMribVOeO1dbj TOYp58RsjRx4zs5ztbwLxPDHKfGhf0vTGXUAWId9gmOVFHxaMvnIPglVs+EVJ/o8OQoT Q/H747d/lPF0u1HAY7OhMjerSUExP5JUZAm/zKMTRZqruSemOEYyLG3YUxumw03PcXVp bsn/lCwZMelCPLy8OoCoeyE14XDebACrCq2aNBWvsLUxah47fqSMBXe7gKKlKjwTvjtv EUYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687537920; x=1690129920; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yjZj3NJ6tNL43fD8olUI2ckbffSX6NxYGeL5Kbsd15w=; b=DoZOfOug+atGxzeLZtISRyZTnEhs08gwSH+K/CJpvSb1ynXR0iPpp2BryOxrH9DWgw Tdd5jLEGJIAUwHj3UAeJb6j0wqxXvW2eQo5SU18IqEcwaFNyjnjyeyYDT1ISaq3etGDY 0Wny2HbIodsTre2Wha36hy3SmxVcGmlonao9Zg6Msd/JRyw8sr9vSZ4QlKw/thZoTF/s VoQEpdsoGyxn0dIcmbnohSBLVAtRQ/JrY3h2KEw8eIrmlSjs+vYBHJhuAjUyKvrg3tvF VcvK4X01iiGkB0EIsBg7VXh+uQEsnIt2zIFPnZu/YVJaRpIfzD3OTMhZgEsYFv37cjNm 4GUw== X-Gm-Message-State: AC+VfDwWSMa1Wz6uk5MQesEx+I+ibDdYow948YECfCA7O25+TETmDZOy pRlmdbYCobLdiMxRj0Ye6xJxr4TtXJvO34qzglBXsw== X-Received: by 2002:a05:6214:2a8e:b0:626:3dee:6091 with SMTP id jr14-20020a0562142a8e00b006263dee6091mr26135505qvb.49.1687537919844; Fri, 23 Jun 2023 09:31:59 -0700 (PDT) MIME-Version: 1.0 References: <20230623134351.1898379-1-kernel@xen0n.name> <20230623134351.1898379-9-kernel@xen0n.name> In-Reply-To: <20230623134351.1898379-9-kernel@xen0n.name> From: Nick Desaulniers Date: Fri, 23 Jun 2023 09:31:49 -0700 Message-ID: Subject: Re: [PATCH 8/9] Makefile: Add loongarch target flag for Clang compilation To: WANG Xuerui Cc: Huacai Chen , WANG Rui , Xi Ruoyao , loongarch@lists.linux.dev, linux-kbuild@vger.kernel.org, llvm@lists.linux.dev, linux-kernel@vger.kernel.org, WANG Xuerui Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 23, 2023 at 6:44=E2=80=AFAM WANG Xuerui wro= te: > > From: WANG Xuerui > > The LoongArch kernel is 64-bit and built with the soft-float ABI, > hence the loongarch64-linux-gnusf target. (The "libc" part doesn't > matter.) Technically, IIRC llvm may make different decisions on libcall optimizations based on the libc part of the target triple. For instance, is bcmp defined in that libc or not? That's why we specify -gnu or -musl (I forgot we did that for hexagon) explicitly rather than leave that part of the triple blank. Minutia that doesn't need to be in this commit message, but now it's explicitly documented on LKML and linkable-to. > > Signed-off-by: WANG Xuerui Thanks for the patch! Reviewed-by: Nick Desaulniers > --- > scripts/Makefile.clang | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/scripts/Makefile.clang b/scripts/Makefile.clang > index 058a4c0f864e..6c23c6af797f 100644 > --- a/scripts/Makefile.clang > +++ b/scripts/Makefile.clang > @@ -4,6 +4,7 @@ > CLANG_TARGET_FLAGS_arm :=3D arm-linux-gnueabi > CLANG_TARGET_FLAGS_arm64 :=3D aarch64-linux-gnu > CLANG_TARGET_FLAGS_hexagon :=3D hexagon-linux-musl > +CLANG_TARGET_FLAGS_loongarch :=3D loongarch64-linux-gnusf > CLANG_TARGET_FLAGS_m68k :=3D m68k-linux-gnu > CLANG_TARGET_FLAGS_mips :=3D mipsel-linux-gnu > CLANG_TARGET_FLAGS_powerpc :=3D powerpc64le-linux-gnu > -- > 2.40.0 > > --=20 Thanks, ~Nick Desaulniers