Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0239d17b-eb8a-8feb-d8a4-a7f82edfa612@quicinc.com>
Date:   Fri, 23 Jun 2023 22:07:17 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH V4 0/4] Add camera clock controller support for SM8550
Content-Language: en-US
To:     Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
CC:     Konrad Dybcio <konrad.dybcio@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Taniya Das <quic_tdas@quicinc.com>,
        "Satya Priya Kakitapalli" <quic_skakitap@quicinc.com>,
        Imran Shaik <quic_imrashai@quicinc.com>,
        Ajit Pandey <quic_ajipan@quicinc.com>
References: <20230609115058.9059-1-quic_jkona@quicinc.com>
 <88b41c0f-e515-ce94-e4fd-befbeef53781@linaro.org>
 <65fd51f1-56d9-7b7b-7757-229cbb65051d@quicinc.com>
 <CAA8EJpoLWm4=1J2QTfh9N55U-FjuYA7CwJeoG=Zv4mOhC1nytQ@mail.gmail.com>
From:   Jagadeesh Kona <quic_jkona@quicinc.com>
In-Reply-To: <CAA8EJpoLWm4=1J2QTfh9N55U-FjuYA7CwJeoG=Zv4mOhC1nytQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 6/14/2023 5:47 PM, Dmitry Baryshkov wrote:
> On Wed, 14 Jun 2023 at 14:58, Jagadeesh Kona <quic_jkona@quicinc.com> wrote:
>>
>>
>>
>> On 6/9/2023 6:24 PM, Konrad Dybcio wrote:
>>>
>>>
>>> On 9.06.2023 13:50, Jagadeesh Kona wrote:
>>>> Add bindings, driver and devicetree node for camera clock controller on
>>>> SM8550.
>>>>
>>>> Jagadeesh Kona (4):
>>>>     dt-bindings: clock: qcom: Add SM8550 camera clock controller
>>>>     clk: qcom: camcc-sm8550: Add camera clock controller driver for SM8550
>>>>     clk: qcom: camcc-sm8550: Add support for qdss, sleep and xo clocks
>>>>     arm64: dts: qcom: sm8550: Add camera clock controller
>>> What's the final verdict on RINGOSC_L etc.?
>>>
>>> Konrad
>>
>> We would like to pass RINGOSC_CAL_L field directly in config->l value
>> itself and reuse existing code rather than adding a separate function
>> for lucid ole pll configure.
> 
> As I wrote in another email, it doesn't sound like a good approach.
> 

Will avoid this approach and use separate clk_lucid_ole_pll_configure() 
to configure lucid ole PLL's in next series.

Thanks,
Jagadeesh

>>
>> Thanks,
>> Jagadeesh
>>
>>>>
>>>>    .../bindings/clock/qcom,sm8450-camcc.yaml     |    8 +-
>>>>    arch/arm64/boot/dts/qcom/sm8550.dtsi          |   15 +
>>>>    drivers/clk/qcom/Kconfig                      |    7 +
>>>>    drivers/clk/qcom/Makefile                     |    1 +
>>>>    drivers/clk/qcom/camcc-sm8550.c               | 3585 +++++++++++++++++
>>>>    include/dt-bindings/clock/qcom,sm8550-camcc.h |  187 +
>>>>    6 files changed, 3801 insertions(+), 2 deletions(-)
>>>>    create mode 100644 drivers/clk/qcom/camcc-sm8550.c
>>>>    create mode 100644 include/dt-bindings/clock/qcom,sm8550-camcc.h
>>>>
> 
> 
>