Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 23 Jun 2023 10:19:06 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>, <ira.weiny@intel.com>,
        <dan.j.williams@intel.com>, <vishal.l.verma@intel.com>,
        <dave.jiang@intel.com>, <oohall@gmail.com>,
        <aneesh.kumar@linux.ibm.com>
CC:     <nvdimm@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
        Jiasheng Jiang <jiasheng@iscas.ac.cn>
Subject: Re: [PATCH] libnvdimm/of_pmem: Add check and kfree for kstrdup
Message-ID: <6495d40a1974c_4ccfa29497@iweiny-mobl.notmuch>
References: <20230622143800.31779-1-jiasheng@iscas.ac.cn>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230622143800.31779-1-jiasheng@iscas.ac.cn>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SFvo3So+vREWgxoLbl+6YYMMVpgpQQ5tHlhUSX3f07OJYSCFkJtpJphMua6g?=
 =?us-ascii?Q?pwZhGuwQ5IaY0arBop0WYR20VCCajPo6f4DBgn+YmjuOSgPJX+HLb5kxhcUa?=
 =?us-ascii?Q?BiNOvQcqcjqm9uiDB6vlt+Ju/t+F9ZDBKMebGOZBku443y3KyHY/YubafI4+?=
 =?us-ascii?Q?3MUYb0VsAkeanbtWAcoOEbht7WhVu4AB/vPDEZeDfDVYNhjVnKcxBeZZe41D?=
 =?us-ascii?Q?hf9gui7AR9IMZZKUA1e5p0ydBs/tPqiI9mF80+3mnO3LTO0Gif1fFceBCbmM?=
 =?us-ascii?Q?BAj8hDljE83MAwbzRMEoj+ChoqjjuXsFgBEd6jMw9AiHxRT7JT4fdH9T4Cwk?=
 =?us-ascii?Q?0JMZImJRqNWXv63yiN0a8E4UGG84zmpHqsgy8vmxi9T4PtFIuEhXCY34peVM?=
 =?us-ascii?Q?LOk3p8cV8KmoZyipwnl6UaD+iak1xnRhgJ4rSYjgo+AZFAnblM1aTTV4D/Xa?=
 =?us-ascii?Q?use9QDEZVfKALnC5I7Ys1A70IeKQ66BEC+FcoEFiIkEZqfVEQa+NMqhEU5xY?=
 =?us-ascii?Q?VOvuOs9hNWzTmyfQyh50ZVbIqG4Hdw1VvkdpeXLHgXn/FtmQ9QsbqSxQXCii?=
 =?us-ascii?Q?0hA2VAIAB0Xy31KqClC5szLj1pRWRHTuyfPnnm5OhzdnBerTW2tM3DbrPo8v?=
 =?us-ascii?Q?pScynuOIGBmKsGuunfy8Piv9lIOw7UPokJ4yt+Jb+u/4YNzvbJ3OBijtwQsz?=
 =?us-ascii?Q?CybHUp0oeOf9qamEaxVze/iiiOCBjzCRHHH6hj284Kw4OeLj1uJ0GOI+LYuC?=
 =?us-ascii?Q?jMiBCFAg9CTc9UrKYXVSZnvFByJk0iej5TKcP2BwuG+GinmFB3JctSZbwtGM?=
 =?us-ascii?Q?256E43GxKSKB02o0bF+BGRJI6A+3bgJQA+nWLIUIswP4+gHkfgbf5Q0fquwK?=
 =?us-ascii?Q?9ngxOY3482ZMT9KvbvxOD1NQpSGs2BDoGMPfv1t6sIFHfCAbmAoL071oX91s?=
 =?us-ascii?Q?+Q8hHRS6VFBTwdS9pPWtLBsC/p+OZ1iWN7SNvruRnD8sfQQjZ8bRrP0p4O7p?=
 =?us-ascii?Q?Qyurtes6iWBwkrTE7mZXpiAAftOKFzvYdVhXkZfr4oTl6aaClKHKSpr/ZKb4?=
 =?us-ascii?Q?MSeyahVJgoTNcAg42IkNYGaZgwOc7di6FXfMG0g2lOXkkaJt5/aMioQjN4TK?=
 =?us-ascii?Q?yNHtZQ2nFeN8l1Drbe2RgZdSdLg9+RmnIMd2/XG09XH016Fhq4A5A2cRNHqw?=
 =?us-ascii?Q?68McBongCpMIntd3eKT4ZP4ZveBLsLSdFilHZxu4YWk0oMFJeY1hvlUi7HgL?=
 =?us-ascii?Q?2xjknPUpyFu/KY6D7QtNVoyxgdSDLI+LSHir/X14TtTr2PrrLLyDB/D4dJod?=
 =?us-ascii?Q?giG6q3nLiJYTikfPJGmLllVZwDCiBXMSGr6OeDNFzW176232jfPmwle9dsy3?=
 =?us-ascii?Q?7JDMZARlFXUJVM1c9n4Kp5D2nDpcTRYDqrB+YCWT9SLejArQz8DqhPaQeX9P?=
 =?us-ascii?Q?mWSpSK/lUd18umLenVq6ESunWOVe6uecQfyBLhYakh2o5MokCfgwYyEOesoP?=
 =?us-ascii?Q?2hvIH5BIxmGBtXLyrlj+B2DHVQoED5Ob0lfKflRxAt3D0y+PjAHT7Fn+bkEh?=
 =?us-ascii?Q?GBiBhMsMCyReth2lrDuwrTTt9fx5AlXZunmggpRj?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2115bdff-b392-455e-9608-08db740df5fb
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2023 17:19:11.5835
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ROS7BLDI4iBjcIZykae1mu4efxI1A1BBl08+gSoIMsBvtVQN8V+q3Dj9O7iZbVBQB7xLIffn96iYT7S+GzVIxQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4916
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Jiasheng Jiang wrote:
> On Wed, Jun 21, 2023 at 00:04:36 +0800, Ira Weiny wrote:
> > Ira Weiny wrote:
> >> Jiasheng Jiang wrote:

[snip]

> >> 
> >> Nice catch!
> >> 
> >> However, this free needs to happen in of_pmem_region_remove() as well.
> > 
> > Looks like the mail from my phone had html in it.  Sorry for that.
> > 
> > This would be better with devm_kstrdup() and then we don't have to worry
> > about the kfree at all.
> 
> Looks good.
> I have submitted a new patch "libnvdimm/of_pmem: Replace kstrdup with devm_kstrdup and add check".
> Since the titie has been modified, I did not submitted a v2.

Ah ok...  But looks like we will need a v3.  See the other email.

Thanks again for trying to fix this,
Ira