Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 23 Jun 2023 10:17:38 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>, <ira.weiny@intel.com>,
        <dan.j.williams@intel.com>, <vishal.l.verma@intel.com>,
        <dave.jiang@intel.com>, <oohall@gmail.com>,
        <aneesh.kumar@linux.ibm.com>
CC:     <nvdimm@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
        Jiasheng Jiang <jiasheng@iscas.ac.cn>
Subject: Re: [PATCH] libnvdimm/of_pmem: Replace kstrdup with devm_kstrdup and
 add check
Message-ID: <6495d3b226de0_4ccfa294f0@iweiny-mobl.notmuch>
References: <20230622143232.16863-1-jiasheng@iscas.ac.cn>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230622143232.16863-1-jiasheng@iscas.ac.cn>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?J0uiube4jq8vs8ebvD4l70KzpKH88f1mtEvvKqYTffkNZN81msXzTdsqMHBj?=
 =?us-ascii?Q?5ZwS9Ovih3IYk4mCgayQOQjGzf7kYWNdf0yjfD6Zv6H9iIAcooNYgAPcbNbk?=
 =?us-ascii?Q?R31vzYJPtLquKhVFdjB/0hCg5IZ6em5nV21IfbkaC3KaMPEqqcGhMzCUyL2X?=
 =?us-ascii?Q?o1Kc/ZjDOc7G6QDOAFlqMgyRwb/CYsAYirNz59KtqgqGMeNW0rANt+idHadR?=
 =?us-ascii?Q?bXLthuwTeiDmxtFY1trpmj+SgKOS12Wu3Qso42ebg1IXJjsQRHtEXGd7oQNm?=
 =?us-ascii?Q?ETssN8B/buNT71sSRZuOouBXD9NAWEaKwj2KcY3NuCBtO5nhKPnWMGx4XxBZ?=
 =?us-ascii?Q?actsza//5+bpUETVr/hQy9gZTP1slynvLiOqdAXSbEG2yfbV4VVBbJgcLSz0?=
 =?us-ascii?Q?7z7HBFO63XLyFX2jtnM5I97+eros8kb64WpKTqrO327gBP7IxaHoJ/2x+Nob?=
 =?us-ascii?Q?dOnWUq7qM3eImqVpAyADO07N3x4UZZtkbGmWzRDxfqom1basIMW+GHwUvzop?=
 =?us-ascii?Q?1wZzZ3KpDMZBXQFYV2AwnESLkeuSxXeSevebZySYSCaEGcklRFSWEHlMhDFw?=
 =?us-ascii?Q?UbekA8knn2biSyY6xpiA3W0KVXoWYV/OJ/sQfJVB/zRaxI42CEdq/OuFsY5K?=
 =?us-ascii?Q?VF3y7HnvHRlT7MldMsjeP3srj4ep5HmDV8H4D3XwHADpJgjdDkmvsyKa/mj3?=
 =?us-ascii?Q?CHtVy4u/khqzdiJLXYUm0w+1WgCoSZM/R/c1HcmRQ6Vsw36P4PsWkjdwG/2q?=
 =?us-ascii?Q?eBDdBMTNWQ7+yjUttrNKw9A27Bf55oSLyUF/YCBNg1yqMphf0h6v0N/ooUTq?=
 =?us-ascii?Q?x24Sb7/XGgCjG38V99M5RZmJJvUhIvstoSwW0DlVxuUEPqCcqH+HKfFFnW4J?=
 =?us-ascii?Q?fFF9WKYao79FsVDkwk0cxAiLNVtbFFFPyF95GjEQRqPmV6wM5+ecx4YxOKKd?=
 =?us-ascii?Q?vUvz6Ja4cBQ6s3DIEBAb5SZMJGJIFKSOVxdHhEDzbLdhPRH5uN1PXfCwQT/1?=
 =?us-ascii?Q?1HU4d1kB7wPxk2vUD9QCa3Ws3TXre00PSnrNvHfQMkHUnGwZ2RcPjcDbwKc/?=
 =?us-ascii?Q?S4xTbSKL/rMYIOlABUS5CuChywwNGOlFZSDbtY4DL2y/XZ8lW99TI6O5qKwz?=
 =?us-ascii?Q?rBedFhLKt/oHnPpmv66KOt2jxt5tvwhY5kvhKZy/vljOfItfquK8DOq2dgnh?=
 =?us-ascii?Q?CPA6qr/hPEhT+rgEHFfYWsHVbfYBZZpdJAE+LWi8ZCIKboRJaBK/fQzkY1jv?=
 =?us-ascii?Q?TOM+RYQAZ9lzw2lQg1MdaOzyAK6OeYccoLX6n6Jmb38G13czGbaFx+7grz2P?=
 =?us-ascii?Q?jcRbvW2eIuJbG5E7KNrljDaCWd0OUSYcJLbF6boMbjxIF0G3gihUM3/X7w9p?=
 =?us-ascii?Q?CajzroKfU6hGDe6neTf6AdCUB7EGwBPH7XOVy/Bt/que16Z6YpDoKzUGRkgk?=
 =?us-ascii?Q?PPpbwZEOUAvTs5CZVA5dBKPQYpphbfFze9KM82LAiDMxLycn4IamTpLEM4Xv?=
 =?us-ascii?Q?khx9kGjxtaQ15dZByWRIU+iRplH+uPM4kmF5FpFCICY2i2zytFheBf0y5yZZ?=
 =?us-ascii?Q?Ot3gQzyatNPqpMAhwhoM7alziqTla7dhMhhOoukp?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 82f6401b-bcbc-415b-99c4-08db740dc1ca
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2023 17:17:44.1071
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fIa/5JFFaHTuCdI7R2UYCwpzjl3Pq5gLTzu2gWupRrVe06Foz7IjjNaEAl1s+qOtV7o2idOXzkvu5LBxIBvKDQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6999
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Jiasheng Jiang wrote:
> Replace kstrdup() with devm_kstrdup() to avoid memory leak and
> add check for the return value of the devm_kstrdup() to avoid
> NULL pointer dereference
> 
> Fixes: 49bddc73d15c ("libnvdimm/of_pmem: Provide a unique name for bus provider")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>

V2?  references to the first fix and review?

> ---
>  drivers/nvdimm/of_pmem.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/nvdimm/of_pmem.c b/drivers/nvdimm/of_pmem.c
> index 10dbdcdfb9ce..5106dfe0147b 100644
> --- a/drivers/nvdimm/of_pmem.c
> +++ b/drivers/nvdimm/of_pmem.c
> @@ -30,7 +30,12 @@ static int of_pmem_region_probe(struct platform_device *pdev)
>  	if (!priv)
>  		return -ENOMEM;
>  
> -	priv->bus_desc.provider_name = kstrdup(pdev->name, GFP_KERNEL);
> +	priv->bus_desc.provider_name = devm_kstrdup(pdev->name, GFP_KERNEL);

Again, thanks for finding and trying to fix this but you did not even compile
test this.  :-(

/**     
 * devm_kstrdup - Allocate resource managed space and
 *                copy an existing string into that.
 * @dev: Device to allocate memory for
 * @s: the string to duplicate
 * @gfp: the GFP mask used in the devm_kmalloc() call when
 *       allocating memory
 * RETURNS:
 * Pointer to allocated string on success, NULL on failure.
 */     
char *devm_kstrdup(struct device *dev, const char *s, gfp_t gfp)
                   ^^^^^^^^^^^^^^^^^^
                   ??????????????????

Ira

> +	if (!priv->bus_desc.provider_name) {
> +		kfree(priv);
> +		return -ENOMEM;
> +	}
> +
>  	priv->bus_desc.module = THIS_MODULE;
>  	priv->bus_desc.of_node = np;
>  
> -- 
> 2.25.1
>