Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 23 Jun 2023 19:44:18 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     souradeep chakrabarti <schakrabarti@linux.microsoft.com>
Cc:     kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
        decui@microsoft.com, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, longli@microsoft.com,
        sharmaajay@microsoft.com, leon@kernel.org, cai.huoqing@linux.dev,
        ssengar@linux.microsoft.com, vkuznets@redhat.com,
        tglx@linutronix.de, linux-hyperv@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-rdma@vger.kernel.org, stable@vger.kernel.org,
        schakrabarti@microsoft.com
Subject: Re: [PATCH V2 net] net: mana: Fix MANA VF unload when host is
 unresponsive
Message-ID: <ZJXZ8mg5uw8MaKuP@corigine.com>
References: <1687505355-29212-1-git-send-email-schakrabarti@linux.microsoft.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1687505355-29212-1-git-send-email-schakrabarti@linux.microsoft.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lumf5ZQc+KzZ4W7cZXTIGACiV/EPRTiJFdnYVTTtEAyuLXnUoD7ziaZX7fva?=
 =?us-ascii?Q?GO/TLzcINvCWjBwp7RKfQ9ZoXICfR/ZjHGjR1xbMxnG9v+g9vx696JU+2WCh?=
 =?us-ascii?Q?P+u/LKY//VCwnUEykLsOFMHv2ZiPJcA3pFSTrCFlq/bhsje9BsNXsoxE7Uta?=
 =?us-ascii?Q?dDBeF1Wt7ADR956Cxdzd1srkaGPkO/c81nGmYkn9te114OK3PlXnjK9AcMuc?=
 =?us-ascii?Q?NCIalFwwKvy1GL43mF6C/nrqutg94JFWmyjxSARPgDq3TSbrvfZqep8PG3vY?=
 =?us-ascii?Q?13tA6zX/TJ9E+T9WnnTiWxpgwn9Pu0tO/rLl4XMILKHYffB7m24t6q2JnOgt?=
 =?us-ascii?Q?/+fSXcCY44PsDuKE2L6d6MG7yL5lg211YX5IrdV0/UkBx+zXR249jVRzK40z?=
 =?us-ascii?Q?Pbzwlf8Yr8jAYr9Pg/9dp+QbDbeo5QCYebRJQN2hwigaGgnGzwyyiPKpKhQq?=
 =?us-ascii?Q?x4SgrMmWqDLkORZYZV1ySv4k4V1XcaXRnlj2blHNP6ouTrKRVGnY5pwpougb?=
 =?us-ascii?Q?6M5YBS0BOxUlJa2e+Z0/tbpbeG87W6LHRXolp4tt9v0nIFrtDyRcYFJRuVwQ?=
 =?us-ascii?Q?/GMZgz9vwTpO5q2Rg2RmQD35oHi+kEz/ntgugcDb9hkUVQNnKE8T1g/IsNM5?=
 =?us-ascii?Q?8mxlOMPOebPCjgMSkXckFRW5gfgIfnkLDDStOBPuIcTVE39LyLW1IiLPxHOa?=
 =?us-ascii?Q?HyH67qjdHGR6aZFEDWiqKO4ZAaw+vjaLp1kbO1VMKx/wqgjPpKFKb1xkOS4e?=
 =?us-ascii?Q?lXQQ4DQnLbM8Tt6B4HZYlw6pHi+ywvrUOS/VYmKclm8faG3+irktLXNFbX4J?=
 =?us-ascii?Q?fSQ9bbXkEbNefJldtKOROD173ssH7oAH0XZWtbObVjp76lg8d8aJZIvw6Ua3?=
 =?us-ascii?Q?z6qFmOA+3Asgax3gWmG8W/bgTxDXHHBLv1iy+VOsxf4CbgQfXEBZ0d25Ww/N?=
 =?us-ascii?Q?uXTJWizjjOJTZxr83nvYDqAH1BtLYW/4cmoq29lUYwmE/5t6P9kkDsUW3t+w?=
 =?us-ascii?Q?lDjoI+umn6U2dgIwRH5Ys1xnziJ1O5AtFN1Br7N8nUf+ZLKTGqoMCFAYtkHd?=
 =?us-ascii?Q?jTeTIiioy6QudHBNkqcUvWjf9ThXGM0EK4eUnzeRHkyX3zZnp4dkDslTlati?=
 =?us-ascii?Q?GoUWtZYk/ur8LBaeTIt8wQe6F+bxehOFNVSp6NI8Kjvv607xKlFMPTqtZCSL?=
 =?us-ascii?Q?X2Oc+TLE5yEEmwPq+e0KQbxlGGxw8dbJMvDW+bZHwvMd193+T5Ft1TDVe0gP?=
 =?us-ascii?Q?ZGHLBJ8sh12uWAEPWMc8zBBZcueVOowyqiKEMuCwdTJNupI+i5P5iVG8j/t2?=
 =?us-ascii?Q?u2APvuOpJiQOkeBgjbKH7zx7inXoLHFin3w3oku5c5+2XnWGfflj4V6NddEt?=
 =?us-ascii?Q?dqUgyCrEBPQ4XbHndjH14zNiD2fc/Gt0CFY77iPnic9OmOoZhbsH6J9rXxUn?=
 =?us-ascii?Q?02L6uY77/mwxoZ2goekDwaxf4jQ9ul2wuUoHc8+CrSVXQoHswm8IurOljIwm?=
 =?us-ascii?Q?n7EmNddVYeLooixGHRGs1FaQOf0br5gFnveIBGa0N09wYVu+Y4up2NDhnbgd?=
 =?us-ascii?Q?Pr5GR8piE9QmRAKSccnw5QOyOV8vCA5zyB6QfXifZIEuGR23LOhaEdY/lpmF?=
 =?us-ascii?Q?81i6jzUl92nHTdV7PVUotBDVpZo1o5W7MDKpClM0yULMp4IM85nbWI5l6epF?=
 =?us-ascii?Q?VLQ0SQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3fc1bacd-5dbd-42e0-5744-08db74117cc8
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2023 17:44:26.1875
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fGH84QP8Q1Ha4XezUYHmAfKXxouYIc4kCGe4ONg2RInGgeTEgQrll+vFKzvBNu3UIiycJ08Oqu1rEjv8vaTToOiWzT77/zrdCJeYFFFi9BE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR13MB5013
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 23, 2023 at 12:29:15AM -0700, souradeep chakrabarti wrote:
> From: Souradeep Chakrabarti <schakrabarti@linux.microsoft.com>
> 
> This patch addresses  the VF unload issue, where mana_dealloc_queues()
> gets stuck in infinite while loop, because of host unresponsiveness.
> It adds a timeout in the while loop, to fix it.
> 
> Also this patch adds a new attribute in mana_context, which gets set when
> mana_hwc_send_request() hits a timeout because of host unresponsiveness.
> This flag then helps to avoid the timeouts in successive calls.
> 
> Signed-off-by: Souradeep Chakrabarti <schakrabarti@linux.microsoft.com>

...

> diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c
> index d907727c7b7a..cb2080b3a00c 100644
> --- a/drivers/net/ethernet/microsoft/mana/mana_en.c
> +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c

...

> @@ -2348,13 +2351,26 @@ static int mana_dealloc_queues(struct net_device *ndev)
>  	 *
>  	 * Drain all the in-flight TX packets
>  	 */
> +
> +	timeout = jiffies + 120 * HZ;
>  	for (i = 0; i < apc->num_queues; i++) {
>  		txq = &apc->tx_qp[i].txq;
> -
> -		while (atomic_read(&txq->pending_sends) > 0)
> +		while (atomic_read(&txq->pending_sends) > 0 &&
> +		       time_before(jiffies, timeout)) {
>  			usleep_range(1000, 2000);
> +		}

Hi Souradeep,

minor feedback from my side, as it seems there will be a new version anyway:
I think the braces - '{' '}' - are unnecessary above.

...

-- 
pw-bot: cr