Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 23 Jun 2023 12:07:29 -0700
From:   Jaegeuk Kim <jaegeuk@kernel.org>
To:     Chao Yu <chao@kernel.org>
Cc:     =?utf-8?B?5L2V5LqR6JW+KFl1bmxlaSBoZSk=?= <heyunlei@oppo.com>,
        linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org
Subject: Re: [f2fs-dev][PATCH] f2fs: not allowed to set file both cold and hot
Message-ID: <ZJXtcfoR+BFx5CXn@google.com>
References: <20230613085250.3648491-1-heyunlei@oppo.com>
 <b8523d41-246b-b11e-f6e3-423e32cc597a@kernel.org>
 <6c527e97-c4a6-dc58-13fb-516f77e5e068@oppo.com>
 <f7a44e66-6fde-a178-d29e-7684bcbc454e@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <f7a44e66-6fde-a178-d29e-7684bcbc454e@kernel.org>
Precedence: bulk

On 06/20, Chao Yu wrote:
> On 2023/6/20 10:42, 何云蕾(Yunlei he) wrote:
> > 
> > On 2023/6/20 8:33, Chao Yu wrote:
> > > On 2023/6/13 16:52, Yunlei He wrote:
> > > > File set both cold and hot advise bit is confusion, so
> > > > return EINVAL to avoid this case.
> > > > 
> > > > Signed-off-by: Yunlei He <heyunlei@oppo.com>
> > > > ---
> > > >   fs/f2fs/xattr.c | 3 +++
> > > >   1 file changed, 3 insertions(+)
> > > > 
> > > > diff --git a/fs/f2fs/xattr.c b/fs/f2fs/xattr.c
> > > > index 213805d3592c..917f3ac9f1a1 100644
> > > > --- a/fs/f2fs/xattr.c
> > > > +++ b/fs/f2fs/xattr.c
> > > > @@ -127,6 +127,9 @@ static int f2fs_xattr_advise_set(const struct xattr_handler *handler,
> > > >                  return -EINVAL;
> > > > 
> > > >          new_advise = new_advise & FADVISE_MODIFIABLE_BITS;
> > > > +       if ((new_advise & FADVISE_COLD_BIT) && (new_advise & FADVISE_HOT_BIT))
> > > > +               return -EINVAL;

Why not this to allow setting one bit only?

@@ -123,7 +123,8 @@ static int f2fs_xattr_advise_set(const struct xattr_handler *handler,
                return -EINVAL;

        new_advise = *(char *)value;
-       if (new_advise & ~FADVISE_MODIFIABLE_BITS)
+       if (new_advise & ~FADVISE_MODIFIABLE_BITS ||
+           new_advise == FADVISE_MODIFIABLE_BITS)
                return -EINVAL;

> > > 
> > > Yunlei,
> > > 
> > > What about the below case:
> > > 
> > > 1. f2fs_xattr_advise_set(FADVISE_COLD_BIT)
> > > 2. f2fs_xattr_advise_set(FADVISE_HOT_BIT)
> > 
> > Hi,  Chao,
> > 
> >      I test this case work well with this patch,  case below will return -EINVAL:
> > 
> >      f2fs_xattr_advise_set(FADVISE_COLD_BIT | FADVISE_HOT_BIT)
> 
> Correct, I missed to check below statement.
> 
> new_advise |= old_advise & ~FADVISE_MODIFIABLE_BITS;
> 
> Anyway, the patch looks good to me.
> 
> Reviewed-by: Chao Yu <chao@kernel.org>
> 
> Thanks,