Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp12953900rwd; Fri, 23 Jun 2023 13:14:41 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5VD+MN4VlzCQc0K8sgjXsPmPvLZBHXhnN7HL+vSK8mJ8VUXHgay+aq1QshkNnkJdjKGVU7 X-Received: by 2002:a17:90b:a0d:b0:25e:86a7:1ff with SMTP id gg13-20020a17090b0a0d00b0025e86a701ffmr15506770pjb.2.1687551280660; Fri, 23 Jun 2023 13:14:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687551280; cv=none; d=google.com; s=arc-20160816; b=GXCnw+Ow5Gvdn4pQcJYcN/pItH8pmiZoX1n7pV/Gwqfk0aIhXCa+RkcNsZLuO7fWp2 mX1njsCr05KxGhsstDZDtoqjxsw3rFt/BEfc7mwXtgcs9GUcB2RVH3YQBKPE6+Z4/KST adv2hRaRRrBgdUdZVQCuQLze5s6ZBC0iqwR/hnaH4ThJveeuPgAOKzn9qPSaO4qD5hsx PZKxCT+o7Qvxs+8vHCODeOak7rgCDnmF2ZSDddMwEt0ipAuVrLCHOGVYb8pGUL79SnEO sSXzSBlHtt3gfmFtWjF3/Ars895ttMNnnIQ/vDkkeHFQdh9UNARaJo8ePRtdVfVTojPV uA2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=S7cXFIATv0cqvFDOdx2Vy9pFsZWT3roW5tnB/9pxEhg=; fh=VJnv8BFHbjv7kXec3ye/J/F+N/j/DiIntKvWnROy/fM=; b=XIo3mzTd+1lhunz5J6anbyYMCl6ToBiMZkp7DdsOleG6C3954zbd0BTasyQKp3c0S3 fKtEAqyqVDJqPmlbg1FbsHpaD45MA5AZGzA+xR+ySVTyH2X5MfhifwffPo7WnIz5fWX5 wAhQGc0qryX2AN8gS3vpXXcaoJ1mKnmf5qf5DapJlOr7woOM8MqCg7A5qCPFxOFSVlIL tCegld5bLM0UPvET4K3mT9OCr8aR0OLTy2rLiDrUXq15/PiAAoNMKkhKEQVohIsBDflk ju+FI9Xg6fKmXME+/DEVwyTVDbfwvRLvkGM6O1OizjFTaFDEK1lC/FOCGC9+FXCScHtv no2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Wjazmg5l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id na12-20020a17090b4c0c00b00259bbd55d4asi3014867pjb.8.2023.06.23.13.14.27; Fri, 23 Jun 2023 13:14:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Wjazmg5l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230501AbjFWTqp (ORCPT + 99 others); Fri, 23 Jun 2023 15:46:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbjFWTqo (ORCPT ); Fri, 23 Jun 2023 15:46:44 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70B512703 for ; Fri, 23 Jun 2023 12:46:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687549563; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S7cXFIATv0cqvFDOdx2Vy9pFsZWT3roW5tnB/9pxEhg=; b=Wjazmg5leTmj2/ZlNL3VaKBNYcXqyIBmbvlYwjgIbVVDQ0Fpb1tVpqOYwL/BiBcxMG4Dxp mZ0/ETN/n0UlSuG9KJfgZ7DZhgz2lYW13zhwBeFjMqGC9hjx8NanXT0M24+Actg0XLiXoX RsgE67wo/hko3oRYV2EHmOobKkDMclw= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-422-tWsHGO7zMPmi0H68AQg1cg-1; Fri, 23 Jun 2023 15:46:01 -0400 X-MC-Unique: tWsHGO7zMPmi0H68AQg1cg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 17FBE29AB435; Fri, 23 Jun 2023 19:45:59 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 91DA92166B25; Fri, 23 Jun 2023 19:45:56 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <27fd3750-7b9c-9638-26d8-0df3f0e33b81@oracle.com> References: <27fd3750-7b9c-9638-26d8-0df3f0e33b81@oracle.com> <20230623114425.2150536-1-dhowells@redhat.com> <20230623114425.2150536-12-dhowells@redhat.com> To: Mike Christie Cc: dhowells@redhat.com, netdev@vger.kernel.org, Alexander Duyck , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Lee Duncan , Chris Leech , Maurizio Lombardi , "James E.J. Bottomley" , "Martin K. Petersen" , Al Viro , open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, Dimitri KRAVTCHUK Subject: Re: [PATCH net-next v4 11/15] iscsi: Use sendmsg(MSG_SPLICE_PAGES) rather than sendpage MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2611149.1687549556.1@warthog.procyon.org.uk> Date: Fri, 23 Jun 2023 20:45:56 +0100 Message-ID: <2611150.1687549556@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mike Christie wrote: > > One question on the target part I had is about the TODO above. Is that > something you were going to do, or is it something you are asking the target > people to do? I've got an in-progress patch for that, but it's not the simplest code to modify. I'm holding off on completing it till the simpler cleanup is in. I might end up having to push the incomplete patch your way to ask for advice on how to complete it. David