Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 23 Jun 2023 22:14:12 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     =?utf-8?B?TcOlbnMgUnVsbGfDpXJk?= <mans@mansr.com>
Cc:     Tony Lindgren <tony@atomide.com>,
        Jeroen Hofstee <jhofstee@victronenergy.com>,
        netdev@vger.kernel.org, Mugunthan V N <mugunthanvnm@ti.com>,
        Grygorii Strashko <grygorii.strashko@ti.com>,
        "open list:TI ETHERNET SWITCH DRIVER (CPSW)" 
        <linux-omap@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] net: cpsw: fix obtaining mac address for am3517
Message-ID: <ZJX9FBBvOTv10IO4@corigine.com>
References: <1477668756-2651-1-git-send-email-jhofstee@victronenergy.com>
 <20161028155213.2t3nwwe3lqaynaer@atomide.com>
 <d8ad5cab-5183-cddf-fa9a-4e7b9b8c9377@victronenergy.com>
 <20161028181914.mskebckucukzhxhz@atomide.com>
 <yw1x7cru445g.fsf@mansr.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <yw1x7cru445g.fsf@mansr.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WjBZQmhXS1Y3REtLS25QQ3NxbitxSkl6U3lZTUU5WnYrQVFtQ3d2dDBKV2Nj?=
 =?utf-8?B?QW5iUVRDenI3TUVLUFo5ZmJNMlpxYUJiaXFqYXM5eXRSVHZkOXc3ZVJrYUgy?=
 =?utf-8?B?bXBkeGRHWDlkN2RKRk82NTRubkhKdFFJOHdaQW1MTmx4a3dKMVZVdzRFOFNS?=
 =?utf-8?B?bjJXRXlKTVoyRVZiTHV6T2dNdTh4cG5sY1pWSkJpL25rZjNOWHhhTE9QSEJR?=
 =?utf-8?B?a2hXWWk0REVidTYreEhwcHNlSDJOZTFleVJ3Y29aTEYyUFg5dTA1MXBQOVBv?=
 =?utf-8?B?MFhSTk1BQ09BdHg0aDRyQjBBaXhsQi95MlJuaUVaL1VPM0NBSHJlekpnbUFu?=
 =?utf-8?B?czI3YmV3S1poL2NrZXhDbjBiM3VnTE5TZ0pzNGJQSnN1Uk4rWnFpa3FraFhv?=
 =?utf-8?B?YThIU29WRitJejAvTWJjNWcrcEk2N203VEVNSEpYVmlTdjU4b215dWNVdzVR?=
 =?utf-8?B?MWlWbEZRb1lpeXBPQ3VRbXN4aWpDTlJVa3FVdy9sVUQvdkdIUG5vRkpVY0tq?=
 =?utf-8?B?alFaR1htcjBhVkp2UGFQSEgwbnhxeEFpK1pJSGNZbHRwTlB6M211aytiY3ov?=
 =?utf-8?B?MmFUK1NMaHdSQUJQU0daSHR6OVY1OHp4OEprZEM3cTZYQzVIWmYrSlAvL0ky?=
 =?utf-8?B?RTAwalJCNUlPUkg2bTlGYk1iTzFjcEZ4dXhGakZwbkVKN3Y4UGc4ZDBSMWMz?=
 =?utf-8?B?MWNRWXJOM2RFKzJLTFNLQ0lSN29xMDdYZE5icnpCNVcvZXFVTzNrZzlzSllZ?=
 =?utf-8?B?eTl2YktMaDh0N2l6UnRKMWhNQ0VwTVlMOW4wYjRQYVd6ZUVZdHoxSGRid2Rr?=
 =?utf-8?B?c3prSmlTUG1aOERpQ2x0SktsaHRaVjJlaGFFWUt3cTZIaVY0OHRMRUMzanlE?=
 =?utf-8?B?SnIyNysrMU9aZGloeVMwKy9SNHFoNGlXZVZ2ZUZoNVkxTmxsSEgzSFBtTWlG?=
 =?utf-8?B?TTRtdGFoNEJPOEE0NTZvNGEvbTRmRk01NjFMWE5vRmNiMHZHb3Y4dTJUbWpy?=
 =?utf-8?B?b1NZUnMrQjhMaHJ6SkMwNEM4SjJLYjZKbU9BcUd3Vyt5bjJidWZWYnlydml2?=
 =?utf-8?B?R2ZLU3cxMWFzRWdkR3pLVXgxZW5kUUNvVENwZXNON1FnSUlKVitnbDMzdWxx?=
 =?utf-8?B?VVl4bmZhVW9YeDhBQlk4eW1KcE9oZU5lZmR4bU5yRWlPUjJRK0JYR2tiSXJi?=
 =?utf-8?B?enpyWHNrSzQxb3QyV1hldno5Nis5WFo2NGFYWWVHU0pyN2RKSUZHQXFwaTEw?=
 =?utf-8?B?NlJyTGQxUlBRZkhrS1N6bHFuYXk1amNMWDBjL0crNlhOS3lGNmJELzhyeVRK?=
 =?utf-8?B?d2ZWUHAxL3pheHZEQzFLL0xKU09nQk4yR2FPTXpFQzZrMk9XWUp6U3VFaVRS?=
 =?utf-8?B?Mm9taTA1MUttRDV3OThPRWJ3b2lpU1ZYTEJuYzJ4WHBSdVRacFlJd1BZcXlq?=
 =?utf-8?B?TzNlZ2ZZTFVkVVplTEgvbUpRTkdFQlFXUTRVd0I5Y251cW45dnpHVlhKNW1q?=
 =?utf-8?B?bTh5Rm5rUGJtOUhmQ3ErYi9OTmxoTkdldk1mUW95TkhzRDF3T2hoZTI4ajBI?=
 =?utf-8?B?eFJNc0VDZEdIcEJYWU5pLzZZNjQ5WGlDVCtJMTJwaHhYZjZiTmZkanpYam1R?=
 =?utf-8?B?WW9wZXFxM1cxa0M5a0k0MjU0b0JIUW5VOFYzTFgyVU1PQ3N3aWsvUkVnRlhX?=
 =?utf-8?B?bVJsRmI2R1lPZzJRYWZmS0RRNDdwVWhxWjVWNzVFSXZWeURCSFdlMUdLMmo0?=
 =?utf-8?B?ZzFBUE1sZDcwYkdWckdyRWMwQUNJZ0xsbVQrQTQwamZqOFVNdWhaRU1KcFVh?=
 =?utf-8?B?SFB1Y3ZZRllDeTBaYkNaKzU3SkwzR0JTWWxpOHBmcVdRNndSQlBxOVA3ajJo?=
 =?utf-8?B?UU1VUkhnbGRjY1JkenpKbFlXcERxM1djQUdQbzZkR1FmOVlOa0RSS2JJeW1k?=
 =?utf-8?B?YUJ6Z2NzNktveGdxeC8vQ0pNaHVMWlJQWjg2WXRiYjhVamJCdDNDaXZ0TER4?=
 =?utf-8?B?WUpkTmsvUnJEQm5FK1pIdURBV3ltSGgzR0Q0MGFKUUhWZFNiZE1JaUtUU1J2?=
 =?utf-8?B?ZngyMHNrU2ltRjV6MERqU1pVKzkzUmVzOGplczVzYURtRzlabi8wS3FJMGo5?=
 =?utf-8?B?ck9yV1pxUjRLVkFpYzFZaVF1RlpmREEzUW1xVU1OT0JoeG9seU0yeTBKdGpK?=
 =?utf-8?B?Y1hpT3krMHZMVC83UVQvdzFFRnZkTVI2dzRDOW01V2lpOGZDbllPUTNLWXhl?=
 =?utf-8?B?NmludSsxSlZZOWtnRWRlaXZUdjFBPT0=?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b825153-bd1e-42b6-bc98-08db74266ca6
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2023 20:14:18.5930
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1PYXjbicyM3yAENlC3NPj18QoG6BQfNdpfy/gILI+7jA6syrCdpEqFY+eANyi8WxDVkiOKsNTsJwHXVu40O0KhNaqeS6rw+tMKBH6bhv80E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB5315
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 23, 2023 at 03:58:03PM +0100, Måns Rullgård wrote:
> Tony Lindgren <tony@atomide.com> writes:
> 
> > * Jeroen Hofstee <jhofstee@victronenergy.com> [161028 11:19]:
> >> Hello Tony,
> >> 
> >> On 28-10-16 17:52, Tony Lindgren wrote:
> >> > * Jeroen Hofstee <jhofstee@victronenergy.com> [161028 08:33]:
> >> > > Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac
> >> > > id to common file") did not only move the code for an am3517, it also
> >> > > added the slave parameter, resulting in an invalid (all zero) mac address
> >> > > being returned for an am3517, since it only has a single emac and the slave
> >> > > parameter is pointing to the second. So simply always read the first and
> >> > > valid mac-address for a ti,am3517-emac.
> >> > And others davinci_emac.c users can have more than one. So is the
> >> > reason the slave parameter points to the second instance because
> >> > of the location in the hardware?
> >> 
> >> Sort of, the slave parameter gets determined by the fact if there is one
> >> or two register range(s) associated with the davinci_emac. In davinci_emac.c
> >> 
> >>     res_ctrl = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> >>     ...
> >>     rc = davinci_emac_try_get_mac(pdev, res_ctrl ? 0 : 1,
> >>                           priv->mac_addr);
> >> 
> >> So it there are two ranges, the slave param becomes 0. It there is only one,
> >> it
> >> will be 1. Since the am3517 only has a single regs entry it ends up with
> >> slave 1,
> >> while there is only a single davinci_emac.
> >
> > OK thanks for clarifying it:
> >
> > Acked-by: Tony Lindgren <tony@atomide.com>
> 
> Is there some reason this patch was never picked up, or was it simply
> forgotten?

I feel like I am missing something here.

The patch possibly dates back to 2016 - but I can't tell because
lore.kernel.org doesn't know either.

https://lore.kernel.org/netdev/20161028155213.2t3nwwe3lqaynaer@atomide.com/

And I see you asked almost the same question in 2019.

If it is still relevant, perhaps it would be good to repost it
for review.