Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 23 Jun 2023 22:55:08 +0200
From:   Nicolas Schier <nicolas@fjasle.eu>
To:     Josh Triplett <josh@joshtriplett.org>
Cc:     linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Ben Hutchings <ben@decadent.org.uk>,
        linux-snps-arc@lists.infradead.org,
        Masahiro Yamada <masahiroy@kernel.org>
Subject: Re: [PATCH] kbuild: builddeb: always make modules_install, to
 install modules.builtin*
Message-ID: <ZJYGrC+3l50kcNkl@fjasle.eu>
References: <20230615111743.883891-1-masahiroy@kernel.org>
 <f7e9220aad3d98bd174f7dcbd68031e1e15ea968.1687461492.git.josh@joshtriplett.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="eTEBsKav2BLy7Olg"
Content-Disposition: inline
In-Reply-To: <f7e9220aad3d98bd174f7dcbd68031e1e15ea968.1687461492.git.josh@joshtriplett.org>
UI-OutboundReport: notjunk:1;M01:P0:Wo85uib8gV4=;bMFL52HzeQnR0BtrNo8OniHR1h5
 Xi/7hIGw8znmM1qv7FnUH4CauBtaohBXwcGX3mrY4xQoU+4zeYZAFMl2snrBv7sYqLmMwdIgn
 z659cZtIs6w6x0WlmNWf3B5OgFBh/wfeAm2Ld0jIW+e/twNtxv0yj7ldHrtDYRGZzM7JFVI+H
 tNMZPk8T/mtGVfy1a1K1Jaql1Hwd8jgG8twPuwZK1wgAp/3ZCPNJXcs2X6iaJwiYWBc+tcfFD
 J3BK4MzqXsMKnFUIkI/bIYVtKxsZyMXsDKFzk1xBmA+y6b/A4/UcCNBF8ImU3LtTX1BJQu1uy
 GtdHwStCTWSnFM1MCedt88BYMrQYeukg/hXsW48xK2/sZlJaOkBuu0uo8wcsGICYl0VxfUcFX
 yzlrfeGHBHDGK8mJ9ThA2DYkLwbLXXdHNMgroYYNs/WDdcXXcygUdkYXOWakFIRCfbIJvIDre
 7NpQhFTTx+2wbL0PZhfgxRToivjvs1L4Fyabe71MSGeukMpk92ywuoZsjpqm1hEPzv/kwUjCB
 /TqA8tYb1d71a2X4nu2HqfxXVO/GN6z0VWJNpA0CUew4hGHCZqi7Cj926IrTHtdzfHdu+dFk5
 yrs7A811f9cFMsgE2AhfgSZycIwm0apEr5PwaTUaQcwXfx3leos6bhqwsZ+EqZC9ZALRv9sYN
 vtvs+ZfXAId3rGYSqFjyVxqj9ctuIRmgHLKnOh2ROg==
Precedence: bulk


--eTEBsKav2BLy7Olg
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jun 22, 2023 at 12:19:53PM -0700 Josh Triplett wrote:
> Even for a non-modular kernel, the kernel builds modules.builtin and
> modules.builtin.modinfo, with information about the built-in modules.
> Tools such as initramfs-tools need these files to build a working
> initramfs on some systems, such as those requiring firmware.
>=20
> Now that `make modules_install` works even in non-modular kernels and
> installs these files, unconditionally invoke it when building a Debian
> package.
>=20
> Signed-off-by: Josh Triplett <josh@joshtriplett.org>
> ---

thanks!

Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>


> This patch depends on
> https://lore.kernel.org/lkml/20230615111743.883891-1-masahiroy@kernel.org/
>=20
>  scripts/package/builddeb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/scripts/package/builddeb b/scripts/package/builddeb
> index 252faaa5561c..f500e3910158 100755
> --- a/scripts/package/builddeb
> +++ b/scripts/package/builddeb
> @@ -62,8 +62,8 @@ install_linux_image () {
>  		${MAKE} -f ${srctree}/Makefile INSTALL_DTBS_PATH=3D"${pdir}/usr/lib/li=
nux-image-${KERNELRELEASE}" dtbs_install
>  	fi
> =20
> +	${MAKE} -f ${srctree}/Makefile INSTALL_MOD_PATH=3D"${pdir}" modules_ins=
tall
>  	if is_enabled CONFIG_MODULES; then
> -		${MAKE} -f ${srctree}/Makefile INSTALL_MOD_PATH=3D"${pdir}" modules_in=
stall
>  		rm -f "${pdir}/lib/modules/${KERNELRELEASE}/build"
>  		rm -f "${pdir}/lib/modules/${KERNELRELEASE}/source"
>  		if [ "${SRCARCH}" =3D um ] ; then
> --=20
> 2.40.1

--=20
epost|xmpp: nicolas@fjasle.eu          irc://oftc.net/nsc
=E2=86=B3 gpg: 18ed 52db e34f 860e e9fb  c82b 7d97 0932 55a0 ce7f
     -- frykten for herren er opphav til kunnskap --

--eTEBsKav2BLy7Olg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEh0E3p4c3JKeBvsLGB1IKcBYmEmkFAmSWBqwACgkQB1IKcBYm
EmnWfRAAtP85RutI/lZit0ETIZsCYS4olhIri+eUsdAAXiMeRmh4QcDhuyEWgppK
2J0oI1XOQY45GRmID28iGIPjhIG3/bd+TWnIC4tDc3/z+DWpmWIc8O3ICuqs5luJ
MiWgPH6QVvGSl3WE+i48X8kP8AxizXeBP+SSxQuQsEMqfi8fCPm/l2wMReOTaKJ6
3VMeDqvC8IPdTSOgyO4TrdShwsTRBsMUDzkZ8kYk9ElbgdO6DX8Pz4YENn473aaQ
JgYlqgHkXDmUAcud+CA49Lsp+GDIV+SQPmcZTCuSKEvWkPBjOMM1/YoErUKeaTht
DehzO3DqlWN+6yTzHUIE94DTQ/rBJ9qqir9psg/jE6Ud22QlOFc7Wp3FP47qNTkm
lohdvXWQfRvkOAn9zb0IehTwHtW2zJ3I4+B1gN0kFrUyWA8xqHpzBIC17iJhHyJe
XeTwnGAO51su8fqpESiISeGGt+3VTSpJJt39lGlAgsRFf8H1ETUF3vyTncM+vZos
8/mgs7mCgN6kaiJYiTaMNgEctFUG6gG9t0SFJP5spGrz3pvaJwBv2DofQzahFSLk
E5GAtaBuHf1pMVeR8BzwkCfFN7ajF/3xbm3fZbIbnLYFfJ5Sfw29VkUrPI8zyseg
ne8e7LwfsP369WZYp64JMtEFnZfxkwxSaJa6csH4EYHUl1sBtuY=
=xiGO
-----END PGP SIGNATURE-----

--eTEBsKav2BLy7Olg--