Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp13015530rwd; Fri, 23 Jun 2023 14:19:57 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5EWhhoLBp28y2Jx6A1obUN+R+Xl+dB5xH8gcKDbscKrqZfEOxzbk8UlAldhV8dIWoqtYli X-Received: by 2002:a05:6a20:918b:b0:11f:ec:2240 with SMTP id v11-20020a056a20918b00b0011f00ec2240mr29698427pzd.18.1687555197163; Fri, 23 Jun 2023 14:19:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687555197; cv=none; d=google.com; s=arc-20160816; b=IzFICqPezceDhXBDgj2LizSr918fiVIeBJFBOWh5sFzOM4db3TsAe0Rj9BOnGqKlB/ w4tc6fgfwnCTCG/ohYu7JNdUqp1eLchNwzWtVA4wET2h1Y0o3dUdeCZfI8edad7gy9PE H3ORjeVFkDQH078b7TrKfTzRcWDUKyjBFS9XxlmU9t+rSfdqdJrUwMg/fSeoaX6aywhp knC8q8V38VSp/ZTEK0oVC4r9HpIhEB/sjc4jqpYTM8RiKX5v1595aq2g0guwuQeioyZq I4bIrs14NLK4Qm+aVNMG2IsLBX4RVQralTZQv1NgIrMn5PDE2WSNNQ/CdySoScgJU7Ue IKSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=W1WB9Wb0BvRRcBkbSVITYF4i4Xscr+EN0kvgwOJ6wOs=; fh=Rdk+OWmudmdPt+m21oN6e9kPfmvlv0u9RO9HC7/sCwc=; b=ssZvChMAHClyDoQ/bbl/8eRhUhGhE0kdQy2gV/pKq2ytimGjaANVfP9wb/o4k3UP4/ wOBKj2FOlkg3Nzo9V+iiSpu5g+73zmpzXzIgk4nwKcDsewoCwmpMfNcf1yMAKE3+ZcFm Q+eSHLXYbNEUg1hfYaH35dSQAGYu8A/qBledyVGiVysR3413lX2XWS+1HZSLkYkRm5XA x3ak28SXV7iLTrl7ac7vBZ0yAHM0HbNsm2/q3Gqbs6JfYPobHBq3EWD43vk50eLxVh3l dSz/GxXsc2g9C2KFUThau0Q9kIGMXyxJa4Xhis6K9bbEjOG0O5XL4Kv2UNhllNqyy0/w kF5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@inria.fr header.s=dc header.b="WmG/JpBr"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=inria.fr Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w67-20020a636246000000b0055386e1eb92si243292pgb.422.2023.06.23.14.19.43; Fri, 23 Jun 2023 14:19:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@inria.fr header.s=dc header.b="WmG/JpBr"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=inria.fr Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232894AbjFWVQl (ORCPT + 99 others); Fri, 23 Jun 2023 17:16:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232895AbjFWVQA (ORCPT ); Fri, 23 Jun 2023 17:16:00 -0400 Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED00B295E; Fri, 23 Jun 2023 14:15:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=W1WB9Wb0BvRRcBkbSVITYF4i4Xscr+EN0kvgwOJ6wOs=; b=WmG/JpBrM0La8Q7SPsscDO+9vwp6o00kURhYuE4MeUme0ls/EvAKTJhY mp+BcN1WhFW8+h7eRAujDv59DBrIbAx6oxgu581730TSsqjI0R/hG8vwc R2wBhiJozXLBTfyUjGNSc07qmFKw/jr6X7BSNFOgHP2+n6nDAix+z1p0U Q=; Authentication-Results: mail3-relais-sop.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=Julia.Lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="6.01,153,1684792800"; d="scan'208";a="59686181" Received: from i80.paris.inria.fr (HELO i80.paris.inria.fr.) ([128.93.90.48]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2023 23:15:14 +0200 From: Julia Lawall To: Sakari Ailus Cc: keescook@chromium.org, kernel-janitors@vger.kernel.org, Bingbu Cao , Tianshu Qiu , Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 23/26] media: staging: imgu: use array_size Date: Fri, 23 Jun 2023 23:14:54 +0200 Message-Id: <20230623211457.102544-24-Julia.Lawall@inria.fr> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20230623211457.102544-1-Julia.Lawall@inria.fr> References: <20230623211457.102544-1-Julia.Lawall@inria.fr> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use array_size to protect against multiplication overflows. The changes were done using the following Coccinelle semantic patch: // @@ expression E1, E2; constant C1, C2; identifier alloc = {vmalloc,vzalloc}; @@ ( alloc(C1 * C2,...) | alloc( - (E1) * (E2) + array_size(E1, E2) ,...) ) // Signed-off-by: Julia Lawall --- drivers/staging/media/ipu3/ipu3-mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/ipu3/ipu3-mmu.c b/drivers/staging/media/ipu3/ipu3-mmu.c index cb9bf5fb29a5..9c4adb815c94 100644 --- a/drivers/staging/media/ipu3/ipu3-mmu.c +++ b/drivers/staging/media/ipu3/ipu3-mmu.c @@ -464,7 +464,7 @@ struct imgu_mmu_info *imgu_mmu_init(struct device *parent, void __iomem *base) * Allocate the array of L2PT CPU pointers, initialized to zero, * which means the dummy L2PT allocated above. */ - mmu->l2pts = vzalloc(IPU3_PT_PTES * sizeof(*mmu->l2pts)); + mmu->l2pts = vzalloc(array_size(IPU3_PT_PTES, sizeof(*mmu->l2pts))); if (!mmu->l2pts) goto fail_l2pt;