Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <56200b7e7f5a8852869814ff1f9f0fa7.pc@manguebit.com>
From:   Paulo Alcantara <pc@manguebit.com>
To:     Rishabh Bhatnagar <risbhat@amazon.com>, gregkh@linuxfoundation.org
Cc:     stable@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-cifs@vger.kernel.org, Rishabh Bhatnagar <risbhat@amazon.com>
Subject: Re: [PATCH 5.4 0/5] CIFS DFS fixes for 5.4
In-Reply-To: <20230623213406.5596-1-risbhat@amazon.com>
References: <20230623213406.5596-1-risbhat@amazon.com>
Date:   Fri, 23 Jun 2023 19:08:22 -0300
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Rishabh Bhatnagar <risbhat@amazon.com> writes:

> We are seeing deadlock in cifs code while updating volume in
> cifs_reconnect. There are few fixes available in stable trees
> already. This series backports some patches back to 5.4 stable.
>
>  __schedule+0x268/0x6e0
>  schedule+0x2f/0xa0
>  schedule_preempt_disabled+0xa/0x10
>  __mutex_lock.isra.7+0x20b/0x470
>  ? dfs_cache_update_vol+0x45/0x2a0 [cifs]
>  dfs_cache_update_vol+0x45/0x2a0 [cifs]
>  cifs_reconnect+0x6f2/0xef0 [cifs]
>  cifs_handle_standard+0x18d/0x1b0 [cifs]
>  cifs_demultiplex_thread+0xa5c/0xc90 [cifs]
>  ? cifs_handle_standard+0x1b0/0x1b0 [cifs]
>
> Paulo Alcantara (SUSE) (5):
>   cifs: Clean up DFS referral cache
>   cifs: Get rid of kstrdup_const()'d paths
>   cifs: Introduce helpers for finding TCP connection
>   cifs: Merge is_path_valid() into get_normalized_path()
>   cifs: Fix potential deadlock when updating vol in cifs_reconnect()
>
>  fs/cifs/dfs_cache.c | 701 +++++++++++++++++++++++---------------------
>  1 file changed, 372 insertions(+), 329 deletions(-)

Looks good, thanks.