Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5f99d057-66f1-8a6c-9107-490af0eff3f2@intel.com>
Date:   Fri, 23 Jun 2023 15:19:29 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Betterbird/102.11.1
Subject: Re: [PATCH v7 27/27] cxl/core/regs: Rename phys_addr in
 cxl_map_component_regs()
To:     Terry Bowman <terry.bowman@amd.com>, <alison.schofield@intel.com>,
        <vishal.l.verma@intel.com>, <ira.weiny@intel.com>,
        <bwidawsk@kernel.org>, <dan.j.williams@intel.com>,
        <Jonathan.Cameron@huawei.com>, <linux-cxl@vger.kernel.org>
CC:     <rrichter@amd.com>, <linux-kernel@vger.kernel.org>,
        <bhelgaas@google.com>
References: <20230622205523.85375-1-terry.bowman@amd.com>
 <20230622205523.85375-28-terry.bowman@amd.com>
Content-Language: en-US
From:   Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20230622205523.85375-28-terry.bowman@amd.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VFIvWEhBOFBzbDhQZCt3RzEyTXM5WU9tY1o0YkliRTVJTzZMeGNuV2dpdEpH?=
 =?utf-8?B?RE9hcVAwSlliMk1rTW9JUms0RFFwRFJpQ0tNUlNucFpWMy9MWEVCUlBDUFMr?=
 =?utf-8?B?MndHT0laY2FWS3RiallDMHpuT0R1SFlpbnN2V01NOFJWc3FLRmQ5L1gvckZC?=
 =?utf-8?B?MFphZkJqYUxTekFTdW1XUnhDNmlOdllhZHlSWHpIbTU3SnZXWnMzOFh1UzVV?=
 =?utf-8?B?L2x6aFl2cHNzTlpIb3d5K0p4NGRWQXc3d1VLZFlxRXJaTDlWdHBqdkpMOHlq?=
 =?utf-8?B?YUhsV2dTSWhTdk9iTHVCd2lUYzcweTQ3NEREanJ5V1NrZnMrQTI0dHhRVUlJ?=
 =?utf-8?B?ZXozVlJkOGRZcU1zWEpMbU94WG1VenZHS0ZUVXNadlNmSkxtanNTVEZtSU4r?=
 =?utf-8?B?QVFQSFZTT0JOTzVSVUhhSW9rYi8vWDNqYytBL3FORnVQZitUY3pYQWg5cFpY?=
 =?utf-8?B?NE1KRWp0TkV6anVsMW1tTlpnOFFJTFRPMmd3SzdaRGJ1NnVrczZ0SmtsNms4?=
 =?utf-8?B?c2dnZFovS1IvVkFzTzBTb0ZXcTRmUWFmL2l1L2J2Q1FRZktQWlUrYzdXRlpk?=
 =?utf-8?B?bzdJeDBEZUN2UU9TVHlyQ3FvakN5aE1mbkxwb2pkV0hhcG1VOHNRc0RBRVhW?=
 =?utf-8?B?eE9wR3kzdktvd3dOQ1g3MjVTeHhkc3p6UCtkbCtFa0RJbllQZGw0RWp2Z1kz?=
 =?utf-8?B?T2ppdG50cktVa0JOUzQ3ak5QRFB6VVptZFE5UFFDRFVOTHRsblRWeU1aSkpM?=
 =?utf-8?B?UHBDbFZuVGpRK2czeUoyRXU1RnJ0akJHUXVTYXdjZFl6ZldvWS9lbHJrUlFi?=
 =?utf-8?B?WVZ4RzEybVRpdmRxeUJZWll6MEVDOWNPNDNtOGEvRGxINGViR3VZU0hGbXky?=
 =?utf-8?B?c1FmVThyMlJsRUVtdzJmTnVnOGltVnA5emN4UFNDSUNWZ2dUWm55bndoN1Zl?=
 =?utf-8?B?Rm5UVW9XU3FaUlpRQ3l1QkwycnZ3bVJrRS92cHRKU2szMU9yaWVKTFFDN1R5?=
 =?utf-8?B?ZW5wTUltSVZRMjVSbGJ6b0ltM2NKSHorNmQ0eldZcENyQlpWZ3BhOW5mcjVH?=
 =?utf-8?B?T3p5TUJwdXZEN2cyMEdGRTEyNHJkeEU1UU5NM1d4YWNTVEd6TkhXbWtYYXRu?=
 =?utf-8?B?aFRJd2dWTHMzeDRjazIybmhiN3dJMElDUVF3elA2MWYvWnhETVlrRzZJWDRp?=
 =?utf-8?B?RGVmS3UzSlRDYnJnOUVWcWMxbXl1alZWeHFrdDMycU5TOHRFbFVNQWxuQnZT?=
 =?utf-8?B?dEdqUEo3ZExBR2xRWnM3UXc2T2t0dE9NTlZmTDI0a1dMRGtZQ2U5WG1vQkJ6?=
 =?utf-8?B?OXJGcHhUV1NXZm9EL2t1cWlreUtMU3lQRks0QXcvWTJGcTFmcWV2WUtmOVdw?=
 =?utf-8?B?YTFDVE5LSERBN0IwRmllK0hjSHo4NW1GblBmK3l2QlFSUWx0SEVCeEl2Tk5S?=
 =?utf-8?B?bmhXeWx3alFyaU8zZGVxU2hYOVpuYU5iaHk2b3FCS2xPMzArQ3dPMzErcWcr?=
 =?utf-8?B?TGs4RUFtbXg3MkJlWTdHdDEvOEhTbG0wMnY2SGwrb2JVdnpBQ0lHSG5mb09q?=
 =?utf-8?B?ek53VWJHSFEwYm1lK1MxVy84V3kwV0ZMUWVzK3Jya1JYWnltZWtKb29hNzNi?=
 =?utf-8?B?MmFmMmtrN08zL0RqWHUyZHRVdVJESjRTWjIxQXpOa1ZEUVlYWDd4RTR5U2RU?=
 =?utf-8?B?UmtPclN0UW5Fc2hFdVdLMVhNcGU3bzFucW9Gb2hYYU8wbEkyWDJqeHhmU0lu?=
 =?utf-8?B?akhPakJlRXFiNXFCRzIvOHhZN3N0M1FvVXlGWnl3Y3YxWU96TkliOW43My9R?=
 =?utf-8?B?N0tUK1VGZXFJdUdmOWhHV29HTGNKUXFOMjR1S2xjRjRYeDd2YXl6NExxWXlv?=
 =?utf-8?B?cEIzVTRTS1lQRFdtUEpMVXJGWXl2dGNGNWhISEhBSU5lT1EyYTZ5SjFrRHEr?=
 =?utf-8?B?aGJVT0p0bVZVKzhtakxteDJwMFhySUEzWmhFTjdZQ0tIVjJralFEeXNLMy9u?=
 =?utf-8?B?NTA5TTdwVlVNVnVLRVlxeldrOFBIZFMyVTVTaHpINllTTWRvcWdubXJWTWV0?=
 =?utf-8?B?MHEyd05pWWMxRVB4K1Y4Y2JhN2tNMWx3NlRWaFB3blozTG8vK1VOdUM0ZzVw?=
 =?utf-8?Q?hrhMXvJ6j0n2hDX9bf0CYBTpL?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 83ae630f-2a33-45bf-d225-08db7437ebbc
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2023 22:19:33.1993
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d77EAg+sYFLNOHibjBx5G2/fG4r4307CzHZy8KhR80geR4+tvMlJZyiVA9A5gA+nEyorWWu1cd+Tbd+AFlr0iA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5430
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/22/23 13:55, Terry Bowman wrote:
> From: Robert Richter <rrichter@amd.com>
> 
> Trivial change that renames variable phys_addr in
> cxl_map_component_regs() to shorten its length to keep the 80 char
> size limit for the line and also for consistency between the different
> paths.
> 
> Signed-off-by: Robert Richter <rrichter@amd.com>
> Signed-off-by: Terry Bowman <terry.bowman@amd.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>

> ---
>   drivers/cxl/core/regs.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/cxl/core/regs.c b/drivers/cxl/core/regs.c
> index 982ef79670c7..ba351a887040 100644
> --- a/drivers/cxl/core/regs.c
> +++ b/drivers/cxl/core/regs.c
> @@ -216,16 +216,16 @@ int cxl_map_component_regs(struct cxl_register_map *map,
>   
>   	for (i = 0; i < ARRAY_SIZE(mapinfo); i++) {
>   		struct mapinfo *mi = &mapinfo[i];
> -		resource_size_t phys_addr;
> +		resource_size_t addr;
>   		resource_size_t length;
>   
>   		if (!mi->rmap->valid)
>   			continue;
>   		if (!test_bit(mi->rmap->id, &map_mask))
>   			continue;
> -		phys_addr = map->resource + mi->rmap->offset;
> +		addr = map->resource + mi->rmap->offset;
>   		length = mi->rmap->size;
> -		*(mi->addr) = devm_cxl_iomap_block(dev, phys_addr, length);
> +		*(mi->addr) = devm_cxl_iomap_block(dev, addr, length);
>   		if (!*(mi->addr))
>   			return -ENOMEM;
>   	}