Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 23 Jun 2023 15:31:20 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     "Huang, Kai" <kai.huang@intel.com>,
        "Williams, Dan J" <dan.j.williams@intel.com>,
        "Aktas, Erdem" <erdemaktas@google.com>
CC:     "corbet@lwn.net" <corbet@lwn.net>, "Du, Fan" <fan.du@intel.com>,
        "shuah@kernel.org" <shuah@kernel.org>,
        "Luck, Tony" <tony.luck@intel.com>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "brijesh.singh@amd.com" <brijesh.singh@amd.com>,
        "dionnaglaze@google.com" <dionnaglaze@google.com>,
        "qinkun@apache.org" <qinkun@apache.org>,
        "kirill.shutemov@linux.intel.com" <kirill.shutemov@linux.intel.com>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "wander@redhat.com" <wander@redhat.com>,
        "atishp@rivosinc.com" <atishp@rivosinc.com>,
        "hpa@zytor.com" <hpa@zytor.com>,
        "chongc@google.com" <chongc@google.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "sathyanarayanan.kuppuswamy@linux.intel.com" 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        "dhowells@redhat.com" <dhowells@redhat.com>,
        "Yu, Guorui" <guorui.yu@linux.alibaba.com>,
        "x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH v3 3/3] selftests/tdx: Test GetQuote TDX attestation
 feature
Message-ID: <64961d37eafda_142af829411@dwillia2-xfh.jf.intel.com.notmuch>
References: <cover.1684048511.git.sathyanarayanan.kuppuswamy@linux.intel.com>
 <972e1d5c5ec53e2757fb17a586558c5385e987dd.1684048511.git.sathyanarayanan.kuppuswamy@linux.intel.com>
 <64876bf6c30e2_1433ac29415@dwillia2-xfh.jf.intel.com.notmuch>
 <CAAYXXYzOUQC0G7yoh1i2+SW-FodCABwhD6TgArLf28iG=i65zw@mail.gmail.com>
 <b99d329e5a28a06dfb947270b8a9032cc6960f83.camel@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <b99d329e5a28a06dfb947270b8a9032cc6960f83.camel@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DXfiimDtE7SbobnzhaCarJMYTNRe8x2VT218r937I2RjDzgCU2J0WPwzNIom?=
 =?us-ascii?Q?AqPTAt0lZCEJZBM50SRSVfWErKjno/KUllUYG8mIs47K4SOvjye57Q4n7Y+1?=
 =?us-ascii?Q?qtpPM7GijbQ4GTUsBCk1DxJYjlkzHI8ne5+UIFDmL7rpulBBgk3I0D16YHWx?=
 =?us-ascii?Q?pzj0rDgMZioXXt3P9DnsB2+1EFeCYlZSHm8/Og+qKn0Z72xOFEO/AAbqU6I/?=
 =?us-ascii?Q?W4Q2ez8E71VMih4RC4aa83x0gmQzc/i+Y51FNcLWbBLV3UORg6kqpMa1/ab5?=
 =?us-ascii?Q?Ll82RsLSyCRUwV4BSlhrTUtTfBIf5y6ImOMqksMPP+wcIc5Tqy3lczJdhIN0?=
 =?us-ascii?Q?R3n/cdyp0ouVMTJb85uIg+rj9W6BJr59LB4JWdD50rgmYuaQ+hMzbbqCVnO6?=
 =?us-ascii?Q?BBTIPEvADB8LeVMICO32xiMMdfyHpvOuPo/Bmetb7MZE6+yHrFWlAt1R8lWB?=
 =?us-ascii?Q?kTQ3RzQjRtViTZN5KFY0Tj30DE/A2uGP9Euww1oEU/XafsnYOeqCx2jNpnOS?=
 =?us-ascii?Q?IOZcRYWiHSpey/DikHouBh/Ccxy5AaSBG0EBpRBBZuhEpoD4MgzWirwmwLdG?=
 =?us-ascii?Q?XRGOwF/Ksz/lMLni7nYP+hp8PJe+YsQNB5/5soPcSsSp03TbY7TCl3KWkxmy?=
 =?us-ascii?Q?KlfAdUtpvY6pDsH398jAIIXlavYBFlqKZz5vGJSlFmfMspGH+Hp4bXktLRMO?=
 =?us-ascii?Q?rMrNyhOvebutxRiKgUqjZDLaO1fzg8TDWoc06NnF5FIH6k7Z8vAW5ld+a+ZX?=
 =?us-ascii?Q?LFIENu3j6rpWM3ri2vUJmduDkQAGD1PID9CxmpxSMeAdST+Xcf+IIfEJijQT?=
 =?us-ascii?Q?2INR1xiAMU76DuEJoXvdtzvAMee+YBX1pTTWrKlfMqWv1v7LtW4LQUVwHOEl?=
 =?us-ascii?Q?o/qgSFJH5N+K4PO29Mo3z0f2zJROoBAZWgY9AwULtUIrC0MQu0CKF54Ae6gC?=
 =?us-ascii?Q?jnK1tZ+2zHhWgF5QEe5KehXr+iUui4pXg0rlHu8U9m8kwS36ErlugbR/ierb?=
 =?us-ascii?Q?I5yTLQFRuAWLLXLGYSp7D1/2C7PjHQ/nvERa3jqq0+Z3JL6Jl77R6vGNdQsV?=
 =?us-ascii?Q?S9Wc290YH+rI/1n0NVLCzqCDOFk8gQJ1iNbjGJDPZR9aR8sSqsz3k6OfiEEU?=
 =?us-ascii?Q?XFOvAbgTvI9KQLj4sGMcYjNwim+xSni21UGV6ajY0ym9NhAzgUQs+8fvFGyA?=
 =?us-ascii?Q?QIjfPY4taEYrXyDoQfEYFUMWDG7VETyWTXz5QZGb6AaKTxw6OS8mdJKGh6Ki?=
 =?us-ascii?Q?I0/uJcOSWarOcc+nxlqd/2ub8ZePEswXaa39Acs8/dEb1VloORSuLRqpliKI?=
 =?us-ascii?Q?NbSeKCiRUw3g7DdKBn9lJyiG7soyKIWqq7oARbirv/cyIyeGlB+TDkkUwPMK?=
 =?us-ascii?Q?2Eno8IcFMQSVf9Nrt0/MbyoRJYxJodgIAi1GSL+mueWZ+DCZ44uKjwI0sVzq?=
 =?us-ascii?Q?UlkN5VZMH+/tVZG9id4lfA+urZyvbCOACVMtsQUYTdfjooJcbyzDrwZKgfEv?=
 =?us-ascii?Q?mJoWHPp1aT+KtaDz0+RhhfzxfdCeRzHOg1rjGaQKsToGUvTYVTdwRI1eSHQQ?=
 =?us-ascii?Q?gPeVNcgkkl1CCQpHVv+Fspu8juGogRCJitAMVVfOiGy980P7pWClEkzoDwgy?=
 =?us-ascii?Q?gw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 931e4dd5-de9e-44ad-6eff-08db7439932f
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2023 22:31:23.5990
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FyJ3ojto1KqD73XpWCanW1XkVIsCNBIPin2xoQw2VpoiM3B+UvEyOhXPZWqqk+hfqDbm+wSInhNYOzUBCFTr8AgCpahXL1WnUCfAbXkmqh4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8052
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Huang, Kai wrote:
> On Thu, 2023-06-22 at 16:31 -0700, Erdem Aktas wrote:
> > So while I like the suggested direction, I am not sure how much it is
> > possible to come up with a common ABI even with just only for 2
> > vendors (AMD and Intel) without doing spec changes which is a multi
> > year effort imho.
> 
> I don't want to intervene the discussion around whether this direction is
> correct or not, however I want to say request_key() may not be the right place
> to fit Quote (or remote verifiable data blob in general for attestation).
> 
> > request_key(coco_quote, "description", "<uuencoded tdreport>")
> 
> Although both key and Quote are data blob in some way, Quote certainly is not a
> key but have much more information.  The man page of request_key() seems to
> suggest it's just for key:
> 
>        request_key - request a key from the kernel's key management
>        facility
> 

Read further in that man page and see the example of generic user
defined value stored as a "key". A "key" is just a blob that has meaning
to access other resources / instantiate other keys.