Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230622065351.1092893-1-anshuman.khandual@arm.com> <20230622065351.1092893-4-anshuman.khandual@arm.com>
In-Reply-To: <20230622065351.1092893-4-anshuman.khandual@arm.com>
From:   Namhyung Kim <namhyung@gmail.com>
Date:   Fri, 23 Jun 2023 16:21:12 -0700
Message-ID: <CAM9d7cgTyowSHTydOUprPMn80POvbtYetrHTA_eU-wL0B_Cr8g@mail.gmail.com>
Subject: Re: [PATCH V13 03/10] arm64/perf: Add branch stack support in struct arm_pmu
To:     Anshuman Khandual <anshuman.khandual@arm.com>
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        will@kernel.org, catalin.marinas@arm.com, mark.rutland@arm.com,
        Mark Brown <broonie@kernel.org>,
        James Clark <james.clark@arm.com>,
        Rob Herring <robh@kernel.org>, Marc Zyngier <maz@kernel.org>,
        Suzuki Poulose <suzuki.poulose@arm.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        linux-perf-users@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hello,

On Wed, Jun 21, 2023 at 11:55=E2=80=AFPM Anshuman Khandual
<anshuman.khandual@arm.com> wrote:
>
> This updates 'struct arm_pmu' for branch stack sampling support being add=
ed
> later. This adds an element 'reg_trbidr' to capture BRBE attribute detail=
s.

reg_brbidr, right?

Thanks,
Namhyung


> These updates here will help in tracking any branch stack sampling suppor=
t.
>
> This also enables perf branch stack sampling event on all 'struct arm pmu=
',
> supporting the feature but after removing the current gate that blocks su=
ch
> events unconditionally in armpmu_event_init(). Instead a quick probe can =
be
> initiated via arm_pmu->has_branch_stack to ascertain the support.
>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Tested-by: James Clark <james.clark@arm.com>
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
>  drivers/perf/arm_pmu.c       | 3 +--
>  include/linux/perf/arm_pmu.h | 9 ++++++++-
>  2 files changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c
> index aada47e3b126..d9ffe9e56e74 100644
> --- a/drivers/perf/arm_pmu.c
> +++ b/drivers/perf/arm_pmu.c
> @@ -510,8 +510,7 @@ static int armpmu_event_init(struct perf_event *event=
)
>                 !cpumask_test_cpu(event->cpu, &armpmu->supported_cpus))
>                 return -ENOENT;
>
> -       /* does not support taken branch sampling */
> -       if (has_branch_stack(event))
> +       if (has_branch_stack(event) && !armpmu->has_branch_stack)
>                 return -EOPNOTSUPP;
>
>         return __hw_perf_event_init(event);
> diff --git a/include/linux/perf/arm_pmu.h b/include/linux/perf/arm_pmu.h
> index f7fbd162ca4c..ba4204bdcebf 100644
> --- a/include/linux/perf/arm_pmu.h
> +++ b/include/linux/perf/arm_pmu.h
> @@ -102,7 +102,9 @@ struct arm_pmu {
>         int             (*map_event)(struct perf_event *event);
>         void            (*sched_task)(struct perf_event_pmu_context *pmu_=
ctx, bool sched_in);
>         int             num_events;
> -       bool            secure_access; /* 32-bit ARM only */
> +       unsigned int    secure_access   : 1, /* 32-bit ARM only */
> +                       has_branch_stack: 1, /* 64-bit ARM only */
> +                       reserved        : 30;
>  #define ARMV8_PMUV3_MAX_COMMON_EVENTS          0x40
>         DECLARE_BITMAP(pmceid_bitmap, ARMV8_PMUV3_MAX_COMMON_EVENTS);
>  #define ARMV8_PMUV3_EXT_COMMON_EVENT_BASE      0x4000
> @@ -118,6 +120,11 @@ struct arm_pmu {
>
>         /* Only to be used by ACPI probing code */
>         unsigned long acpi_cpuid;
> +
> +       /* Implementation specific attributes */
> +#ifdef CONFIG_ARM64_BRBE
> +       u64             reg_brbidr;
> +#endif
>  };
>
>  #define to_arm_pmu(p) (container_of(p, struct arm_pmu, pmu))
> --
> 2.25.1
>