Message-ID: <4718EDFE.40401@garzik.org>
Date: Fri, 19 Oct 2007 13:48:46 -0400
From: Jeff Garzik <jeff@garzik.org>
User-Agent: Thunderbird 2.0.0.5 (X11/20070727)
MIME-Version: 1.0
To: "Eric W. Biederman" <ebiederm@xmission.com>
CC: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/9] irq-remove: core
References: <20071019075443.GA6407@havoc.gtf.org>	<20071019075508.GB6407@havoc.gtf.org> <m1przbggkg.fsf@ebiederm.dsl.xmission.com>
In-Reply-To: <m1przbggkg.fsf@ebiederm.dsl.xmission.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1218
Lines: 38

Eric W. Biederman wrote:
> Jeff Garzik <jeff@garzik.org> writes:
> 
>> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
>> index 80eab7a..92e1456 100644
>> --- a/kernel/irq/manage.c
>> +++ b/kernel/irq/manage.c
>> @@ -455,7 +455,7 @@ void free_irq(unsigned int irq, void *dev_id)
>>  			 */
>>  			if (action->flags & IRQF_SHARED) {
>>  				local_irq_save(flags);
>> -				action->handler(irq, dev_id);
>> +				action->handler(dev_id);
>>  				local_irq_restore(flags);
>>  			}
>>  #endif
>> @@ -549,7 +549,7 @@ int request_irq(unsigned int irq, irq_handler_t handler,
>>  		unsigned long flags;
>>  
>>  		local_irq_save(flags);
>> -		handler(irq, dev_id);
>> +		handler(dev_id);
>>  		local_irq_restore(flags);
>>  	}
>>  #endif
> 
> The above two hunks need to call set_irqfunc_irq in your model.

Duh.  Thanks for pointing out an obvious mistake :)

Fixed and checked into 'irq-remove' branch of
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/