Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932220AbXJSR7E (ORCPT ); Fri, 19 Oct 2007 13:59:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S934989AbXJSR6k (ORCPT ); Fri, 19 Oct 2007 13:58:40 -0400 Received: from cerber.ds.pg.gda.pl ([153.19.208.18]:52737 "EHLO cerber.ds.pg.gda.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932487AbXJSR6i (ORCPT ); Fri, 19 Oct 2007 13:58:38 -0400 Date: Fri, 19 Oct 2007 18:58:30 +0100 (BST) From: "Maciej W. Rozycki" To: Jarek Poplawski cc: Benjamin Herrenschmidt , Andy Fleming , Andrew Morton , Jeff Garzik , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes In-Reply-To: <20071019143921.GB2598@ff.dom.local> Message-ID: References: <20071015125301.GC3015@ff.dom.local> <20071016062108.GB1000@ff.dom.local> <20071017085809.GA1658@ff.dom.local> <20071019143921.GB2598@ff.dom.local> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1463 Lines: 29 On Fri, 19 Oct 2007, Jarek Poplawski wrote: > Actually I'm not convinced with this explanation. It seems to me that > since there are such serious locking problems (especially with rntl), > there could be once more considered a private workqueue. You've > written earlier about being a lonely user of this code. But, since Well, this will change eventually when I submit the patch for Broadcom SiByte platforms so that sb1250-mac.c will be able to request an interrupt for the PHYs. All the infrastructure is in place except from platform code to configure the SOC's GPIO line used for the interrupt input (when applicable) and let the driver know what the line actually is. > Benjamin offered his help with changing to mutexes, which looks like > very reasonable idea to me (probably I miss most of the points...), > maybe it's very good opportunity to both: make this code better and > double the user base! I'm interested in looking for such solution > if Benjamin thinks there could be too few problems for him... So, > let somebody tell us what could be wrong with this idea? I do not object and can certainly cooperate, but cannot make it a high priority work for me at the moment -- sorry. Maciej - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/