Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230624112958.27727-1-jonas.gorski@gmail.com>
In-Reply-To: <20230624112958.27727-1-jonas.gorski@gmail.com>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Sat, 24 Jun 2023 14:20:30 +0200
Message-ID: <CACRpkdbW_V_1RtYy1+KRXTMe5E4g2vDvcR7Y9f2O4C=XLnUaXg@mail.gmail.com>
Subject: Re: [PATCH] bus: ixp4xx: fix IXP4XX_EXP_T1_MASK
To:     Jonas Gorski <jonas.gorski@gmail.com>
Cc:     Imre Kaloz <kaloz@dune.hu>, Krzysztof Halasa <khalasa@piap.pl>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, Jun 24, 2023 at 1:30=E2=80=AFPM Jonas Gorski <jonas.gorski@gmail.co=
m> wrote:

> The IXP4XX_EXP_T1_MASK was shifted one bit to the right, overlapping
> IXP4XX_EXP_T2_MASK and leaving bit 29 unused. The offset being wrong is
> also confirmed at least by the datasheet of IXP45X/46X [1].
>
> Fix this by aligning it to IXP4XX_EXP_T1_SHIFT.
>
> [1] https://www.intel.com/content/dam/www/public/us/en/documents/manuals/=
ixp45x-ixp46x-developers-manual.pdf
>
> Fixes: 1c953bda90ca ("bus: ixp4xx: Add a driver for IXP4xx expansion bus"=
)
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>

Yups that's a bug! (My typo...)

I'll funnel it upstream through the SoC tree.

Yours,
Linus Walleij