Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 24 Jun 2023 14:40:23 +0000
To:     Boqun Feng <boqun.feng@gmail.com>
From:   =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= <bjorn3_gh@protonmail.com>
Cc:     Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        Gary Guo <gary@garyguo.net>,
        Benno Lossin <benno.lossin@proton.me>,
        rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rust: alloc: Add realloc and alloc_zeroed to the GlobalAlloc impl
Message-ID: <R7bIOWHPBelVxutK-V8lFrSCh_diCIJtJxP-HbOJDV0i2VaKriARSwBRv8TaTevuT06lySKkBALLFJ8S_7q2Qzzr2fH4eceYXYO1_kp1jnI=@protonmail.com>
In-Reply-To: <ZJXXxEfzVza5Jzxj@boqun-archlinux>
References: <20230622-global_alloc_methods-v1-1-3d3561593e23@protonmail.com> <ZJXXxEfzVza5Jzxj@boqun-archlinux>
Feedback-ID: 27884398:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Friday, June 23rd, 2023 at 19:35, Boqun Feng <boqun.feng@gmail.com> wrot=
e:

> On Thu, Jun 22, 2023 at 09:24:40PM +0200, Bj=C3=B6rn Roy Baron via B4 Rel=
ay wrote:
>=20
> > From: Bj=C3=B6rn Roy Baron bjorn3_gh@protonmail.com
> >=20
> > While there are default impls for these methods, using the respective C
> > api's is faster. Currently neither the existing nor these new
> > GlobalAlloc method implementations are actually called. Instead the
> > _rust* function defined below the GlobalAlloc impl are used. With
> > rustc 1.71 these functions will be gone and all allocation calls will g=
o
> > through the GlobalAlloc implementation.
> >=20
> > Link: https://github.com/Rust-for-Linux/linux/issues/68
>=20
>=20
> Nice! Although I think we need to do the simialr size adjustment as:
>=20
> =09https://lore.kernel.org/rust-for-linux/20230613164258.3831917-1-boqun.=
feng@gmail.com/
>=20
> so I applied your patch onto my patch and came up with the following:

Right. That patch LGTM.

Cheers,
Bj=C3=B6rn