Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936053AbXJSSRs (ORCPT ); Fri, 19 Oct 2007 14:17:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760502AbXJSSRh (ORCPT ); Fri, 19 Oct 2007 14:17:37 -0400 Received: from www.tglx.de ([62.245.132.106]:42796 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1764869AbXJSSRh (ORCPT ); Fri, 19 Oct 2007 14:17:37 -0400 Date: Fri, 19 Oct 2007 20:17:12 +0200 (CEST) From: Thomas Gleixner To: Andrew Morton cc: Samuel Ortiz , linux-kernel@vger.kernel.org, Paul Sokolovsky , Ben Dooks Subject: Re: [RFC] [PATCH -mm] ASIC3 driver In-Reply-To: <20071019110034.1534bb86.akpm@linux-foundation.org> Message-ID: References: <20071018091239.GA11360@caravaggio> <20071018150544.6852d5c9.akpm@linux-foundation.org> <20071019105258.GA15170@caravaggio> <20071019110034.1534bb86.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1683 Lines: 43 On Fri, 19 Oct 2007, Andrew Morton wrote: > On Fri, 19 Oct 2007 12:53:00 +0200 Samuel Ortiz wrote: > > > On Thu, Oct 18, 2007 at 03:05:44PM -0700, Andrew Morton wrote: > > > On Thu, 18 Oct 2007 11:12:41 +0200 > > > Samuel Ortiz wrote: > > > > > > +#include > > > > +#include > > > > +#include > > > > > > Please see the large comment at the top of linux/irq.h. I believe this > > > driver will fial to compile on at least arm. > > It doesn't build as a module, since we need the irq.h symbols. > > I changed MFD_ASIC3 to bool. I somehow feel that this is not the cleanest > > solution, but OTOH I think that dynamically adding IRQs and GPIOs to an > > embedded board doesn't make much sense. > > We seem to have miscommunicated here. contains references to > things which only some architectures actually implement. I don't know > which architectures those are, but it includes common ones like x86, so > it's a real trap. I recall it does not include arm, so your code might > break on arm. > > At least, that's what's _supposed_ to happen: I just compiled and linked > this driver into an ARM kernel with no problems so now I'm all confused as > to what the problem was. > > Oh well, we'll see... We obviously never removed the big fat warning, which was valid before the ARM to generic irq conversion. tglx - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/