Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 24 Jun 2023 17:46:46 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Julia Lawall <Julia.Lawall@inria.fr>
Cc:     Veerasenareddy Burru <vburru@marvell.com>, keescook@chromium.org,
        kernel-janitors@vger.kernel.org,
        Abhijit Ayarekar <aayarekar@marvell.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/26] octeon_ep: use array_size
Message-ID: <ZJcP5orP0eidH2re@corigine.com>
References: <20230623211457.102544-1-Julia.Lawall@inria.fr>
 <20230623211457.102544-3-Julia.Lawall@inria.fr>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230623211457.102544-3-Julia.Lawall@inria.fr>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZF5Sk+wrKEqrY+1t/FWmJcBK+3lR1WtuhHlFnEPBQxdAQLgiRO12J+psOC1p?=
 =?us-ascii?Q?iVWVskZ3Mc8BBwT0RxGoZlPvq3We/oMEkw4+C3G/TAEMvOIK+uQ+AROf3Q6Z?=
 =?us-ascii?Q?uamxkY/xAEB6qZcxqEML6vOLYlgsX+KYq0i4g2+eO+wwbasv/itJ1GZvPXzy?=
 =?us-ascii?Q?7SlON5AvGVNhoHZ20slyfucTS/OA1DDeYo1GI+gImesuGbdCS//p/ZSJirmf?=
 =?us-ascii?Q?txEc1Aud4rrbcszhLNL9twwI0XC1df9JFackL2iOhcqjGpiUf0G1Wj8Nq9Jv?=
 =?us-ascii?Q?J3U4Dw784jPDREan6R3YRtoZgF/6LMQX/JmusmTF6H8BFtVtG7VimMxPzP6G?=
 =?us-ascii?Q?DpAHiWpKPKKBa2JcrzLWTFK1zGnWqo166akbHWMeDnWzrW5sHDnQ5LVSzW8d?=
 =?us-ascii?Q?d/GaQiojdCazrxmJtFzqIRQeE7HtrbRRoBkjFZGpVBZ9V57AlhlHW7VilO1l?=
 =?us-ascii?Q?oX2DJoQQ0xJQJnMnXst//s7MfBalU0dhT7mg0UvisnnduTgSvgCeBKn1GLdR?=
 =?us-ascii?Q?8MA1jln5iS3UFbA9ggaE3ylG8ZONYTSvkFlgFG4luPbFvHqZDuq5BOrzy4KL?=
 =?us-ascii?Q?mGGm7jWPn1GjJjFor/489Q2gvXpODM2SkQjY6qvQOnR3QGccIbSp9n8VrPjM?=
 =?us-ascii?Q?kLY5fCc9Wozd9Muk/8on8QRkNfV0Wwfua5zk9pXEwTLz3yH/lc9DFxwFCvMz?=
 =?us-ascii?Q?0R6T2a/zq5hq4Kfc4M/hAe3dkmOzVhAys6iNyz1n5KIRcRfuKEV7w4tX3HdD?=
 =?us-ascii?Q?AhQDbRxmdCjrawTkQbh9F8P+mQTI23VOrKHoXT44viY3o5IAX6zMmwzdoNHF?=
 =?us-ascii?Q?QO6IPAl1hEOtHA8q7YwEM20AVcPx5fSdPsSHEH12APRU0Jl/Fb15LlWyquCZ?=
 =?us-ascii?Q?zXrJStEQ3tfa4nmwmowN7OtkWKnlXcQ1G/aNlW9Sr0PjaeLcqvtYY/kFNrbU?=
 =?us-ascii?Q?BRgSLrAEBburlwp9tCWOzPQmop0+O21f1JFEd2YRzhgZv0FWVSpr7IbE4041?=
 =?us-ascii?Q?sXfs79nLHigUSIUvI9GOUkzy5yt/P70sC5JAuYk3hJgnOMeCdq/dX/Sq2K91?=
 =?us-ascii?Q?emaXxuhhF1m5QJMArgFmwvKA3jOgQkMbEc1D9HRGrjCwkMTm+KFFpROxpIx/?=
 =?us-ascii?Q?4yjXxFs9M5XWavu5+P7gRdR7zGApT+efFkwd+SPf2uJyYKSaXMgcrl2tlm9z?=
 =?us-ascii?Q?lsp9bzjOZelvXBGqU8RCP4UCeeLF4LMho+PggmMBmXJcpKkT8UtMvJ5JkGUP?=
 =?us-ascii?Q?cFX4PDvd6+giaA6lhUT9mjoGglj7yfxaExC0bnZVyqZxNb+xgkMKEFhdCYCo?=
 =?us-ascii?Q?XKh2IDVmgxsggMMoWrEcHrpICP/veohnLFbodUlorm5RftnPxIUCqPUHEOAa?=
 =?us-ascii?Q?x3Gp1g8e/jJekntdiYzK6iKm28LdZ5r/soEu40vec0kT+Zlr0FbCcVKTiLnx?=
 =?us-ascii?Q?3AX/lvZ9GgMs9WIcQlMy11G6+f1p0OE9ACb2yxYuz6MKs3Omc1YprQC6PQrD?=
 =?us-ascii?Q?fWQxtjMud1yPGFV1Fw6Qz8J5STLs+9F+PZWpcCzraqXTH5mH9s/oI23fmfdm?=
 =?us-ascii?Q?4k65JADH1uxBB3RQSvQ+tL3rC2XgQ1mW/AzWX/NJDpS4HbhqomC1oS7B+EBx?=
 =?us-ascii?Q?78eI3K2i2XqrDhEdvWbBHnp9uO5O5I8n1hYM51HBa0uu1CoovJSD75mBqBlh?=
 =?us-ascii?Q?fc60WQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c20e0ddd-412a-4002-8c10-08db74ca3b61
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2023 15:46:53.3628
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EAeKAN3Eq8cgkJ6GBHcnpsAUk+9NlrrSD5t2z632RFBL0pfE6VXlZa5FsmobSj34U2znTNLGIW8H9jRZ40HtBsrOzWco4voPXRe1EiR5wtU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB4875
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 23, 2023 at 11:14:33PM +0200, Julia Lawall wrote:
> Use array_size to protect against multiplication overflows.
> 
> The changes were done using the following Coccinelle semantic patch:
> 
> // <smpl>
> @@
>     expression E1, E2;
>     constant C1, C2;
>     identifier alloc = {vmalloc,vzalloc};
> @@
>     
> (
>       alloc(C1 * C2,...)
> |
>       alloc(
> -           (E1) * (E2)
> +           array_size(E1, E2)
>       ,...)
> )
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

Reviewed-by: Simon Horman <simon.horman@corigine.com>