Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 24 Jun 2023 17:47:34 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Julia Lawall <Julia.Lawall@inria.fr>
Cc:     Shannon Nelson <shannon.nelson@amd.com>, keescook@chromium.org,
        kernel-janitors@vger.kernel.org,
        Brett Creeley <brett.creeley@amd.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/26] pds_core: use array_size
Message-ID: <ZJcQFu3csAhp4xW2@corigine.com>
References: <20230623211457.102544-1-Julia.Lawall@inria.fr>
 <20230623211457.102544-10-Julia.Lawall@inria.fr>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230623211457.102544-10-Julia.Lawall@inria.fr>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?V+D7HrrNXNm05PcSpxfRGFjg4pPKJN+t2z3FXwFXHaVNtiBXLE+zKA5Ma3mL?=
 =?us-ascii?Q?f2QZ/g6e6XQJ8G8NtBpokHFNokwfhDODImbg4JoQo2gfT5erIXwAvk9Ezz+Z?=
 =?us-ascii?Q?fXd4/0J/FZPn4NsizTzeyaU9W5xDUKGqdql7hYpfSlmOyuvYnOO/MPcvW8bG?=
 =?us-ascii?Q?Itbcr3vJfRsD+cliVj0mMbqgv3yHYnQw4ldFFDZ8Z5ImP6duW0LkErpm1jw1?=
 =?us-ascii?Q?D63MfIVdLmvsRqW+k+PfdRcfE+YaUxp2N8eggMq4rqUpAcvcLMlw+PvlNzba?=
 =?us-ascii?Q?3jwpkvGnl1UdsCbxGUAVXCaWG5+PPrn6NOQlNIoPY6z4W6/pgI/bgCNwXkAJ?=
 =?us-ascii?Q?Ys3WLCPhX/cwMD8GGCK6VWFv+lCGDIMmGfGoc+Es3GC06DYiRClB65v/LCQ0?=
 =?us-ascii?Q?94QB33DnUs/JZFiWPuhSV6rg4wo72T8C0XcLd3MSOsTGHFKLj5/fXc5oCg0N?=
 =?us-ascii?Q?4vTf3Y/ShzeSom/I6DcSAaTrQOf17xflTUWZ9tkNWpDg/sG+JBYr0BwLe+WL?=
 =?us-ascii?Q?pupw6kWTKUc9QApSGsLlWnmeHAYNzVex3TB12fj0KSrE+ikmfUp2hxOD9UTG?=
 =?us-ascii?Q?Sa0QUHbPJKgDKBmFAfB/D7olt4MVAlCVpTSI80N9k34PtrilEDAjPzVbReYz?=
 =?us-ascii?Q?gSOHwA75YCv/0dpITc3EHeFiSE8ACD+N4a235Cz7tVBRJN+Et9pCERKoNQNf?=
 =?us-ascii?Q?yN8AGi8W0kpRD5+OyO27x8TDe/mwrcp/UGtDi/I/NznROoiwwIbCgtC2rbIv?=
 =?us-ascii?Q?QN/mJUHN92oH1AWR4GtpZx7Ht2gwo2OSLcRe4ehxL2HWrIZ2x+RY3pVzOWUg?=
 =?us-ascii?Q?WN7k996lQXaOVMJRw5dVZI1IOrbzyjjktJe7etBB79b/gCw6dMxtbqslCIMg?=
 =?us-ascii?Q?cVJkbsrZYY15z8HfHUMLuvvoDU8mhZhB2BhMs2FmlVxvkxTz+qveuwklMqnW?=
 =?us-ascii?Q?ppPhUBkscFfrvMYpHmq8Jqm8YCkan1PDYYmFZV+w1VOl7BuaAeFfDfv5pL2R?=
 =?us-ascii?Q?fyRspgNSr+iHOTLvxnQOlr6X2CiwqaGton7hKUrbqGllTiCCket+xglf7aCR?=
 =?us-ascii?Q?XhUEiqfbJzO1xY6Yct6SttyrEOYw+5ajY3+ozO+oI/s6l1oV/0xM+jqEiXiS?=
 =?us-ascii?Q?o8P2kSZfO7iE3JoqPR7M54SsqE7kvhXDDL0No3RieMB4N0MBDdz7BKcp5OCr?=
 =?us-ascii?Q?n11VP883H+nm5F7AZc0O8fnBjtvPJ+G/7+Dlqz+x24dgT29jmlfMq1SncQcK?=
 =?us-ascii?Q?fc+Cx7yIzmtg/y/0O3y/Tty9NglkIEiJLhc3ls6JPV0c/QdWcmuLht3wZP5a?=
 =?us-ascii?Q?B7+mGFN211SIh0g/9MB3H37/lumcVB2cQPg2zeaaXGrC+5co4IVvJNp+2Ic2?=
 =?us-ascii?Q?LT+cC3eWoOlkze9NSXMsEYAmmreGZF8iwbeSLN53pelNwJMLbmN067QecTGD?=
 =?us-ascii?Q?1cmN+uEcw8n6cPlnsccqIoMvZN5NoPZoBjVqdO6Am97VBzS9TBREIkr7veST?=
 =?us-ascii?Q?Lm8XIUZVl4O3e2rPElM7R4X08oiq4ulUhJl+81Fp/lneoTMRvzo0+Z0ghoL5?=
 =?us-ascii?Q?8WEWhpK4+mn55EPeFRX860KIXFz8Ld9aCHOj+3YxixsHwRBjUwgiJvZlfHJP?=
 =?us-ascii?Q?I6SX9bKpceKQ8JhwqUrdmOG+6V1kjDSZ/gw+wI7ynKRq46NTgR+BWk7cwXUd?=
 =?us-ascii?Q?7bqOJA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0df86918-b236-4297-9b50-08db74ca57e4
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2023 15:47:41.1276
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HAIDAJ23X+JIxkg4dcyYUZ6qaRNDaO2N0S31NgVg6VYdzryEZx5ywmVtrCvXibLzDMkE1DV8l6K1ePH2lNggMs5iJcIkryVqeL+ya8Ajuoc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR13MB4895
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 23, 2023 at 11:14:40PM +0200, Julia Lawall wrote:
> Use array_size to protect against multiplication overflows.
> 
> The changes were done using the following Coccinelle semantic patch:
> 
> // <smpl>
> @@
>     expression E1, E2;
>     constant C1, C2;
>     identifier alloc = {vmalloc,vzalloc};
> @@
>     
> (
>       alloc(C1 * C2,...)
> |
>       alloc(
> -           (E1) * (E2)
> +           array_size(E1, E2)
>       ,...)
> )
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

Reviewed-by: Simon Horman <simon.horman@corigine.com>