Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 24 Jun 2023 17:48:17 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Julia Lawall <Julia.Lawall@inria.fr>
Cc:     Claudiu Manoil <claudiu.manoil@nxp.com>, keescook@chromium.org,
        kernel-janitors@vger.kernel.org,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 18/26] net: enetc: use array_size
Message-ID: <ZJcQQU9/9fGJWmwT@corigine.com>
References: <20230623211457.102544-1-Julia.Lawall@inria.fr>
 <20230623211457.102544-19-Julia.Lawall@inria.fr>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230623211457.102544-19-Julia.Lawall@inria.fr>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NV/ft4vVPmPhCgs1ui/gfFjMKWwyM9ahbixEQLEuCMpTV7oCWfbuTi4n5Me4?=
 =?us-ascii?Q?DLGC5J1MGq7nauqKwhURUXLHmrfGl2f/YNcu18yBzQYpOYDMc3makHhjI7iq?=
 =?us-ascii?Q?oAP+f0czYY5KoQEanM1ybz6fJT39DZb5n8NMeiNrsZZCducAlyB6ikY2l9dV?=
 =?us-ascii?Q?i5s+f6c4Y151UfVaQz/N8tTXiV8kaf4/Oikdf8gmRUz0MdKf32hNu07zaPHb?=
 =?us-ascii?Q?j5IRCsy4l0efVM8nT4nMCv6cwCi9Tx3aAj0tw97Gq9OLwImpX2I9DwpULiN6?=
 =?us-ascii?Q?Wb/h4l3fuEnpV6i0j1aei23F7kJPpeRbX0U71rNVv9rYXqo8YCOMTspUe7o/?=
 =?us-ascii?Q?60RqQgEKZy95i0j1PRv+FhGKSSCNl6fscZ3Jg1nNFqZtZQMHPSFpVBkvcV4Z?=
 =?us-ascii?Q?eTHClX/pJQxbiL8YTNY9Rk2FhxJUR3AEBRN4pGicVEhpobw4VbBnnvZNMNeE?=
 =?us-ascii?Q?27Nq7U5NZMxdzES7U3HTfSc6YE5oPSczjnxo9lrEnF1fYGbIxrKuEYxpVY+R?=
 =?us-ascii?Q?yJaYEjAMoUR0n3EtW6x0VnnMM2aVjkRdR+iFb1iUgVttx7PcHbbzGIXyzxdX?=
 =?us-ascii?Q?3qgTwR2AjEfJwo/ZwyZ8Z6gw0/QIkUUFSfPVGHDUg394ckQWRjEVpVzifWsf?=
 =?us-ascii?Q?N+bRlF1+bJH6vZ4EHcNMBOJun0xAGMrW5eq2fX6RVBWblFW0mpraM9RrDfte?=
 =?us-ascii?Q?92n/01VPUccPeX/0VaCl3Z6zPoLM1lOwsCgVe7MmHbvgizURAUcRFMP8JAPx?=
 =?us-ascii?Q?tGP0oAmgBcZzJxLbyk15RiYO9ECpSViSDmBD6FGEjAtmqTtVNT2aQNoB0jK/?=
 =?us-ascii?Q?sfOFPDbDHxmRAxyyopq8mrEUKDdpQFrIM8S1LmDOL6Osjz0ZtZR34e2mFdrI?=
 =?us-ascii?Q?MZLLy5VA14+4Ki74XqLDBvfdMO1xNqnfYoQTjYerpNwXddcYgAbMzJGAcAAf?=
 =?us-ascii?Q?1sj8yqEauwQawwuYZFvLePxDNexoW4Y+afKSH+5/bri29egSt3dewO05iBh4?=
 =?us-ascii?Q?DhJwMBVM/SEzyxx3MI34gSx/slquDTw/Q0sogjiLL1qS17JIXTiDftal/OZL?=
 =?us-ascii?Q?jjaRSU7K4pnBEHepWrqmriGsJOr8XXu0vqpz6cdmdA4sEuO2r9TBB/cb0yhF?=
 =?us-ascii?Q?ZsWI8IU1JWK7kbGN2SDvJR4deAEZyGzH/fz+Y/bi4TpfPqoROvmHbttaphFX?=
 =?us-ascii?Q?cOuzCbbhPv473OOcDIhcOai5Fbvu8oVLihSQoILWM8aLkBa6q6MWWYCWnSPK?=
 =?us-ascii?Q?mw9Pu4obGvnRz7pCAe/390tbfoIQEutGF3/zsut3pWO0Ny59WtjN3yF/Cac1?=
 =?us-ascii?Q?umJWszJWMQMxUbZYxscONdeIkzwZVUM8q3X4IC2vGqXL6uLK4zk1zEfnS+pv?=
 =?us-ascii?Q?3Kv8xT09c09HmVh2tHYscIeXjb3Vdy3L+uUNcEkRDxTqWpZPreSmxLRumLip?=
 =?us-ascii?Q?mLkSBp8htvIeZ6OdN5hA0nDMTHR+sU8YQJXMCtl8ptmk0BLRwx+wrJyO5jzR?=
 =?us-ascii?Q?51W7r+FLSrSkuNR0BSaZbj8ydzR+apDAxtazh17Q09umEr+O3bDqGNOi0Q/0?=
 =?us-ascii?Q?qdAhYFl2sTFWq4tZ46xdy0S9R75zXzs0QYaY7FkmzRKxMuK21rZJvLz0fcvF?=
 =?us-ascii?Q?d3Ln0EKaniEg/BWFa36EY+nO28NwwgXX52nKvewk4O+JB8F00Mp840Va7j5k?=
 =?us-ascii?Q?qhOIiQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 78b65993-30b0-4f97-dd68-08db74ca714d
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2023 15:48:23.7191
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Zuzg93Aldh0az2qv9vZLMTOu7zjEUnEAyqxoA1ztSNogfRq3M5vu9hCzFIvC2YCY1nBnCO9sOdd067kPUKTdatpKes8L6ALQ9brmPK54VLw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR13MB4895
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 23, 2023 at 11:14:49PM +0200, Julia Lawall wrote:
> Use array_size to protect against multiplication overflows.
> 
> The changes were done using the following Coccinelle semantic patch:
> 
> // <smpl>
> @@
>     expression E1, E2;
>     constant C1, C2;
>     identifier alloc = {vmalloc,vzalloc};
> @@
>     
> (
>       alloc(C1 * C2,...)
> |
>       alloc(
> -           (E1) * (E2)
> +           array_size(E1, E2)
>       ,...)
> )
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

Reviewed-by: Simon Horman <simon.horman@corigine.com>