Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 24 Jun 2023 17:47:54 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Julia Lawall <Julia.Lawall@inria.fr>
Cc:     Shannon Nelson <shannon.nelson@amd.com>, keescook@chromium.org,
        kernel-janitors@vger.kernel.org,
        Brett Creeley <brett.creeley@amd.com>, drivers@pensando.io,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/26] ionic: use array_size
Message-ID: <ZJcQKl5Jccz14UCh@corigine.com>
References: <20230623211457.102544-1-Julia.Lawall@inria.fr>
 <20230623211457.102544-12-Julia.Lawall@inria.fr>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230623211457.102544-12-Julia.Lawall@inria.fr>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?h6eeFWgcSxr3Q2YXtxpEor49G3gwSAxkSEcEdbILcR6R5rfvqDLPGZrr+2Bm?=
 =?us-ascii?Q?qn1Xfx+IyimedOeI8NdYeyF3ZBNGKcdn3S0TOyndMWh1PAhJ54D9bbfjoZsE?=
 =?us-ascii?Q?RRdDo8YboT/vYdRRWSNfhU49ROlMQozDtjPgWpy74w4RAqIDrv3Fa7yB+dl2?=
 =?us-ascii?Q?OqoVtDnc05hlEI9bsuey6LEXfbt9kPea8hW0ZmsTSVTe9ZQssYntHDhtOQAy?=
 =?us-ascii?Q?RYHN/VdBeY+MguH0XhoagOTw9pOnb77sXHRQ3SnuIisVqB+p3nPhgBMrkOr+?=
 =?us-ascii?Q?/ZcjyIaCEtTukvLc7XClq/kHBZvj6OeDxjL2dt+AKBZEf+FB6IEOlLGxVPMb?=
 =?us-ascii?Q?utxlRfmwPDr4OgvYG/+Sf/nxOAXsNlLmhWPyF2yiEzbktdMu5dI6EENhSONI?=
 =?us-ascii?Q?VGsBH5llVxjm38Xfxv9akrYWvwyU8phW4zYojELN0CeT57img8K05dK4WzHg?=
 =?us-ascii?Q?2P8NPM7/Zqjy3OlNrVMlmGvo/qnsohVo/nFkOgW+HrsAIiIWHHvwFd3jVmV8?=
 =?us-ascii?Q?5aehGFIl5Pwj+wjMMtrVFXlAX8b18nMGyGdFwQhHrDI3/iv15C7L5s/7T/by?=
 =?us-ascii?Q?RrdG/F0d7WPawDissHblcr/WMXAKjptbf+PdGTEzGe3RP3dGMFT+ZCARUXQd?=
 =?us-ascii?Q?+QKLI5HHuuTXHHodBr8O2TKpo9alyS9Mi7nnL/q4vj8lp4hT0O3ibUZdOPFT?=
 =?us-ascii?Q?6D+M8JCQFUWiDFipbuczPed5AMlCe4phJhERSa5IqvbX2EH3aO+wDrKul6+g?=
 =?us-ascii?Q?jx9/U8AF+8NlS1cDw9qiiEEzWc8+jd1c9NF/3vCpEyZBZXLXyaetlBSXRaRO?=
 =?us-ascii?Q?xCSn9RBgLD5uhJOXkTew6kADhh+k4HLo+hTqq17uodR7dKoO+TjpmI/p2q88?=
 =?us-ascii?Q?44end9Xcr6o/m4+JjbiUstqbyBqJ8WmFzW7MKIv/SnTC9/mVrScf/gHjJ86I?=
 =?us-ascii?Q?o2CZmt+TboFU31s3qc93O8qBbGJZtYvwR70wtYq1WeXa8ttzQr5iW1UhoaOn?=
 =?us-ascii?Q?ugrsa3bhGPan+01cz1BWZOvpoKAHGZ7VrGSTrfAgBxL/v0OPPKm2YnJIbUwv?=
 =?us-ascii?Q?y5fHCdI0Zo4A80oOqif4do1TZUKI1PUkNk5YtL3XaOcpm/pLYKGhWLaOOnPD?=
 =?us-ascii?Q?ZZ7iVcYYh0WXoM/qZ5kO9Xpm8CCZp+sgmkEFnyY6T2GOGr82liZWii+ayrBe?=
 =?us-ascii?Q?8sd3hNoKhmFM1Lm0kf3EdebCbSv2/AHNHii0NKRg5D6BU1qDWuUmSviocEEF?=
 =?us-ascii?Q?6vXNvM8sB2cjdlG4MQMYFWGJvUuk0yXGYvljJPmQ7A0j6VBdLGWge01tZHoC?=
 =?us-ascii?Q?Bm44FvSSeESThzykOU1dmvIKfZfVmoJim+ecKE3bgrmg4Z/eXS8LLkIbRnai?=
 =?us-ascii?Q?P5nGFFpbvW9A/YFySn+/kOOT/OgpA55R1MnrseaA4Iwv6tftC9lWhpg0EuXx?=
 =?us-ascii?Q?qGfP+3Wh3LOG+li3AmjRFqw//WXYm1ExBbtc6s1VROacTRBUobqhwrfYwCZW?=
 =?us-ascii?Q?s5Ezewx6v8K+V3giZrxgoUXub1iY9SoP7rbZGbSphRMLKk1ZdP218haxOtwC?=
 =?us-ascii?Q?bqYq4m1f5NIEzJKrzSwyJyd5CB6kJ9rxr3tShPQnPLnEUg95OnHZzR2hfrrQ?=
 =?us-ascii?Q?cI5GwmABD/uwdqM3Z7R0fX0IoXSBEFzE//FhhtZ1kCCgySlIz0S+g8csW9uy?=
 =?us-ascii?Q?CuKbUQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c2773497-3f98-4243-9e46-08db74ca6377
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2023 15:48:00.5358
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5eBGhV8Q7nFO4+UhRCUIHWQKlMxci5/IZ27+/0su4DxbrHvFxH9w8fVnYM0VTkSSs0Eq0bjO0wqVaKPsbAqv3kAXKUb/Th/shBTpO1wMK5k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR13MB4895
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 23, 2023 at 11:14:42PM +0200, Julia Lawall wrote:
> Use array_size to protect against multiplication overflows.
> 
> The changes were done using the following Coccinelle semantic patch:
> 
> // <smpl>
> @@
>     expression E1, E2;
>     constant C1, C2;
>     identifier alloc = {vmalloc,vzalloc};
> @@
>     
> (
>       alloc(C1 * C2,...)
> |
>       alloc(
> -           (E1) * (E2)
> +           array_size(E1, E2)
>       ,...)
> )
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

Reviewed-by: Simon Horman <simon.horman@corigine.com>