Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp13962081rwd; Sat, 24 Jun 2023 09:18:50 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6bP0oI69Q7kFKHBt7Fdwk1gaHQ+uopkdkY12j4V6sxuHzwagcmT22dyvtRQw0iaX0uoouY X-Received: by 2002:a05:6a00:1248:b0:66a:2dbf:e5ae with SMTP id u8-20020a056a00124800b0066a2dbfe5aemr15106200pfi.33.1687623530018; Sat, 24 Jun 2023 09:18:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687623530; cv=none; d=google.com; s=arc-20160816; b=zC8e5r7sbf1VRNDZBpgX4ajTWLw4+co6Qy72ACEmMDeWW6eTzTFC5dX0kWJx2Yckao x/RG4F0rhCkMv52dn9QZ7j+0NyrOeWAs+yL9Xn14Npbe/bZ3/qpDlmU8X/hXZCTwgUqz AnUcTeKJLLDTOqQIYcLEtbc5Mvc7KrxvbuQ2EhqsZOM8cK8pLUC7//lFkqKsKIsONqhh bC74ICFzjUuyGlz/OxAfkVncX84InBT3gpQ9h6ywgp7+osZ27mt8ZsST8Dr9Z+CRUov/ jUWMjQ4VewF9+oF8CzDp9mFVfLhJTMthwNhPgxuuwi1EB/4unx1WKssZV+6d/2MBS5pW kd3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :organization:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id; bh=ddj1OYpd0JaW4NlgpKbxGzVjXmaBswfBf1byChiHd2o=; fh=eGAlqWa0KxmK7qUB1/NkuuO6ILvTzhH9q5so71Sn8Lc=; b=Co2ZlqXOwktVcTdL8aphXzg/tDxBjoBQAGtbFnTAQyVTq4mi0OO3P7/hilAzTZq5eL ROQFnbSQCiCvEmSpJT84hmZoTx4GL1w0jwNjmaXsxWclT2yMWe2ZKaJQKOzv1Kov6PVk +F11h0M+fnMZ3uM1txn/3WyD8VQiA2vQ5WAmGKgSba9fA7SxewFImXQn1xQvJoXo2FoH HPOkvxXPQiFw3g5eh1qlgCGk/CGZTrF2t2Uks9vcTfAOaHSjCwie6BkS5saYJM5JwXKv 9nW1Kt+x/i3teRkrq+21TiTLunUWZjFjXMzNE06Ddw4VDLGy0FdTIlIPdu957dEfSgs/ m8nw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x17-20020a056a00189100b0064d2c624630si1707809pfh.23.2023.06.24.09.18.38; Sat, 24 Jun 2023 09:18:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231277AbjFXQLk (ORCPT + 99 others); Sat, 24 Jun 2023 12:11:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229485AbjFXQLi (ORCPT ); Sat, 24 Jun 2023 12:11:38 -0400 Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9A21D1BC1 for ; Sat, 24 Jun 2023 09:10:54 -0700 (PDT) Received: from loongson.cn (unknown [10.20.42.43]) by gateway (Coremail) with SMTP id _____8AxQ8SDFZdkNUMBAA--.1968S3; Sun, 25 Jun 2023 00:10:43 +0800 (CST) Received: from [10.20.42.43] (unknown [10.20.42.43]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Ax3c6CFZdkc28FAA--.27217S3; Sun, 25 Jun 2023 00:10:42 +0800 (CST) Message-ID: Date: Sun, 25 Jun 2023 00:10:42 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v10 07/11] drm/etnaviv: Add support for the dma coherent device Content-Language: en-US To: Lucas Stach , Sui Jingfeng <18949883232@163.com>, Russell King , Christian Gmeiner , David Airlie , Daniel Vetter Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, Philipp Zabel , Bjorn Helgaas References: <20230620094716.2231414-1-18949883232@163.com> <20230620094716.2231414-8-18949883232@163.com> <8f74f0962c8bab6c832919a5340667c54e1a7ddc.camel@pengutronix.de> <66fc74ae-299c-a5de-9cfb-07ae24fb3f07@loongson.cn> <8212078bd56c54ce508205eae0ed0b69e78d4c38.camel@pengutronix.de> <62bf84f19318c54c50f154e1eb64a179fb2389ce.camel@pengutronix.de> From: Sui Jingfeng Organization: Loongson In-Reply-To: <62bf84f19318c54c50f154e1eb64a179fb2389ce.camel@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CM-TRANSID: AQAAf8Ax3c6CFZdkc28FAA--.27217S3 X-CM-SenderInfo: xvxlyxpqjiv03j6o00pqjv00gofq/ X-Coremail-Antispam: 1Uk129KBj9xXoWrtr4kXr1xWr1fCrWxJw4fWFX_yoWDWrc_ur yI9a9Fkr45Xw4ktF4fK34ftrsIg3y3ZFy5JFy8tr17G34ruFn3AFn5JrnrJ3Z3W3Z7Grs8 WFZ8Ca97t34I9osvyTuYvTs0mTUanT9S1TB71UUUUjUqnTZGkaVYY2UrUUUUj1kv1TuYvT s0mT0YCTnIWjqI5I8CrVACY4xI64kE6c02F40Ex7xfYxn0WfASr-VFAUDa7-sFnT9fnUUI cSsGvfJTRUUUbDxYFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20EY4v20x vaj40_Wr0E3s1l1IIY67AEw4v_JrI_Jryl8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxS w2x7M28EF7xvwVC0I7IYx2IY67AKxVWUJVWUCwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxV WUJVW8JwA2z4x0Y4vEx4A2jsIE14v26r1j6r4UM28EF7xvwVC2z280aVCY1x0267AKxVWU JVW8JwAaw2AFwI0_Jrv_JF1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa02 0Ex4CE44I27wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_JF0_Jw1l Yx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI 0SjxkI62AI1cAE67vIY487MxkF7I0En4kS14v26r126r1DMxAIw28IcxkI7VAKI48JMxC2 0s026xCaFVCjc4AY6r1j6r4UMxCIbckI1I0E14v26r1Y6r17MI8I3I0E5I8CrVAFwI0_Jr 0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0E wIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJV W8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAI cVC2z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjxUcveHDUUUU X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2023/6/22 01:45, Lucas Stach wrote: >> Again, >> >> this is user-space things! >> >> this is user-space things! >> >> this is user-space things! >> >> I have explained several times. >> >> made the decision for the user-space program is wrong. >> > This mode of communication isn't helpful. Please stop it. > > As I tried to explain to you multiple times: if userspace can break > coherency by selecting the wrong mapping type then this is something > the kernel should prevent. > This is still a user-space things. While my point is that we want to prevent it at userspace. Please don't forget that sometime a user or a programmer want a wrong thing. Either because of the need of debugging itself or due to the curiosity of what it would happen if we doing something wrong. Sometimes, the wrong rendering may more interesting. The most important thing is that my patch is trying to increase the flexibility, and to increase the possibility. While you idea is to doing the reverse. -- Jingfeng