Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 24 Jun 2023 21:26:32 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     "Radu Pirea (NXP OSS)" <radu-nicolae.pirea@oss.nxp.com>
Cc:     hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        richardcochran@gmail.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, sebastian.tobuschat@nxp.com
Subject: Re: [PATCH v2 06/13] net: phy: nxp-c45-tja11xx: use get_features
Message-ID: <6655fb6a-0b28-4eb7-a5f1-9a74be3318e3@lunn.ch>
References: <20230623074123.152931-1-radu-nicolae.pirea@oss.nxp.com>
 <20230623074123.152931-7-radu-nicolae.pirea@oss.nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230623074123.152931-7-radu-nicolae.pirea@oss.nxp.com>
Precedence: bulk

On Fri, Jun 23, 2023 at 10:41:16AM +0300, Radu Pirea (NXP OSS) wrote:
> PHY_BASIC_T1_FEATURES are not the right features supported by TJA1103
> anymore.
> For example ethtool reports:
> 	[root@alarm ~]# ethtool end0
> 	Settings for end0:
> 	        Supported ports: [ TP ]
> 	        Supported link modes:   100baseT1/Full
> 	                                10baseT1L/Full
> 
> 10baseT1L/Full is not supported by TJA1103 and supported ports list is
> not completed. The PHY also have a MII port.
> 
> genphy_c45_pma_read_abilities implementation can detect the PHY features
> and they look like this.
> [root@alarm ~]# ethtool end0
> Settings for end0:
>         Supported ports: [ TP    MII ]
>         Supported link modes:   100baseT1/Full
>         Supported pause frame use: Symmetric
>         Supports auto-negotiation: No
>         Supported FEC modes: Not reported
>         Advertised link modes:  100baseT1/Full
>         Advertised pause frame use: Symmetric
>         Advertised auto-negotiation: No
>         Advertised FEC modes: Not reported
>         Speed: 100Mb/s
>         Duplex: Full
>         Auto-negotiation: off
>         master-slave cfg: forced master
>         master-slave status: master
>         Port: Twisted Pair
>         PHYAD: 1
>         Transceiver: external
>         MDI-X: Unknown
>         Supports Wake-on: g
>         Wake-on: d
>         Link detected: yes
>         SQI: 7/7
> 
> Signed-off-by: Radu Pirea (NXP OSS) <radu-nicolae.pirea@oss.nxp.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew