Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp14290783rwd; Sat, 24 Jun 2023 16:34:51 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ49Tcm3ifLed6cOkQYi6bXR7il8DBAFLQlmdrRnF8C5r52EZBBdhMrRCCFj09yqi+cd+MUY X-Received: by 2002:a05:6a00:168d:b0:66f:912b:d6f with SMTP id k13-20020a056a00168d00b0066f912b0d6fmr1873294pfc.0.1687649691054; Sat, 24 Jun 2023 16:34:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687649691; cv=none; d=google.com; s=arc-20160816; b=cTGcsTwZcVnnjIwLSR62Yc3HeH6xGFp5sDluOFFUnNapgtnCgCFvmFV1ebC/mleO5x y2uIhjLK7zoXpTqmM0td6FKM4D2zjqMVdHCVsN7LnlXd3Fsa94J0VKpRK4G3rEZcdBEp 7FJvc79dOM04kHrT6J3KZA+PKojbtPBT96CcaRBVkIaIiksUOJwTFEvbElz5hDzr2KAC VPPmguGYs3SscoqoLao671t9cdYXYiIClGQ4ehSEvTBUViG0g92FxSIi3HPVtdD2Eeov Plo5CGgU8N9mfLJzAoukTyy6gRWwAF27mvEPKpIkRiR37ftxBcLGPoQoBMs0i4rs3+v/ 5SLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=PGSR4UEKOP/Moy0FU+SzKF7TN80aIF4m7G46Hhyc3O8=; fh=9eW7dT0TP1+bRVe9jNcTaykWW8WEuhGHmLV3HjgJSa0=; b=miNY+7flFQVNwYtPwfPAmVZ0iO4nSPQUSJsDjYqtUeddyzW6usEculw5SZUFKgq2Fe RugcAAyFeWiY3gszvIAOgrIy18Ia3DHA08WhMeL+1Je9k6zbEon8xVm7OM+3Grj7+209 srom11ckABC0maXd8gk3sx3Sw1moAK+Thh3QhN6j8B/MhEkuHCf3mCC0UVsemvvW6xz2 jjdxobEDa3vTMUs94+jm+/pced4Yjdt470ZPhgvf96tFyVTIxOZb2/2e7TVnSPHsi+Pb tvASi8jdiNAHH9AhpTlWVoGyiJ9N/36oFKdysFULI6Nx2fzAdHBnpW071euMhikrJslO 20Gw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FDUqIVyj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ef8-20020a056a002c8800b0066675b3f21esi1998139pfb.36.2023.06.24.16.34.35; Sat, 24 Jun 2023 16:34:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FDUqIVyj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229576AbjFXW2a (ORCPT + 99 others); Sat, 24 Jun 2023 18:28:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbjFXW23 (ORCPT ); Sat, 24 Jun 2023 18:28:29 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C072710D8; Sat, 24 Jun 2023 15:28:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5C75160A71; Sat, 24 Jun 2023 22:28:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CF96C433C0; Sat, 24 Jun 2023 22:28:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687645707; bh=Xr9seD7Mt0PFVk1QOrKGfmugFEuY6PJhYDOWIjAJ3WA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FDUqIVyjZ3Cfh7ExAtZpIjceASv+BaEVlPCa8QEJ4bwPEW+jTqHQZEhfONR2MUwc3 5Mp0gKdkLj4yYQLd4HON2qkF41Gafrrox+E8wFnOW/o5l/4AJbOUNJWX33+EWfgGPg IMlt1eu3C19cBzoreFP44pgNG2aoeP1nlScOiTGit6W6FmW3c+wdZg8Z/Irg/2VY/z Va3h1a652baAJCbUVekzBE2STG4luQM/yDQ6HLorqhIp8fbo+xUhdkDX4AMjOZ5DwS gkOJ3WQc57aXgpkdEaF2BUlXnavrG1sH82rKexDKVDH4aTA6K8cg+7HxoqVa2B0Lza 4jV57LkHmGFlQ== Date: Sat, 24 Jun 2023 15:28:26 -0700 From: Jakub Kicinski To: Julia Lawall Cc: Veerasenareddy Burru , keescook@chromium.org, kernel-janitors@vger.kernel.org, Abhijit Ayarekar , "David S. Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/26] octeon_ep: use array_size Message-ID: <20230624152826.10e3789b@kernel.org> In-Reply-To: <20230623211457.102544-3-Julia.Lawall@inria.fr> References: <20230623211457.102544-1-Julia.Lawall@inria.fr> <20230623211457.102544-3-Julia.Lawall@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 23 Jun 2023 23:14:33 +0200 Julia Lawall wrote: > - oq->buff_info = vzalloc(oq->max_count * OCTEP_OQ_RECVBUF_SIZE); > + oq->buff_info = vzalloc(array_size(oq->max_count, OCTEP_OQ_RECVBUF_SIZE)); vcalloc seems to exist, is there a reason array_size() is preferred? -- pw-bot: cr