Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230623230139.985594-1-namhyung@kernel.org> <CAP-5=fX6Of3pKjZGLEaNL58opn2veXxOhrY_sQqgY6hgUJeaBw@mail.gmail.com>
In-Reply-To: <CAP-5=fX6Of3pKjZGLEaNL58opn2veXxOhrY_sQqgY6hgUJeaBw@mail.gmail.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Sat, 24 Jun 2023 16:39:15 -0700
Message-ID: <CAM9d7cixNFh7Uym7O+=eLV10a+e7E6eGW_TWcLNtR4kGJ6o9HA@mail.gmail.com>
Subject: Re: [PATCH 1/2] perf test: Reorder event name checks in stat STD
 output linter
To:     Ian Rogers <irogers@google.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-perf-users@vger.kernel.org,
        Kan Liang <kan.liang@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Fri, Jun 23, 2023 at 4:22 PM Ian Rogers <irogers@google.com> wrote:
>
> On Fri, Jun 23, 2023 at 4:01 PM Namhyung Kim <namhyung@kernel.org> wrote:
> >
> > On AMD machines, the perf stat STD output test failed like below:
> >
> >   $ sudo ./perf test -v 98
> >    98: perf stat STD output linter                                     :
> >   --- start ---
> >   test child forked, pid 1841901
> >   Checking STD output: no argswrong event metric.
> >     expected 'GHz' in 108,121 stalled-cycles-frontend  # 10.88% frontend cycles idle
> >   test child finished with -1
> >   ---- end ----
> >   perf stat STD output linter: FAILED!
> >
> > This is because there are stalled-cycles-{frontend,backend} events are
> > used by default.  The current logic checks the event_name array to find
> > which event it's running.  But 'cycles' event comes before those stalled
> > cycles event and it matches first.  So it tries to find 'GHz' metric
> > in the output (which is for the 'cycles') and fails.
> >
> > Move the stalled-cycles-{frontend,backend} events before 'cycles' so
> > that it can find the stalled cycles events first.
> >
> > Also add a space after 'no args' test name for consistency.
> >
> > Fixes: 99a04a48f225 ("perf test: Add test case for the standard 'perf stat' output")
> > Cc: Kan Liang <kan.liang@linux.intel.com>
> > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
>
> Acked-by: Ian Rogers <irogers@google.com>

Applied both to perf-tools-next, thanks!