Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <4d1d5fac-4ad1-2ea7-a349-1b174be694d3@roeck-us.net>
Date:   Sat, 24 Jun 2023 16:49:59 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH] hwmon: (oxp-sensors) Add support for AOKZOE A1 PRO
Content-Language: en-US
To:     =?UTF-8?Q?Joaqu=c3=adn_Ignacio_Aramend=c3=ada?= 
        <samsagax@gmail.com>
Cc:     Jerrod Frost <jcfrosty@proton.me>, derekjohn.clark@gmail.com,
        jdelvare@suse.com, linux-hwmon@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230624231637.14941-2-samsagax@gmail.com>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <20230624231637.14941-2-samsagax@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 6/24/23 16:16, Joaquín Ignacio Aramendía wrote:
> From: Jerrod Frost <jcfrosty@proton.me>
> 
> This device is an iteration over the AOKZOE A1 with the same EC mapping
> and features. It also has support for tt_toggle.
> 
> Thanks to Jerrod for authoring and testing.
> 
> Signed-off-by: Joaquín Ignacio Aramendía <samsagax@gmail.com>

From: and the first Signed-off-by: have to match. You would need
Jerrod's Signed-off-by: tag to keep his authorship.

Guenter

> ---
>   Documentation/hwmon/oxp-sensors.rst | 2 ++
>   drivers/hwmon/oxp-sensors.c         | 7 +++++++
>   2 files changed, 9 insertions(+)
> 
> diff --git a/Documentation/hwmon/oxp-sensors.rst b/Documentation/hwmon/oxp-sensors.rst
> index 0ca1f7728c34..3adeb7406243 100644
> --- a/Documentation/hwmon/oxp-sensors.rst
> +++ b/Documentation/hwmon/oxp-sensors.rst
> @@ -30,6 +30,7 @@ Supported devices
>   Currently the driver supports the following handhelds:
>   
>    - AOK ZOE A1
> + - AOK ZOE A1 PRO
>    - Aya Neo 2
>    - Aya Neo AIR
>    - Aya Neo AIR Pro
> @@ -40,6 +41,7 @@ Currently the driver supports the following handhelds:
>   
>   "Turbo/Silent" button behaviour toggle is only supported on:
>    - AOK ZOE A1
> + - AOK ZOE A1 PRO
>    - OneXPlayer mini AMD (only with updated alpha BIOS)
>    - OneXPlayer mini AMD PRO
>   
> diff --git a/drivers/hwmon/oxp-sensors.c b/drivers/hwmon/oxp-sensors.c
> index 1e59d97219c4..e1a907cae820 100644
> --- a/drivers/hwmon/oxp-sensors.c
> +++ b/drivers/hwmon/oxp-sensors.c
> @@ -77,6 +77,13 @@ static const struct dmi_system_id dmi_table[] = {
>   		},
>   		.driver_data = (void *)aok_zoe_a1,
>   	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "AOKZOE"),
> +			DMI_EXACT_MATCH(DMI_BOARD_NAME, "AOKZOE A1 Pro"),
> +		},
> +		.driver_data = (void *)aok_zoe_a1,
> +	},
>   	{
>   		.matches = {
>   			DMI_MATCH(DMI_BOARD_VENDOR, "AYANEO"),