Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v5 4/4] perf tools: Add printing perf_event_attr config
 symbol in perf_event_attr__fprintf()
To:     Namhyung Kim <namhyung@kernel.org>
CC:     <peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
        <mark.rutland@arm.com>, <alexander.shishkin@linux.intel.com>,
        <jolsa@kernel.org>, <irogers@google.com>,
        <adrian.hunter@intel.com>, <anshuman.khandual@arm.com>,
        <jesussanp@google.com>, <linux-perf-users@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20230623054416.160858-1-yangjihong1@huawei.com>
 <20230623054416.160858-5-yangjihong1@huawei.com>
 <CAM9d7cjzzmjQnJUvE2a6bqDao07o9+mSyJH4C4xRq0zEZJwLnQ@mail.gmail.com>
From:   Yang Jihong <yangjihong1@huawei.com>
Message-ID: <2654189b-0804-305a-be06-3234f39f0403@huawei.com>
Date:   Sun, 25 Jun 2023 09:38:27 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
MIME-Version: 1.0
In-Reply-To: <CAM9d7cjzzmjQnJUvE2a6bqDao07o9+mSyJH4C4xRq0zEZJwLnQ@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hello,

On 2023/6/24 13:28, Namhyung Kim wrote:
> Hello,
> 
> On Thu, Jun 22, 2023 at 10:46 PM Yang Jihong <yangjihong1@huawei.com> wrote:
>>
>> When printing perf_event_attr, always display perf_event_attr config and
>> its symbol to improve the readability of debugging information.
>>
> 
> [SNIP]
>> +
>> +#ifdef HAVE_LIBTRACEEVENT
>> +static void __p_config_tracepoint_id(char *buf, size_t size, u64 value)
>> +{
>> +       char *str = tracepoint_id_to_name(value);
> 
> This makes the python module import test failing due to the
> undefined symbol.  I'll fix it by adding a dummy function in
> util/python.c file.  But next time, please run `perf test` first
> and make sure you don't break anything.

Thanks for the correction.

Running `perf test` on my environment has only one testcase for python:

19:'import perf' in python: Ok

The result is OK. The possible cause is that some libraries are missing 
in my environment. As a result, other Python tests are not executed. 
I'll check them first.

Thanks,
Yang