Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] md/raid1: prioritize adding disk to 'removed' mirror
To:     linan666@huaweicloud.com, song@kernel.org
Cc:     linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
        linan122@huawei.com, yi.zhang@huawei.com, houtao1@huawei.com,
        yangerkun@huawei.com, "yukuai (C)" <yukuai3@huawei.com>
References: <20230623172525.2513235-1-linan666@huaweicloud.com>
From:   Yu Kuai <yukuai1@huaweicloud.com>
Message-ID: <d02d4a53-84ed-cb65-b0d8-2a199bc068cd@huaweicloud.com>
Date:   Sun, 25 Jun 2023 10:06:30 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20230623172525.2513235-1-linan666@huaweicloud.com>
Content-Type: text/plain; charset=gbk; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

?? 2023/06/24 1:25, linan666@huaweicloud.com д??:
> From: Li Nan <linan122@huawei.com>
> 
> New disk should be added to "removed" position first instead of to be a
> replacement. Commit 6090368abcb4 ("md/raid10: prioritize adding disk to
> 'removed' mirror") has fixed this issue for raid10. This patch fixes raid1.

This commit message "This patch ..." shound use imperative mood, other
than that, this patch LGTM.

Reviewed-by: Yu Kuai <yukuai3@huawei.com>
> 
> Signed-off-by: Li Nan <linan122@huawei.com>
> ---
>   drivers/md/raid1.c | 26 +++++++++++++++-----------
>   1 file changed, 15 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
> index 68a9e2d9985b..320bede4bfab 100644
> --- a/drivers/md/raid1.c
> +++ b/drivers/md/raid1.c
> @@ -1782,7 +1782,7 @@ static int raid1_add_disk(struct mddev *mddev, struct md_rdev *rdev)
>   {
>   	struct r1conf *conf = mddev->private;
>   	int err = -EEXIST;
> -	int mirror = 0;
> +	int mirror = 0, repl_slot = -1;
>   	struct raid1_info *p;
>   	int first = 0;
>   	int last = conf->raid_disks - 1;
> @@ -1825,17 +1825,21 @@ static int raid1_add_disk(struct mddev *mddev, struct md_rdev *rdev)
>   			break;
>   		}
>   		if (test_bit(WantReplacement, &p->rdev->flags) &&
> -		    p[conf->raid_disks].rdev == NULL) {
> -			/* Add this device as a replacement */
> -			clear_bit(In_sync, &rdev->flags);
> -			set_bit(Replacement, &rdev->flags);
> -			rdev->raid_disk = mirror;
> -			err = 0;
> -			conf->fullsync = 1;
> -			rcu_assign_pointer(p[conf->raid_disks].rdev, rdev);
> -			break;
> -		}
> +		    p[conf->raid_disks].rdev == NULL && repl_slot < 0)
> +			repl_slot = mirror;
>   	}
> +
> +	if (err && repl_slot >= 0) {
> +		/* Add this device as a replacement */
> +		p = conf->mirrors + repl_slot;
> +		clear_bit(In_sync, &rdev->flags);
> +		set_bit(Replacement, &rdev->flags);
> +		rdev->raid_disk = repl_slot;
> +		err = 0;
> +		conf->fullsync = 1;
> +		rcu_assign_pointer(p[conf->raid_disks].rdev, rdev);
> +	}
> +
>   	print_conf(conf);
>   	return err;
>   }
>