Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <06f8c00f-d6a3-f93b-0db7-b89a3f49d91e@huaweicloud.com>
Date:   Sun, 25 Jun 2023 14:46:42 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH] md/raid1: prioritize adding disk to 'removed' mirror
To:     Yu Kuai <yukuai1@huaweicloud.com>, song@kernel.org
Cc:     linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
        linan122@huawei.com, yi.zhang@huawei.com, houtao1@huawei.com,
        yangerkun@huawei.com, "yukuai (C)" <yukuai3@huawei.com>
References: <20230623172525.2513235-1-linan666@huaweicloud.com>
 <d02d4a53-84ed-cb65-b0d8-2a199bc068cd@huaweicloud.com>
From:   Li Nan <linan666@huaweicloud.com>
In-Reply-To: <d02d4a53-84ed-cb65-b0d8-2a199bc068cd@huaweicloud.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2023/6/25 10:06, Yu Kuai 写道:
> Hi,
> 
> 在 2023/06/24 1:25, linan666@huaweicloud.com 写道:
>> From: Li Nan <linan122@huawei.com>
>>
>> New disk should be added to "removed" position first instead of to be a
>> replacement. Commit 6090368abcb4 ("md/raid10: prioritize adding disk to
>> 'removed' mirror") has fixed this issue for raid10. This patch fixes 
>> raid1.
> 
> This commit message "This patch ..." shound use imperative mood, other
> than that, this patch LGTM.
> 
> Reviewed-by: Yu Kuai <yukuai3@huawei.com>

OK, I will change it. Thanks for your review.

-- 
Thanks,
Nan