Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp14614182rwd; Sun, 25 Jun 2023 00:43:27 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6CkE/jc5mRdlzKEdkEOrnDAxuaIHf37n4Y82/zXbmFQAeaFd31b2qVatTkqMe/p7J/kGJy X-Received: by 2002:a05:6870:1a97:b0:1b0:2d17:9a7d with SMTP id ef23-20020a0568701a9700b001b02d179a7dmr2113866oab.0.1687679006845; Sun, 25 Jun 2023 00:43:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687679006; cv=none; d=google.com; s=arc-20160816; b=zYhsgGyE9KDkvjEs95sa2cQTfsCN+aJa8cDiWUIC2qFBj0YzAp3h82+ZjeRsWHOg/c WJmRbXr5EiefF+eNlzxL3fCcB0amt96+Rxd9sy7CkIwERENGyEsVHgLqVYH1RxujH8aT sBmCeWrDzYB0tc9EXvUT8sh95ZpvbgESXZT5o+c+n3yPQR63+a4wlo3dY7P5ijKuynXn ErxjZG+P/lnUr7vDKQKUCHPbgeWR1Gc7xs0XwU7YNv5OAFe5s8RFmveWysmbwI9ZB/nz EFTDWRSbeGd/wsWrwnwS7xdgzdiOpX12KWyLLEum/YtBiHPOAklg6rsLQo3kwsIzrHeI X/CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=cD3/KquyRFt0R1MxQMeGduFYrQ+E3YkzxaJ+T2sBA/A=; fh=YvtWbebQsRPEZSBu58ultTGSE5TJDPWtYq0nb3wR0H8=; b=fdsvHKGKP24up3I6KmCTE/Gxo2Wj72n1b3VVpIQBU40PimJvJhWy+h6qJDvS5PyS/g s0Tv4EH2LvSKjuxW6+LsU7oJ5V6lUXH1g5CpQH9uCq8L6olgD3PyR0HjAFxm+jylXDxV P2dN+rQE+tj7LM9kW0h/eXj9UMUlNMiyCHLG2yW4VJ37NhwdbosjttXVUDTS8FKoQQe9 7AJFl9c54M8/zdu5Nl8pwKz7I5goRknJX+VbXpwgjSpEp2qrj6Hf4a5aiFGIVeQMZ+Hj apwdEIrcjqhCoh5cu4cOOvMLfR+4MNZrInsLwt/YQx3b0xe+bbgbPmTbur7AetxRgSQQ ipMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Or2aif5A; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a21-20020a63e855000000b0055392732f68si2155838pgk.496.2023.06.25.00.43.12; Sun, 25 Jun 2023 00:43:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Or2aif5A; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230506AbjFYHel (ORCPT + 99 others); Sun, 25 Jun 2023 03:34:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229653AbjFYHej (ORCPT ); Sun, 25 Jun 2023 03:34:39 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D91A11B5; Sun, 25 Jun 2023 00:34:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687678478; x=1719214478; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=MPQi2c2fpXlw+ZthqxGOQmVWtzdUzfcjBa7myYXUx6I=; b=Or2aif5AXuBLAgAHslkbvQ2ZBG50DzI21LNMFtXRE5dWptF8p689Asrq DE90otBXatAPlV3pxYD4IbRSY8dzgV2n23dV/3lQA3e64hz2DoT+YS5nl 1mGucjPq9MDMFJ//8TzCTbYFJX+l1T7beo5kPrX9JNKRaNRgXx4E66Y9C iSQJ+6DUGoQSiRPUmrW6eLJk/7atcUnCjCH3FB/+NAnnp0zlEsZuYfJFI jd+Idd72JHTRiIlQHEVTLIPXhOV3ObuDPsU3Dl3EuCN4k/qaZip/sZ6AJ bAwaq0qpfJcCrHMj70pJbjRLNMKctuFGRFj6HS8bPRNT0akVkACkK+iIk g==; X-IronPort-AV: E=McAfee;i="6600,9927,10751"; a="340628223" X-IronPort-AV: E=Sophos;i="6.01,156,1684825200"; d="scan'208";a="340628223" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2023 00:34:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10751"; a="745427810" X-IronPort-AV: E=Sophos;i="6.01,156,1684825200"; d="scan'208";a="745427810" Received: from yilunxu-optiplex-7050.sh.intel.com (HELO localhost) ([10.239.159.165]) by orsmga008.jf.intel.com with ESMTP; 25 Jun 2023 00:34:36 -0700 Date: Sun, 25 Jun 2023 15:33:29 +0800 From: Xu Yilun To: Marco Pagani Cc: Moritz Fischer , Wu Hao , Tom Rix , linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org Subject: Re: [PATCH v7 2/4] fpga: add an initial KUnit suite for the FPGA Bridge Message-ID: References: <20230616154405.220502-1-marpagan@redhat.com> <20230616154405.220502-3-marpagan@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230616154405.220502-3-marpagan@redhat.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023-06-16 at 17:44:03 +0200, Marco Pagani wrote: > The suite tests the basic behaviors of the FPGA Bridge including > the functions that operate on a list of Bridges. ^ why uppercase? > > Signed-off-by: Marco Pagani > --- > drivers/fpga/tests/fpga-bridge-test.c | 175 ++++++++++++++++++++++++++ > 1 file changed, 175 insertions(+) > create mode 100644 drivers/fpga/tests/fpga-bridge-test.c > > diff --git a/drivers/fpga/tests/fpga-bridge-test.c b/drivers/fpga/tests/fpga-bridge-test.c > new file mode 100644 > index 000000000000..fce67ac59a7c > --- /dev/null > +++ b/drivers/fpga/tests/fpga-bridge-test.c > @@ -0,0 +1,175 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * KUnit test for the FPGA Bridge > + * > + * Copyright (C) 2023 Red Hat, Inc. > + * > + * Author: Marco Pagani > + */ > + > +#include > +#include > +#include > +#include > +#include alphabetical order please. Others LGTM. Acked-by: Xu Yilun