Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Date:   Sun, 25 Jun 2023 07:39:10 +0000
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
From:   "Yajun Deng" <yajun.deng@linux.dev>
Message-ID: <4c361d62e0b77242fe4b8592c82c4d90@linux.dev>
Subject: Re: [PATCH] memblock: Introduce memblock_reserve_node()
To:     "Mike Rapoport" <rppt@kernel.org>
Cc:     akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
In-Reply-To: <20230625050850.GJ52412@kernel.org>
References: <20230625050850.GJ52412@kernel.org>
 <20230624024622.2959376-1-yajun.deng@linux.dev>
Precedence: bulk

June 25, 2023 1:08 PM, "Mike Rapoport" <rppt@kernel.org> wrote:=0A=0A> On=
 Sat, Jun 24, 2023 at 10:46:22AM +0800, Yajun Deng wrote:=0A> =0A>> It on=
ly returns address now in memblock_find_in_range_node(), we can add a=0A>=
> parameter pointing to integer for node id of the range, which can be us=
ed=0A>> to pass the node id to the new reserve region.=0A>> =0A>> Introdu=
ce memblock_reserve_node() so that the node id can be passed to=0A>> the =
reserve region in memblock_alloc_range_nid().=0A>> =0A>> Signed-off-by: Y=
ajun Deng <yajun.deng@linux.dev>=0A> =0A> What problem does this patch so=
lve?=0A>=0A=0AIf we set nid and flags in memblock_alloc_range_nid(), we m=
ay not need=0Amemblock_set_node() in memmap_init_reserved_pages().=0A=0AI=
 tested this patch and delete memblock_set_node() in memmap_init_reserved=
_pages().=0AIt works fine. I did not delete memblock_set_node() in this p=
atch just in case.=0A =0A> --=0A> Sincerely yours,=0A> Mike.