Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp14659787rwd; Sun, 25 Jun 2023 01:48:22 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ48eE3qSCLROltSTeOO5PLgjNr86dArmpIHlZW2+wjaMYsHyWEinYn6myKTIKXMMzdMtzNQ X-Received: by 2002:a05:622a:4c7:b0:400:8467:7d51 with SMTP id q7-20020a05622a04c700b0040084677d51mr10304766qtx.19.1687682901801; Sun, 25 Jun 2023 01:48:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687682901; cv=none; d=google.com; s=arc-20160816; b=09SvcdvdrXLGjJXPi5RGZSB/+Ifn1Hohcgp04KX9KfogEZ00/Ru5SW7anMAP+FgFA/ 7D4O8TpWn/VjEIIPH3Uovm5Jc1i1APkqFmY54o1NkpFY1xebKS2fXZ0V+XOC3pas29Ps uky8XwOxzFigfJwdIF3SplGbR5L7p1ZSoL8obua+PZbu8deXUrUMHyDhohwVQGtrToY0 0gxOBrqrfBODtblZ5CMjXkngCNMcvmshsFuucBOxuXtr/SkoqrJFdDz5TM9gMFyC/+mm 3XGfuHBICHVZaaMp4amrZH9NGbPfmiNV7WPk/YWPh5rXMtWix5d3rly71x8LWoAizPp5 D25A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=MnKBCNYXhoziAnkbjsqxAoqMwhoKVYlHC2VWbc8rQD0=; fh=jq9x12Vh37jPyzHTWjUeqSdjcFFsl0lLifUF6JdLMWg=; b=DH68G/2dyFsVsJP+WCfyb30JG+++aFasSqGeh7bTEK28gqjFyj9BGfHQ+Lglrr6gd9 F9tJG3lylljLocjPt5NbsEsRao4zHw+nzFgKluszpIawdX2QOm3opJw+lh107ukguPqm zYRelLttSsCA8FbJ3HnJNd8Gw06VIERSBIQF9sjfxZ3Do8sId5y6uE0mXBQhP65mDG7j NHu/K2Hb8T8oe8Lxm8Qp04dXQl+mc+TTXSBS1bO0QZGksOn0HHR+clXpy3cP7rojpkKd eLPQJzpe4yRjQXr3xwpRK/tDICCZ0AxeMZmEAGWAgYAuqerc4NrNC2YrrIbKHhhFMACV wpRw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t36-20020a056a0013a400b00661e422cf5bsi2854975pfg.249.2023.06.25.01.48.10; Sun, 25 Jun 2023 01:48:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231387AbjFYIYb (ORCPT + 99 others); Sun, 25 Jun 2023 04:24:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231199AbjFYIY3 (ORCPT ); Sun, 25 Jun 2023 04:24:29 -0400 Received: from out30-99.freemail.mail.aliyun.com (out30-99.freemail.mail.aliyun.com [115.124.30.99]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18CFAE6F for ; Sun, 25 Jun 2023 01:24:27 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R241e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045170;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0VlrlpwT_1687681454; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0VlrlpwT_1687681454) by smtp.aliyun-inc.com; Sun, 25 Jun 2023 16:24:23 +0800 From: Jiapeng Chong To: bskeggs@redhat.com Cc: kherbst@redhat.com, lyude@redhat.com, airlied@gmail.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH] drm/nouveau: Remove the unused variable entry Date: Sun, 25 Jun 2023 16:24:13 +0800 Message-Id: <20230625082413.111375-1-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Variable entry is not effectively used, so delete it. drivers/gpu/drm/nouveau/nouveau_connector.c:1298:7: warning: variable 'entry' set but not used. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5596 Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/nouveau/nouveau_connector.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c index f75c6f09dd2a..3a267b793afa 100644 --- a/drivers/gpu/drm/nouveau/nouveau_connector.c +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c @@ -1295,11 +1295,8 @@ nouveau_connector_create(struct drm_device *dev, /* attempt to parse vbios connector type and hotplug gpio */ nv_connector->dcb = olddcb_conn(dev, index); if (nv_connector->dcb) { - u32 entry = ROM16(nv_connector->dcb[0]); - if (olddcb_conntab(dev)[3] >= 4) - entry |= (u32)ROM16(nv_connector->dcb[2]) << 16; - nv_connector->type = nv_connector->dcb[0]; + if (drm_conntype_from_dcb(nv_connector->type) == DRM_MODE_CONNECTOR_Unknown) { NV_WARN(drm, "unknown connector type %02x\n", -- 2.20.1.7.g153144c