Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 25 Jun 2023 14:28:49 +0000
From:   "Dr. David Alan Gilbert" <linux@treblig.org>
To:     sfrench@samba.org, linkinjeon@kernel.org, shaggy@kernel.org
Cc:     jfs-discussion@lists.sourceforge.net, linux-cifs@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Duplicate unicode tables in smb/cifs/jfs
Message-ID: <ZJhPIYSUzBpuqosh@gallifrey>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
User-Agent: Mutt/2.0.5 (2021-01-21)
Precedence: bulk

Hi All,
  I just tripped over three sets of duplicated unicode tables and
wondered if anyone had tried to rationalise them:

  The pair of:
   ./fs/smb/server/uniupr.h
   ./fs/smb/client/cifs_uniupr.h

   are identical except for formatting.

./fs/jfs/jfs_uniupr.c,
  and I think this is the same with some change in variable name.

(I'm guessing the same thing is implemented in a bunch of
other places as well in a different way)

Would it make sense to swing fs/smb/server/uniupr.h up to
hmm, maybe fs/uniupr.h, remove any of the cifs_ prefixes
and then use the same include in all 3 places?

Maybe then later look at using some of the nls code?

Dave (who just tripped over this stuff)

-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/