From: ebiederm@xmission.com (Eric W. Biederman)
To: Jeff Garzik <jeff@garzik.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/9] irq-remove: arch non-trivial
References: <20071019075443.GA6407@havoc.gtf.org>
	<20071019075543.GC6407@havoc.gtf.org>
	<m1tzonghco.fsf@ebiederm.dsl.xmission.com>
	<4718E67F.6000300@garzik.org>
Date: Fri, 19 Oct 2007 13:38:39 -0600
In-Reply-To: <4718E67F.6000300@garzik.org> (Jeff Garzik's message of "Fri, 19
	Oct 2007 13:16:47 -0400")
Message-ID: <m1przagaio.fsf@ebiederm.dsl.xmission.com>
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1150
Lines: 30

Jeff Garzik <jeff@garzik.org> writes:

> Eric W. Biederman wrote:
>> In this case we can easily pass the irqno into request_irq, allowing
>> us to do "unsigned int intno = (unsigned int)dev_id;".
>>
>> I suspect this is the case for the majority of the non-trivial users
>> as well.
>
>
> Not that easy, alas :)  Save for weirdos like the mac drivers I highlighted, it
> seems like most drivers in the non-trivial already pass a useful pointer to
> request_irq().

I was talking about vm86_32.c in particular.  Where we allow user space
through the vm86 interface to directly handle the isa irq.

> But as I mentioned, most of the "non-trivial" uses are actually trivial -- just
> not as simple as removing the 'int irq' argument.  Most of the time the irq
> number is used in non-critical ways like printk's.  A few times its used to
> index into a structure (something dev_id could replace).

Yes.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/