Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936033AbXJSTlg (ORCPT ); Fri, 19 Oct 2007 15:41:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758349AbXJSTl3 (ORCPT ); Fri, 19 Oct 2007 15:41:29 -0400 Received: from www.tglx.de ([62.245.132.106]:39425 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758804AbXJSTl2 (ORCPT ); Fri, 19 Oct 2007 15:41:28 -0400 Date: Fri, 19 Oct 2007 21:41:03 +0200 (CEST) From: Thomas Gleixner To: "Eric W. Biederman" cc: Ingo Molnar , Jeff Garzik , LKML Subject: Re: [PATCH 0/9] Remove 'irq' argument from all irq handlers In-Reply-To: Message-ID: References: <20071019075443.GA6407@havoc.gtf.org> <20071019190721.GA1514@elte.hu> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1095 Lines: 30 On Fri, 19 Oct 2007, Eric W. Biederman wrote: > Ingo Molnar writes: > > > * Eric W. Biederman wrote: > > > >> > thanks for doing this. > >> > >> Yes. keeping this alive is good. > >> > >> The practical question is how do we make this change without breaking > >> the drivers that use their irq argument. > > > > the get_irq_regs() approach worked out really well. We should do a > > get_irq_nr() and be done with it? > > The problem are some drivers today pass in 0 for their irq number > to flag that they are calling the interrupt handler in a polling > mode (not from interrupt context?) so the same logic doesn't quite apply. > > Do what you suggest would likely break those drivers. How many of them do we have ? This is a wilful abuse of the API, so its not a big damage if they break. tglx - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/