Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp15107775rwd; Sun, 25 Jun 2023 10:16:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6+iBppMEWMMsHzNmknzhC+ZDI91BCihIgsUX5VeF6Ctfr24cKWue5ysN0Wh0TNCaQLrS8S X-Received: by 2002:a17:902:868f:b0:1b3:ec08:f8e2 with SMTP id g15-20020a170902868f00b001b3ec08f8e2mr1636608plo.49.1687713403477; Sun, 25 Jun 2023 10:16:43 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1687713403; cv=pass; d=google.com; s=arc-20160816; b=IzX/fQWQCNeSlKy+jEGAgYGy4gzBItxuvubNPSFbNc/YubFMp4ReXlyzMfqQqqGUKC CSEeHV4ir5fV4GuOoETV1mPxNuzn5vGhqa/vW40ZKroTwP825hfXJNOboBnJ8e/LLjWy xK29o6fXJI1sl1miiEw8ICKfzY63gMhPWn+WYVm1tZazKKF2BS39IGoSidWkAw2/8V1U YBcnjMoNfcGl0jeoRmu1E0TJg+eRRjr4nl8GXO2O8mcbfl5CB/Wdgjo96mp0VdGBkmav w3PkdHpZos2YRQBiZJ76NohPSkng4ZxfDngMwVAc9jXExVtL8R9lEa5NeWQSAx0lG9rW G9JA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:date:references:in-reply-to:subject :cc:to:from:dkim-signature:message-id; bh=8htG7rHHL97H05txH4/SKfeVPifIbRS3sVXBTSrVOSE=; fh=j5XA4mTNjHByp+YdoYwLVGR+xmtjGbLo05ci10RGQy0=; b=gBCLFj/Qj9sUKp4gaJdH2kPSbB16p4226ZKD959FXZ42Q8V2WhPJe7Fuwp7hcreH7Z dq0qezvi2xt7PkRe7keLPuKv/Jevnsskw/sgs9FeqRfjxt+JHovFG5Fm75A5MWBq01oE TbBSfFdmVdK2fcJiAJqhBROwlR7tDHoPBmfpQOmrjVhwnB9t5Uy444/l3JYN3344Jvtj UNYju4neAdFa+ARaoz/7ye77wxmc+n6jbOpxYvN7OtxYjZsaPMo1BrKriWJniU9URvcJ JC0jlNm9DYMIq3Ntuz2j6EFNPH3eYd+fsHWBeVtZYCqf4c7wobuT2q56La1xY1LOECX5 Rktw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@manguebit.com header.s=dkim header.b=D3TQs+t+; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=manguebit.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t13-20020a170902e84d00b001b7d4eded9dsi3504160plg.265.2023.06.25.10.16.31; Sun, 25 Jun 2023 10:16:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@manguebit.com header.s=dkim header.b=D3TQs+t+; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=manguebit.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229841AbjFYQ7B (ORCPT + 99 others); Sun, 25 Jun 2023 12:59:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229447AbjFYQ67 (ORCPT ); Sun, 25 Jun 2023 12:58:59 -0400 Received: from mx.manguebit.com (mx.manguebit.com [167.235.159.17]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A81C10D; Sun, 25 Jun 2023 09:58:57 -0700 (PDT) Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manguebit.com; s=dkim; t=1687712334; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8htG7rHHL97H05txH4/SKfeVPifIbRS3sVXBTSrVOSE=; b=D3TQs+t+fqsVCOxjbYzX4cBlkf8bknlCcKts8Uo6HfyveOsXzfP2iPdWV2e69VNPXKF+kX LTQxCiNc9KCxKUPrsO2sr19YJG6S36t+Fixs1CZP9d5bGXzMHo/COmaVHRREPw3sz4iRwA a5AklFyEhTQmjd7DaM/54PwUkYIRSojOGpyEVib75uoYSVAX1BvWNvqFAqN0wDAZpIoVWZ MAfxMIGZxKTUnaBmHIc+yJ9FKQV9xFDUcIXQzz5V1OMT3EDF6U0zLd6rOKLkYqT6ECg/zB Li2ddXXre26pZcPbkPpaEuEy1x3HALetpaewlXQMH5MPHERH4jiYJwAkDJO3LA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=manguebit.com; s=dkim; t=1687712334; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8htG7rHHL97H05txH4/SKfeVPifIbRS3sVXBTSrVOSE=; b=iRUBwExV1Lvs9hPbjJabR5A9ZJvEWiKRr7aF2LViMB2C3+TNXq32Wy9L4WzYgIVnhMviam Bd7FhhDiIjrPzJ9R/SA/0QYwJe8LfPMy20xqHEKwnR6e15q3s3d1kPEUFCNr7wv0wMX+n9 0zx4rYBqZqVGAxLIXRfUrN8Z2Aw3XEWdrbwhPh7wXs0w4sG6RHTvNyp0is3ONFUqj5ufu8 mWNt1tdrCFW68hipZIEbidkiw5GOPn1a5fpw9xVXpO2gjbI1zuRRJhEfEVEpS3VmJZJfHm A+mp0s1TtLWAj9hYqB5Ne8FPllaKQ9dDUuPQbGqiouDez1ZB8gLACK6nKV8Zgw== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=pc@manguebit.com smtp.mailfrom=pc@manguebit.com ARC-Seal: i=1; s=dkim; d=manguebit.com; t=1687712334; a=rsa-sha256; cv=none; b=RE/enp8w7n7guB26rl6danqPfbSofenjJIHR4AXZ0A5p8ftHFsrLfG5HXuoyfDcgxsn0Ka Vrbn/bNKPGSMpNezlEnXKbN7MXFydyZbk5nYM1kNuHGDvUehytDNbUVz3DrpLeqAX2HxG/ KMZyNL5uUqsH4pOlgXnhzyH2BaRn3XTSd4oy5a9GQv8TwfO/pwDPwDLTasTUA21v8j+GNe k5SCkZea6kkdHhzPjjPX6fwQ7Q+qUQgrDC6HCAWBbUQGVkvKzsnJVoT6qcQ6/dZj4cVDdB MFaLTsaREE4htp9dJPuXs+CWswRmEvsDyn0FbUbW42XiQoFQOWu7td0xUuoi9g== From: Paulo Alcantara To: David Laight , 'Rishabh Bhatnagar' , "gregkh@linuxfoundation.org" , "pc@cjr.nz" Cc: "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-cifs@vger.kernel.org" , Aurelien Aptel , Steve French Subject: RE: [PATCH 5.4 2/5] cifs: Get rid of kstrdup_const()'d paths In-Reply-To: <043b05d64bca40509bab7dd8e368e4e5@AcuMS.aculab.com> References: <20230623213406.5596-1-risbhat@amazon.com> <20230623213406.5596-3-risbhat@amazon.com> <043b05d64bca40509bab7dd8e368e4e5@AcuMS.aculab.com> Date: Sun, 25 Jun 2023 13:58:45 -0300 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org David Laight writes: > From: Rishabh Bhatnagar >> Sent: 23 June 2023 22:34 >> From: "Paulo Alcantara (SUSE)" >> >> commit 199c6bdfb04b71d88a7765e08285885fbca60df4 upstream. >> >> The DFS cache API is mostly used with heap allocated strings. >> > ... >> - ce->path = kstrdup_const(path, GFP_KERNEL); >> + ce->path = kstrndup(path, strlen(path), GFP_KERNEL); > > That is entirely brain-dead. Yep. It's got fixed up later by 8d7672235533 ("cifs: don't cargo-cult strndup()")