Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 26 Jun 2023 02:03:55 +0900
From:   Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>
To:     Xinghui Li <korantwork@gmail.com>
Cc:     dlemoal@kernel.org, helgaas@kernel.org,
        nirmal.patel@linux.intel.com, kbusch@kernel.org,
        jonathan.derrick@linux.dev, lpieralisi@kernel.org,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
        Xinghui Li <korantli@tencent.com>,
        Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH v2 0/2] PCI: vmd: Fix two issues in VMD reported by Smatch
Message-ID: <20230625170355.GA2459283@rocinante>
References: <20230420094332.1507900-1-korantwork@gmail.com>
 <20230624163314.GD2636347@rocinante>
 <CAEm4hYUhRCBo=N9EKUaSbBWZafKk0WzzwDWYmJ4FykpQoeZe1w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAEm4hYUhRCBo=N9EKUaSbBWZafKk0WzzwDWYmJ4FykpQoeZe1w@mail.gmail.com>
Precedence: bulk

Hello,

> > >   PCI: vmd: Clean up one inconsistent indenting warn reported by Smatch
> >
> > Even though this is a very nice clean-up, I did not take this patch at this
> > time, as there has been a similar patch posted in the past, and Christoph
> > Hellwig suggested, as part of his review, an alternative approach worth
> > considering.
> >
> > Have a look at the following and let me know what you think:
> >
> >   https://patchwork.kernel.org/project/linux-pci/patch/20221115054847.77829-1-jiapeng.chong@linux.alibaba.com/
> 
> I think Christoph Hellwig's suggestion is indeed better.
> So, should I submit a new patch to address this issue?

Please.  A single new patch would suffice.

Make sure to explain as part of the commit log why this specific change
that started as a Smatch complaint about an incorrect indentation.

Thank you!

	Krzysztof