Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp15200968rwd; Sun, 25 Jun 2023 12:19:02 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4Hv4lTwWoUKqx8Mm93U4h8QK9f3+gcCIqE4O9UwLMTXn/9oZZ/3pN8d8Lf97OzE0MkKZS0 X-Received: by 2002:a05:6000:c6:b0:313:f18d:1f2c with SMTP id q6-20020a05600000c600b00313f18d1f2cmr588139wrx.38.1687720742370; Sun, 25 Jun 2023 12:19:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687720742; cv=none; d=google.com; s=arc-20160816; b=C7wpnOiJ8OMJgDlS/3op7pOOs1/AUyKudga2ofjl5Ztf0kQAQ+jPW4MOs8PsfduU0k 7NU2I475Ftv8w+I69JX8jlF1y1ll6WyvX+Y/7to36UzhcIrT3SqaWjX9Dn5QCIITQeYj fG2wUy0pz3Tyr5dWPopKTRbV1xBdCQJnWex5kgavPfa0ZVaoNs9tIOWpAqID44v8Bw6C rvntedfGk9+Gju8vyZqh9tHRhcnzPKTUnfq7KCBujkwbrPfhtwJe55HbOYSuDrL3jvdg j8qD8Ofl0+siuXF/LylCk6fUTRpqU3KSUEkWMaeOXjkqbd53Nn6NMeQXWGsIIjkRZup3 gt1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=lptCDt96ilGC/OpMciopJy0C4Ydb0tBjW5sqv48x0yI=; fh=NNOM+n2OZPlTomZx7KkYFZcralbKnQQ74WDTuKMXAsA=; b=QErOwYMYpCLzLEXLUIqx+ef72xLIdKDT0GamI33GMm+DO2onnRj0Ufphizi9uD3dEN OVMGnMs7il/DP6SmXW3YLyzq6Yaxkz5MKExFeP0OKBRWfSxFHmSHuD+QdnsQnUsiX8RY VF8bd5QBUHju9h/7x7GU9TdY6QMlbgZWQaJajcArdF72N/BVmGQOx4wyIdgFKFfUrNzF ycu58bCSggxcYGYYJ0nzXavsjhhoULAQtAOFx33F6NefSEFH9m6NH42nMr2guqdhBX9a dzdZtTC0psYG9meGSV6OPhrv9xrLy1I4EYUkT9H8xR/Jx9t/qImcDmuJ0NI+wejfAtvQ i+OA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CeMe1IYv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y21-20020a50e615000000b0051a52a48ed4si1982326edm.156.2023.06.25.12.18.38; Sun, 25 Jun 2023 12:19:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CeMe1IYv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229447AbjFYSZR (ORCPT + 99 others); Sun, 25 Jun 2023 14:25:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229820AbjFYSZN (ORCPT ); Sun, 25 Jun 2023 14:25:13 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CF6EE5B; Sun, 25 Jun 2023 11:25:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EB7F760C05; Sun, 25 Jun 2023 18:25:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4FF24C433CC; Sun, 25 Jun 2023 18:25:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687717510; bh=lptCDt96ilGC/OpMciopJy0C4Ydb0tBjW5sqv48x0yI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=CeMe1IYvKi0//tHqDJz4UNqUgfOPgj7AYbqJvgjPCN3rAyYeLDIgfgkRHg692DUxO ro4TJRdCtCTTN4yh3DAogZlpn6V5lgmjrIxyllncClGuFYjHolKpJoHa+7OOo9fWBJ DAj4zIRHcc2Ean4pFspdOQug/ybALtUqSQtlfusjgVsGAC6gqOdx+erxxsMGIJYwCn d/mi0m/YvnKSTxbpjSnmpeqSjz9h0G9gtll4PvqldYYPD2iMBZytZUXuCUWuFGsEiC m46ZpkOzYjC2BK8ePYqiBupZAnFC4DpZgmQspiYcJq9nQ9EJgurXllS0eU0gH5Jax2 nt2JZ7Eqs/3sg== Received: by mail-oi1-f175.google.com with SMTP id 5614622812f47-39cc64e4a44so1264031b6e.0; Sun, 25 Jun 2023 11:25:10 -0700 (PDT) X-Gm-Message-State: AC+VfDwKy23XMyOkJ4+3zB3+tQ0ak05sjVUHe1CfteOZ/hYjV9fJxQWb vWVGJZLm42pZyIpHHOe6ZG6fxUgVay6yzF4WMek= X-Received: by 2002:a05:6808:191f:b0:3a1:dc0d:f31f with SMTP id bf31-20020a056808191f00b003a1dc0df31fmr719402oib.3.1687717509553; Sun, 25 Jun 2023 11:25:09 -0700 (PDT) MIME-Version: 1.0 References: <20230615111743.883891-1-masahiroy@kernel.org> In-Reply-To: From: Masahiro Yamada Date: Mon, 26 Jun 2023 03:24:33 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] kbuild: builddeb: always make modules_install, to install modules.builtin* To: Josh Triplett Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Ben Hutchings , linux-snps-arc@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 23, 2023 at 4:20=E2=80=AFAM Josh Triplett wrote: > > Even for a non-modular kernel, the kernel builds modules.builtin and > modules.builtin.modinfo, with information about the built-in modules. > Tools such as initramfs-tools need these files to build a working > initramfs on some systems, such as those requiring firmware. > > Now that `make modules_install` works even in non-modular kernels and > installs these files, unconditionally invoke it when building a Debian > package. > > Signed-off-by: Josh Triplett > --- Applied to linux-kbuild. Thanks. What I meant in my previous reply was to remove "if is_enabled CONFIG_MODULES; then" Anyway, I did it by myself in a follow-up patch. https://lore.kernel.org/linux-kbuild/20230625181623.2473308-1-masahiroy@ker= nel.org/T/#u --=20 Best Regards Masahiro Yamada