Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 25 Jun 2023 12:34:57 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Terry Bowman <terry.bowman@amd.com>, <alison.schofield@intel.com>,
        <vishal.l.verma@intel.com>, <ira.weiny@intel.com>,
        <bwidawsk@kernel.org>, <dan.j.williams@intel.com>,
        <dave.jiang@intel.com>, <Jonathan.Cameron@huawei.com>,
        <linux-cxl@vger.kernel.org>
CC:     <terry.bowman@amd.com>, <rrichter@amd.com>,
        <linux-kernel@vger.kernel.org>, <bhelgaas@google.com>
Subject: Re: [PATCH v7 01/27] cxl/acpi: Probe RCRB later during RCH
 downstream port creation
Message-ID: <649896e15db5a_1dff294b2@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <20230622205523.85375-1-terry.bowman@amd.com>
 <20230622205523.85375-2-terry.bowman@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230622205523.85375-2-terry.bowman@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3jV34szxilmP8W1uUuO+I8xzpRPuPqj6vsFF5h9IttUSHha8qUn4bi6jPkQ1?=
 =?us-ascii?Q?tQSGyW9HTzNntJ4Udk+pO8ZLSY9MwD4R6ifEjZxFzA5iCZ12ZeEWGxGmlsHS?=
 =?us-ascii?Q?EmDCzNcPQZotqWaEMcT0v6OpsMKS7NlBXnLnnHhmeusmBt1FtF+BMHwj8Kst?=
 =?us-ascii?Q?k5p1z3NHavijrKSQ/u7SNrAkE1Pg5apbQ6xXZv8upC/F6spZomZE1l36TxWa?=
 =?us-ascii?Q?vHz5YB0EywKrmhFBFpv9H0C0HjHf3a08MadaCzTs+vANu8A9xNtnLR9aarRV?=
 =?us-ascii?Q?gbhXHoo0++8QuYcwpS6mHyj3sw2hBzAgtOqz+hUSzdiLyoUG7ykJ1ZkGsdki?=
 =?us-ascii?Q?Gh9J00TDqFKJhIokChXG0g0H9ifolYBj0HWumXmmCYKZDnUZHWB48+NmsnK8?=
 =?us-ascii?Q?soUXwP755dD6mHUSyxoV03twwSY/8Zq++TBGwR4ElPj0ATjWN6Et0S4yjvor?=
 =?us-ascii?Q?1PLXRCg3dMts9h5+WcSRdsD6V2wDsOVGdgHUNNoWbcJQY7aDwhT7SmbKUn/u?=
 =?us-ascii?Q?Xu4sWlJZTTp/tNqR9TO7A9WApPj5EYRrCiNo+F8KcrhlfjyARKUJhRIpCu7Y?=
 =?us-ascii?Q?+kp+2CURnv7lzbJ9WqAOI45+WB5naNo8XIhiudZDVVow6JyDsDiupFcupAKK?=
 =?us-ascii?Q?VQR1mRa5u328q/di0lnPHuQlc5uGSvbjRuo8+yTHx5J6mQLcNqY1r2jlIXzz?=
 =?us-ascii?Q?RFypNPBsBN4tKbE3+JzjtjEk7U+ssVWCRxyJf/pJCAReVHnKq21EcPPDza2p?=
 =?us-ascii?Q?n0dBowSz0FPxlA7FEr4FfRR/F8YM8vlmrFpEgF6Bq0Ikv4+5qUMTDfKnjsML?=
 =?us-ascii?Q?YFF3bY8kka468L6vbIO7YlCXNneu2yhGOAU+t8ahZIP0n5brVzkw5rLnZZqP?=
 =?us-ascii?Q?q0UBH0qaEILtmt3OJjajXDwL4UNt18Iyclj2Alr7coM8u0INgQed4c5w2BbJ?=
 =?us-ascii?Q?KZvdCuHM0c+mtpSMOukVRQfPJChZHl5b81R5CrLQKHGarVp0Y5u9I41obJ+X?=
 =?us-ascii?Q?cj2M73RgRqbBIl+3aVVijRF1PHRUUFTXYC2yLk0+xwq4l0FJpbhlSWn0YUJz?=
 =?us-ascii?Q?Qm3eIB7Hv4WNr3jOVR+umLfTjzEWhDn1ThRDUuM9yk2OyLGI8pnop+NsVm0u?=
 =?us-ascii?Q?FcDd3wg6k1Z4WStnxTLQfoiNBsqAneBZXvzqOfnW0F8b9n7f7xN/2xPEIBZO?=
 =?us-ascii?Q?xV/AwbxWao8khN02lAD/EbmJrgy5UEAfcxeJUMHSX+0fMCopASRTGUdXbdbH?=
 =?us-ascii?Q?vf8uUDMRXqYmAsDp+VOe5RqtKhtjxHp56ASUuWDvsiuJsVfpc65udr1+rh/L?=
 =?us-ascii?Q?EgCHyhHFtf7t3l3J2mf1sD1nlWxjdSWzmOrjyveCOibNKNS/l7VjYyH91nnz?=
 =?us-ascii?Q?N1Qe/UANwOvXNoUjUIRK8eX19hZ8wiWi2U5Hepk1K8vLIskOClU1WV5gi6K3?=
 =?us-ascii?Q?d37C27vCu4btwweTzznt5GNp6nt2/+gNTAJNMwTYBsRqWXvcY618lwAm6CqH?=
 =?us-ascii?Q?BCBfRMY/fvLk0tNocZbj58/oRykGwRu6sQWfT1Nw8ps8glX9aEVxgoMYrLJP?=
 =?us-ascii?Q?BQVD7WrmqHk3v9yG9NWs+0+YgJilYrYyVTkPwKn+OksFz6zxRnZ7lyOBLnvu?=
 =?us-ascii?Q?+g=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b576e2f-9468-4d3e-b9bf-08db75b344fd
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jun 2023 19:35:02.1699
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EHcLibsJ0HfPkQu6xYc54DbciIHSNZO2MUKjECakA+9s5T/YkSzZNl9zRPpaxy9Ul97ST09AJr5c5NEJMmL4BEL4xm/owGNdDTKtMNk6n3c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR11MB5976
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Terry Bowman wrote:
> From: Robert Richter <rrichter@amd.com>
> 
> The RCRB is extracted already during ACPI CEDT table parsing while the
> data of this is needed not earlier than dport creation. This
> implementation comes with drawbacks: During ACPI table scan there is
> already MMIO access including mapping and unmapping, but only ACPI
> data should be collected here. The collected data must be transferred
> through a couple of interfaces until it is finally consumed when
> creating the dport. This causes complex data structures and function
> interfaces. Additionally, RCRB parsing will be extended to also
> extract AER data, it would be much easier do this at a later point
> during port and dport creation when the data structures are available
> to hold that data.
> 
> To simplify all that, probe the RCRB at a later point during RCH
> downstream port creation. Change ACPI table parser to only extract the
> base address of either the component registers or the RCRB. Parse and
> extract the RCRB in devm_cxl_add_rch_dport().
> 
> This is in preparation to centralize all RCRB scanning.

This patch by itself causes cxl_test build bisection breakage:

depmod: ERROR: Cycle detected: cxl_mock -> cxl_core -> cxl_mock
depmod: ERROR: Cycle detected: encrypted_keys
depmod: ERROR: Found 2 modules in dependency cycles!
make: *** [Makefile:1956: modules_install] Error 1

...so I will just squash it with the next patch and add a
co-developed-by.