Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp15251444rwd; Sun, 25 Jun 2023 13:30:25 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4lzDN4mQyGN/hxGXHgambiKQl7UDe6CvW0FL84GIawiJiTx2IQZu64W2hOWO8fHVN17V2K X-Received: by 2002:a17:902:d88a:b0:1b0:5304:5b48 with SMTP id b10-20020a170902d88a00b001b053045b48mr6143482plz.0.1687725025444; Sun, 25 Jun 2023 13:30:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687725025; cv=none; d=google.com; s=arc-20160816; b=LxlBGNkW9mmLFydhW8k3c6jpxoBHVI/TpZf1a+6YxdJvLbuERYbkPpXf3NRhQKlAlv zE1HH1HRGuft8ZMwUSSHoOI7PygfgdtMdY1z0/i6FMZynijKiEKH86EshRGtrpzsN47y 53C63QD1oebmN+qCT2bHeo4b/v6um3vg2aiCWIJefjh01+T7HRiwprkJ4+HX3PuKRrae iTCtyaTEi3fRTpQK7gLuJ9zSAusUk1dkxPkP9/aBReuoz7YTK2+X/ioptedbTnVSGtmx bxx1OAJLSbD6N5na+3ptCMWG0jOAqTucTA4jJdd4nYttV1iADfjRIlK3KRGuEj7IlkEy 9DRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature; bh=4paSFHeIlmi01eelJjcHibWu0numZnAAbkmYQwsVvVw=; fh=NH6SBFZaU/lSFO+3UnPjXUA3OjN1pLGzc47pac/kTcA=; b=0sW9ruhHKZb5qF64OMLTRDPjAVL0Lhc7NeaoGCxGKJEyDWSDK/0/1xWXF4P/DVr+zx Vx5jLB0DtOVYzqkKA05KnSrgUvuGYGd540IfZrBwjb39v2Fyx/Qhu3sejmy0nigKAryU Xi6Du6rSdWSGjoJXAHapQKSOjF8F30dDJcDvA41ahI+NHciYqk/76uAeFXUGpLlSc+ge e67hHDVzK9E+GuB0lbNttcf53dIlxZIO3o9hFNWP4RnqJk2wr8VA0XYf0sGoMpoPvysB mx3lqyl5ekgDgsnJ4U9pLfj/cHslpqm6t/o4hRAhsxa05DlDGMEQ/7Au7AilrwoQcezb jbzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@inria.fr header.s=dc header.b=uTuUd+lY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=inria.fr Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y3-20020a170902ed4300b001b248529a69si3603250plb.92.2023.06.25.13.30.12; Sun, 25 Jun 2023 13:30:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@inria.fr header.s=dc header.b=uTuUd+lY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=inria.fr Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230043AbjFYUZV (ORCPT + 99 others); Sun, 25 Jun 2023 16:25:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230023AbjFYUZT (ORCPT ); Sun, 25 Jun 2023 16:25:19 -0400 Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6BEE9E; Sun, 25 Jun 2023 13:25:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=4paSFHeIlmi01eelJjcHibWu0numZnAAbkmYQwsVvVw=; b=uTuUd+lYkqHEhC/7BYEgrQLODKlleWH78OO7eRNLvWWsdlxUHM5yQBYw xRE3XSszHkl6bHc1aHvBcIAto3CrGBfPhNk5l3nVLWEY6hW5S9ACjsQsM 7A95HWKENPTaXZGy4u+aI+Dsn1QImuOWTVzsQfDfeIGMLVGYx/9XNA9MI U=; Authentication-Results: mail3-relais-sop.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=julia.lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="6.01,158,1684792800"; d="scan'208";a="59758804" Received: from 231.85.89.92.rev.sfr.net (HELO hadrien) ([92.89.85.231]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2023 22:25:12 +0200 Date: Sun, 25 Jun 2023 22:25:11 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Christophe JAILLET cc: Jakub Kicinski , Julia Lawall , Veerasenareddy Burru , keescook@chromium.org, kernel-janitors@vger.kernel.org, Abhijit Ayarekar , "David S. Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, corbet@lwn.net Subject: Re: [PATCH 02/26] octeon_ep: use array_size In-Reply-To: Message-ID: References: <20230623211457.102544-1-Julia.Lawall@inria.fr> <20230623211457.102544-3-Julia.Lawall@inria.fr> <20230624152826.10e3789b@kernel.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1326197144-1687724711=:3022" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1326197144-1687724711=:3022 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Sun, 25 Jun 2023, Christophe JAILLET wrote: > Le 25/06/2023 à 00:28, Jakub Kicinski a écrit : > > On Fri, 23 Jun 2023 23:14:33 +0200 Julia Lawall wrote: > > > - oq->buff_info = vzalloc(oq->max_count * OCTEP_OQ_RECVBUF_SIZE); > > > + oq->buff_info = vzalloc(array_size(oq->max_count, > > > OCTEP_OQ_RECVBUF_SIZE)); > > > > vcalloc seems to exist, is there a reason array_size() is preferred? > > Hi, > > just for your information, I've just sent [1]. > > CJ > > [1]: > https://lore.kernel.org/all/3484e46180dd2cf05d993ff1a78b481bc2ad1f71.1687723931.git.christophe.jaillet@wanadoo.fr/ For some reason, I have only received Christophe's mail, not Jakub's... In any case, thanks for pointing out the existence of these functions. I just redid what Kees did in 2018, when I guess these functions didn't exist. I will look more carefully to see what functions are now available and resend the whole thing. Thanks! julia --8323329-1326197144-1687724711=:3022--