Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230623022334.791026-1-gnstark@sberdevices.ru>
 <20230623022334.791026-7-gnstark@sberdevices.ru> <CAFBinCBv993Xv_wk9fE-U0Tw2mzTB1z22Tj6x8Uy1rRw_dztng@mail.gmail.com>
 <67d2a9b7-ac7b-57f7-d053-cff4bf0f9d2e@sberdevices.ru>
In-Reply-To: <67d2a9b7-ac7b-57f7-d053-cff4bf0f9d2e@sberdevices.ru>
From:   Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date:   Sun, 25 Jun 2023 22:37:00 +0200
Message-ID: <CAFBinCCzx2e92S-cQp2CVup4hr6Ge12uCJ3Qh0+sqNVFRWkv7A@mail.gmail.com>
Subject: Re: [PATCH v2 6/6] meson saradc: support reading from channel7 mux inputs
To:     George Stark <gnstark@sberdevices.ru>
Cc:     jic23@kernel.org, lars@metafoo.de, neil.armstrong@linaro.org,
        khilman@baylibre.com, jbrunet@baylibre.com,
        andriy.shevchenko@linux.intel.com, nuno.sa@analog.com,
        linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
        kernel@sberdevices.ru
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi George,

On Fri, Jun 23, 2023 at 6:38=E2=80=AFPM George Stark <gnstark@sberdevices.r=
u> wrote:
[...]
> So I think to return to double definition of meson_sar_adc_iio_channels a=
nd keep the driver backwards compatible.
Ack!

> I've just realized another moment with channels defined after MESON_SAR_A=
DC_TEMP_CHAN in channel array.
Good catch

> In dts by default channels are referenced by channel array index not even=
 by channel number.
> So channel e.g MUX_0_VSS will have the same number (due to enum patch) bu=
t different index on meson8 and gxbb.
> As alternative we can implement fwnode_xlate method in meson adc driver a=
nd use channel numbers in dts (probably not in the current patchset)
That is actually an interesting third approach. But as you said: let's
start simple and add the tables back for now.


Best regards,
Martin