Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: iad51458e:Fastmail
Date:   Sun, 25 Jun 2023 16:13:51 -0700
From:   Boqun Feng <boqun.feng@gmail.com>
To:     =?iso-8859-1?Q?Bj=F6rn?= Roy Baron <bjorn3_gh@protonmail.com>
Cc:     Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        Gary Guo <gary@garyguo.net>,
        Benno Lossin <benno.lossin@proton.me>,
        rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rust: alloc: Add realloc and alloc_zeroed to the
 GlobalAlloc impl
Message-ID: <ZJjKL968vGuNeNmL@boqun-archlinux>
References: <20230622-global_alloc_methods-v1-1-3d3561593e23@protonmail.com>
 <ZJXXxEfzVza5Jzxj@boqun-archlinux>
 <R7bIOWHPBelVxutK-V8lFrSCh_diCIJtJxP-HbOJDV0i2VaKriARSwBRv8TaTevuT06lySKkBALLFJ8S_7q2Qzzr2fH4eceYXYO1_kp1jnI=@protonmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <R7bIOWHPBelVxutK-V8lFrSCh_diCIJtJxP-HbOJDV0i2VaKriARSwBRv8TaTevuT06lySKkBALLFJ8S_7q2Qzzr2fH4eceYXYO1_kp1jnI=@protonmail.com>
Precedence: bulk

On Sat, Jun 24, 2023 at 02:40:23PM +0000, Bj?rn Roy Baron wrote:
> On Friday, June 23rd, 2023 at 19:35, Boqun Feng <boqun.feng@gmail.com> wrote:
> 
> > On Thu, Jun 22, 2023 at 09:24:40PM +0200, Bj?rn Roy Baron via B4 Relay wrote:
> > 
> > > From: Bj?rn Roy Baron bjorn3_gh@protonmail.com
> > > 
> > > While there are default impls for these methods, using the respective C
> > > api's is faster. Currently neither the existing nor these new
> > > GlobalAlloc method implementations are actually called. Instead the
> > > _rust* function defined below the GlobalAlloc impl are used. With
> > > rustc 1.71 these functions will be gone and all allocation calls will go
> > > through the GlobalAlloc implementation.
> > > 
> > > Link: https://github.com/Rust-for-Linux/linux/issues/68
> > 
> > 
> > Nice! Although I think we need to do the simialr size adjustment as:
> > 
> > 	https://lore.kernel.org/rust-for-linux/20230613164258.3831917-1-boqun.feng@gmail.com/
> > 
> > so I applied your patch onto my patch and came up with the following:
> 
> Right. That patch LGTM.
> 

Thank you and Gary for the diff review, I will fold it into your
original patch and resend.

Regards,
Boqun

> Cheers,
> Bj?rn