Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230624133808.621805-1-jcmvbkbc@gmail.com> <562ff26d-df78-c1cb-6a34-b9a97efdc43e@web.de>
In-Reply-To: <562ff26d-df78-c1cb-6a34-b9a97efdc43e@web.de>
From:   Max Filippov <jcmvbkbc@gmail.com>
Date:   Sun, 25 Jun 2023 18:27:59 -0700
Message-ID: <CAMo8Bf+KeW8Gx22ddHjco2vJh1zanRaiHDvi0Jk0-rUpMX0kkg@mail.gmail.com>
Subject: Re: [PATCH] xtensa: dump userspace code around the exception PC
To:     Markus Elfring <Markus.Elfring@web.de>
Cc:     kernel-janitors@vger.kernel.org, Chris Zankel <chris@zankel.net>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Marcus,

On Sun, Jun 25, 2023 at 9:36=E2=80=AFAM Markus Elfring <Markus.Elfring@web.=
de> wrote:
>
> > In the absence of other debug facilities dumping user code around the
> > unhandled exception address may help debugging the issue.
>
> Please choose an imperative change suggestion.

The change itself is so small that it's fully described in the
subject, and I believe
that that description is imperative. This part is the rationale. From
my experience
I cannot guarantee that dumping user code will help, but sometimes it
does, hence
the 'may help'.
Please let me know if you have better wording.

--=20
Thanks.
-- Max