Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230608090124.1807-1-angus.chen@jaguarmicro.com>
In-Reply-To: <20230608090124.1807-1-angus.chen@jaguarmicro.com>
From:   Jason Wang <jasowang@redhat.com>
Date:   Mon, 26 Jun 2023 10:30:22 +0800
Message-ID: <CACGkMEtp6H1x301CynwDfsXCMOVt_mrVh9G7dUxVdDLdLBB8yg@mail.gmail.com>
Subject: Re: [PATCH v2] vdpa/vp_vdpa: Check queue number of vdpa device from add_config
To:     Angus Chen <angus.chen@jaguarmicro.com>
Cc:     mst@redhat.com, virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Jun 8, 2023 at 5:02=E2=80=AFPM Angus Chen <angus.chen@jaguarmicro.c=
om> wrote:
>
> When add virtio_pci vdpa device,check the vqs number of device cap
> and max_vq_pairs from add_config.
> Simply starting from failing if the provisioned #qp is not
> equal to the one that hardware has.
>
> Signed-off-by: Angus Chen <angus.chen@jaguarmicro.com>
> ---
> v1: Use max_vqs from add_config
> v2: Just return fail if max_vqs from add_config is not same as device
>         cap. Suggested by jason.
>
>  drivers/vdpa/virtio_pci/vp_vdpa.c | 35 ++++++++++++++++++-------------
>  1 file changed, 21 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/vdpa/virtio_pci/vp_vdpa.c b/drivers/vdpa/virtio_pci/=
vp_vdpa.c
> index 281287fae89f..c1fb6963da12 100644
> --- a/drivers/vdpa/virtio_pci/vp_vdpa.c
> +++ b/drivers/vdpa/virtio_pci/vp_vdpa.c
> @@ -480,32 +480,39 @@ static int vp_vdpa_dev_add(struct vdpa_mgmt_dev *v_=
mdev, const char *name,
>         u64 device_features;
>         int ret, i;
>
> -       vp_vdpa =3D vdpa_alloc_device(struct vp_vdpa, vdpa,
> -                                   dev, &vp_vdpa_ops, 1, 1, name, false)=
;
> -
> -       if (IS_ERR(vp_vdpa)) {
> -               dev_err(dev, "vp_vdpa: Failed to allocate vDPA structure\=
n");
> -               return PTR_ERR(vp_vdpa);
> +       if (add_config->mask & BIT_ULL(VDPA_ATTR_DEV_NET_CFG_MAX_VQP)) {
> +               if (add_config->net.max_vq_pairs !=3D (v_mdev->max_suppor=
ted_vqs / 2)) {
> +                       dev_err(&pdev->dev, "max vqs 0x%x should be equal=
 to 0x%x which device has\n",
> +                               add_config->net.max_vq_pairs*2, v_mdev->m=
ax_supported_vqs);
> +                       return -EINVAL;
> +               }
>         }
>
> -       vp_vdpa_mgtdev->vp_vdpa =3D vp_vdpa;
> -
> -       vp_vdpa->vdpa.dma_dev =3D &pdev->dev;
> -       vp_vdpa->queues =3D vp_modern_get_num_queues(mdev);
> -       vp_vdpa->mdev =3D mdev;
> -
>         device_features =3D vp_modern_get_features(mdev);
>         if (add_config->mask & BIT_ULL(VDPA_ATTR_DEV_FEATURES)) {
>                 if (add_config->device_features & ~device_features) {
> -                       ret =3D -EINVAL;
>                         dev_err(&pdev->dev, "Try to provision features "
>                                 "that are not supported by the device: "
>                                 "device_features 0x%llx provisioned 0x%ll=
x\n",
>                                 device_features, add_config->device_featu=
res);
> -                       goto err;
> +                       return -EINVAL;
>                 }
>                 device_features =3D add_config->device_features;
>         }
> +
> +       vp_vdpa =3D vdpa_alloc_device(struct vp_vdpa, vdpa,
> +                                   dev, &vp_vdpa_ops, 1, 1, name, false)=
;
> +
> +       if (IS_ERR(vp_vdpa)) {
> +               dev_err(dev, "vp_vdpa: Failed to allocate vDPA structure\=
n");
> +               return PTR_ERR(vp_vdpa);
> +       }
> +
> +       vp_vdpa_mgtdev->vp_vdpa =3D vp_vdpa;
> +
> +       vp_vdpa->vdpa.dma_dev =3D &pdev->dev;
> +       vp_vdpa->queues =3D v_mdev->max_supported_vqs;

Why bother with those changes?

        mgtdev->max_supported_vqs =3D vp_modern_get_num_queues(mdev);

Thanks


> +       vp_vdpa->mdev =3D mdev;
>         vp_vdpa->device_features =3D device_features;
>
>         ret =3D devm_add_action_or_reset(dev, vp_vdpa_free_irq_vectors, p=
dev);
> --
> 2.25.1
>