Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] mm: memory-failure: remove unneeded page state check in
 shake_page()
To:     Matthew Wilcox <willy@infradead.org>
CC:     <akpm@linux-foundation.org>, <naoya.horiguchi@nec.com>,
        <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
References: <20230625113430.2310385-1-linmiaohe@huawei.com>
 <ZJiacZIkvIv1P3AK@casper.infradead.org>
From:   Miaohe Lin <linmiaohe@huawei.com>
Message-ID: <8f8f7622-9bea-c344-4e54-ef902129de67@huawei.com>
Date:   Mon, 26 Jun 2023 09:40:48 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <ZJiacZIkvIv1P3AK@casper.infradead.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023/6/26 3:50, Matthew Wilcox wrote:
> On Sun, Jun 25, 2023 at 07:34:30PM +0800, Miaohe Lin wrote:
>> Remove unneeded PageLRU(p) and is_free_buddy_page(p) check as slab caches
>> are not shrunk now. This check can be added back when a lightweight range
>> based shrinker is available.
> 
> On further review, I think you've misunderstood the entire situation
> here and no patch should be applied.

Thanks for your review. I think you might misunderstood the patch. What I want
to do here is remove the unneeded if block:

 if (PageLRU(p) || is_free_buddy_page(p))
     return;

Because nothing is done after the check. So this check is useless and should be removed.
Thanks.