Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp15801434rwd; Mon, 26 Jun 2023 01:16:24 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6EdauuJkbhjx37yl0k7iKj33gGiUK4nPuJd4/ItdlRiiyrV92I4PYdIvZ+52pra7r/sBy/ X-Received: by 2002:a17:907:868e:b0:991:e694:d699 with SMTP id qa14-20020a170907868e00b00991e694d699mr378993ejc.11.1687767384653; Mon, 26 Jun 2023 01:16:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687767384; cv=none; d=google.com; s=arc-20160816; b=LkBQ3HpXQ63OW+JkyqEz6cZq1kjUGUsuZL9RPuo8VVCSJx7d2FeGyIyd1nKtNtCrzQ PRrrSLq7X8+pYcszalUfY7zaT5fns6j0b/mnAlrtwNdMWB/oFBveqPGhFRRhJ3IzSlNo GaeWlVJwGW5M8tlmdi/I4loLNr5d2rvqwpqIUvNWEPC8bxvU+MqYSFx37ma5qrLc3x7e rDixXERHJqWubArBTb4gpLf7NaNeDPIUpnLcVlIo4rhhy5mwu18EiLqBzzsqAqjHLr42 YjYpR8DptkIuRres8wPDvrldlQWCKVKI/t6OK3yhx4Ylm1f6EknT9ZtVcCT0SdafxzBy 8NhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=mRzmdoMOtwkf0T97YbD2JaDd570KRK5k9OjuvNurjw8=; fh=KK3+ckrYJBYYRdVlKa7cICeLFmDq2X0JvG0URe0kWsE=; b=KdE4DqmL5CKO/3OZmF6Q2af+tmJgtCDoUjeC2wi8LZoEaMHhhneEkiCCMD6wLVlGqK xZzAW1CrJpak1RMVyihbIPgIt3Xo++Kv5QcD3YJqqOcQPuDrCxMak1SYuN3DCcIKLTtr JopaiNr4TdPMFp42UhDEuLBMJOvfeBwJ6ae9crGBUpHPGkPbj0Tc8yFiZ0u+Zu3K62qj xroPOJcN+BWz7+z2YnnmMp63xv+lcSCO5UintvmbPGCChZqPuBXeTYxDpQD8Ofz6ojmA M8+p7oJCyFNe4mjlmjI78IW8uYNqH9kmR6vVYdwcvTog75bVK3/v02+kzp+tUNTsSU1d irdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bytedance.com header.s=google header.b=XeB3HoE8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=bytedance.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a6-20020a17090680c600b0098e296a0aa8si1642879ejx.621.2023.06.26.01.15.59; Mon, 26 Jun 2023 01:16:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bytedance.com header.s=google header.b=XeB3HoE8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=bytedance.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229712AbjFZIFU (ORCPT + 99 others); Mon, 26 Jun 2023 04:05:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229599AbjFZIFS (ORCPT ); Mon, 26 Jun 2023 04:05:18 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18B2BB8 for ; Mon, 26 Jun 2023 01:05:17 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-3112f256941so2577718f8f.1 for ; Mon, 26 Jun 2023 01:05:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1687766715; x=1690358715; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=mRzmdoMOtwkf0T97YbD2JaDd570KRK5k9OjuvNurjw8=; b=XeB3HoE8oMKBsezzW5LgcB9DcBXwyNp3TCTl63jec1OkUmWQoPRDnM8T8j5tk2EODK eAIftr0uWaFzQ5LZWXCpMPe2pmJ8E6VRQHvEofQScu9rtyUSmhSurvndmJ3Gn0/ULHA9 1540fICw2DmnEMWkdl5jZe/h8lya1AZF4IxTd+gajLlzIe8MHlPevohJ72v3MqB3Su/Y C8GSzDfLFPwPMp06mlq71dM9h/K72L5Mem1dOeZ2Los3FRw3+cRM2ALCs3JY8IYChqmC HhHrHc1z0jTNj8PBMXLYdNldipHV7Yr2L/0CJvbIysheBhr3NoaAzsKC0UbW2+VANiJa qMOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687766715; x=1690358715; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mRzmdoMOtwkf0T97YbD2JaDd570KRK5k9OjuvNurjw8=; b=bs97Gg++4I5BKCDAVPTVwHkh2sXB+Kiz8aguvaNjkabjDZw3H+6l6v35CIbuwknGIP urul2521oJqEclQWJGLWyAeFp++Y+rLW2dKzWmOr6BfNWwtcPAxBrcF/k1ejOveWLjbM OuT+NA13Mo6ZvWJbvosGFfE7ZQessnMLX17cfw5+XHV2a/aHA87SuOrJ6iA14+LtU3Yl cmvRFc71jYcNuJ/9Mef2ePa6TA/N8Ibjk/ohMr4So7GEPrNm1QzbgDVYcUtBWG1fs1Tw kYf6ViYSRtQl0Ab6BBEEcMtlh/Ady1p8yV6pF9YE15eNo/iDguK3iA0PhE2egqu/PC0Y 63qw== X-Gm-Message-State: AC+VfDzmJrtNsfl9IHZ9k2AVroTFvrbDD8PrsEyiiQTIpVH6QYPZBWAY oZMtieiYVVz4tX0wxJTBFP4FXS9oGhhoL6s7XjfUYA== X-Received: by 2002:a5d:674b:0:b0:313:ebbf:3696 with SMTP id l11-20020a5d674b000000b00313ebbf3696mr2389037wrw.46.1687766715552; Mon, 26 Jun 2023 01:05:15 -0700 (PDT) MIME-Version: 1.0 References: <20230426034001.16-1-cuiyunhui@bytedance.com> In-Reply-To: From: =?UTF-8?B?6L+Q6L6J5bSU?= Date: Mon, 26 Jun 2023 16:05:04 +0800 Message-ID: Subject: Re: [External] Re: [PATCH] firmware: added a firmware information passing method FFI To: Ard Biesheuvel Cc: ron minnich , Mark Rutland , Lorenzo Pieralisi , rafael@kernel.org, lenb@kernel.org, jdelvare@suse.com, yc.hung@mediatek.com, angelogioacchino.delregno@collabora.com, allen-kh.cheng@mediatek.com, pierre-louis.bossart@linux.intel.com, tinghan.shen@mediatek.com, lkml - Kernel Mailing List , linux-acpi@vger.kernel.org, =?UTF-8?B?6JGb5aOr5bu6?= , =?UTF-8?B?6Z+m5Lic?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ard, On Mon, Jun 26, 2023 at 2:43=E2=80=AFPM Ard Biesheuvel wr= ote: > I think all of this belongs under arch/riscv Could you look at the content of the patch again? As we discussed before, we need to connect to the ACPI and the SMBIOS entry At least this part of the code has to be placed in the corresponding place: drivers/acpi/osl.c: acpi_os_get_root_pointer() drivers/firmware/dmi_scan.c:dmi_scan_machine() Because obtaining firmware information through DTS belongs to the content of the driver firmware, it is appropriate to put this piece of code in drivers/firmware/ffi.c. So I insist on the current revision, what do you think? Thanks, Yunhui